Received: by 2002:ac8:5349:0:b0:427:7d78:cd45 with SMTP id d9csp827766qto; Wed, 20 Dec 2023 05:14:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLF3h41uyoUKE8i/cAJupDGnl4BhVrrHIaNwYV1n4t2lebpzSq61RbdFdOtyWgOj8dgo5a X-Received: by 2002:a2e:7d01:0:b0:2cc:7a3b:7f0a with SMTP id y1-20020a2e7d01000000b002cc7a3b7f0amr1756942ljc.83.1703078045935; Wed, 20 Dec 2023 05:14:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703078045; cv=none; d=google.com; s=arc-20160816; b=zQexg9pqkkz5jI1fDwuYky6LDGxlG0pEvsSJsa2ptlCyhliP2bE0fgzFdEE4pWwwNQ GKqntMGsnU6DiTlhArFIGYT/na78kmpL6RYMcZapWeQt8o8jPxo7YL+sxPNe4K/Tf/9z SaaT6zSN6japN6cTSdjobYV2N3J4jPnlmU954e4u06+xsNR+k/cq5IFB//gcaRT6o2sF SMSJwN0xV8tXsoFXxiOYYuP5GmAuPkUJILYWKTZ0JQ51Ab85FNHhpWXkaDcYUi8+wXEx WIYG0L7PLV93t8HUYtUBuTf5UhjwYeCEx1MEFTgnMv2C9HCSXXYTpbpSAW06XmdRJnsF //Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=YOS8DTrvmPSw+knXmLbsq5Dg1l74tlA+SpqMinNtpIo=; fh=LHRTq9thNEACMD0qBjD6B9S+nOe/Hp3ktHOz28LPc14=; b=pdH+C1XPsr5f4yj0pJd5Y8MoYs9LQz6uPCeTVIEGOj7rrqTnH43W+q1E5VB9lsCg/u in99/Zb5Awt8+e0p3aKhqgv4f6CNj4sdOEU+WLSUjtXMG0eOyUNzWSnv+l6HIBQMYvzb tCU7Z2Kf1HmBOk5UdirWP1VblsGo2vgl1gp1iwtsahZhrbXjOupEo0mfQSb/T2uaj2WN Vrvycr5EY4fexceMnLVFPByJ+r3vH9zON/m4JJfNU07YeSr2LoRt0tAmCz31/WxT9fMd gWQtyJayTE0Qm3GfrQL2DqDB8PhU63laK7lRWRxPeiMf+jG+mEgmID2qD1PvWdYZVx+d rwaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=CFJ6GVQ0; spf=pass (google.com: domain of linux-kernel+bounces-6946-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6946-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v5-20020a056402348500b0054c71e31e71si12102577edc.43.2023.12.20.05.14.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 05:14:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6946-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=CFJ6GVQ0; spf=pass (google.com: domain of linux-kernel+bounces-6946-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6946-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 89E861F22A2B for ; Wed, 20 Dec 2023 13:14:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9E232CCB4; Wed, 20 Dec 2023 13:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="CFJ6GVQ0" X-Original-To: linux-kernel@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD4536AE5; Wed, 20 Dec 2023 13:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1703078033; bh=U12hPniJ+DF7IxQzd9EDTvjLsfdGz2472CrJfYpM9O0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CFJ6GVQ0Qq/6obqVZnHcU/vZWLRZCY+ZYJn45S9ToZ3nFiZkTN6TZc6JYzpiAhdXb VscFsaNOUSZbDHINbB/rOolsFnUhV7LcwvpVdQrQzTX3mTOqY5KRmUrYr7RkNk7z3g ejipU50/EvlQ9S2xC+AX9WJAM3JewvYLNjnFNwGhSJOBIUDb6W45vczg1L3HA9hAVi 4CqQ81S6JhAEvutaN22Hx2yXDkah9uEdTGgWL4UZ1Nu+i7uVGyhJdmqCJ1Mni1cQEU kbuvch/iDfRj8F6p0REB/k91oxNa+WZ+y0B/r/4QIYqZRmNhDlKufsCazYbVJdkQct 8QLw6SRI0rMkw== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id AAD32378107D; Wed, 20 Dec 2023 13:13:52 +0000 (UTC) Message-ID: <479fa717-8de7-4f1b-b02c-2cfbd49f71cc@collabora.com> Date: Wed, 20 Dec 2023 14:13:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information Content-Language: en-US To: Krzysztof Kozlowski , William-tw Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Srinivas Kandagatla Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20231220103901.22180-1-william-tw.lin@mediatek.com> <20231220103901.22180-3-william-tw.lin@mediatek.com> <97d54894-7c71-49d8-a456-869c398636ec@linaro.org> From: AngeloGioacchino Del Regno In-Reply-To: <97d54894-7c71-49d8-a456-869c398636ec@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 20/12/23 12:34, Krzysztof Kozlowski ha scritto: > On 20/12/2023 11:39, William-tw Lin wrote: >> Add driver for socinfo retrieval. This patch includes the following: >> 1. mtk-socinfo driver for chip info retrieval >> 2. Related changes to Makefile and Kconfig >> >> Signed-off-by: William-tw Lin > > ... > >> +static struct platform_driver mtk_socinfo = { >> + .probe = mtk_socinfo_probe, >> + .remove_new = mtk_socinfo_remove, >> + .driver = { >> + .name = "mtk-socinfo", >> + }, >> +}; >> +builtin_platform_driver(mtk_socinfo); > > module platform driver, because this is tristate and because this should > be a module. > Oh! Yes, right! Thanks for catching that, it totally slipped off my brain. Cheers, Angelo