Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754484AbXLHVWx (ORCPT ); Sat, 8 Dec 2007 16:22:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752203AbXLHVWp (ORCPT ); Sat, 8 Dec 2007 16:22:45 -0500 Received: from tetsuo.zabbo.net ([207.173.201.20]:54686 "EHLO tetsuo.zabbo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbXLHVWo (ORCPT ); Sat, 8 Dec 2007 16:22:44 -0500 Message-ID: <475B0B11.1090008@oracle.com> Date: Sat, 08 Dec 2007 13:22:25 -0800 From: Zach Brown User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: =?UTF-8?B?U2ltb24gSG9sbSBUaMO4Z2Vyc2Vu?= CC: linux-kernel@vger.kernel.org, Linus Torvalds , Ingo Molnar , Ulrich Drepper , Arjan van de Ven , Andrew Morton , Alan Cox , Evgeniy Polyakov , "David S. Miller" , Suparna Bhattacharya , Davide Libenzi , Jens Axboe , Thomas Gleixner , Dan Williams , Jeff Moyer , suresh.b.siddha@intel.com Subject: Re: [PATCH 1/6] indirect: use asmlinkage in i386 syscall table prototype References: <1196983219534-git-send-email-zach.brown@oracle.com> <11969832193635-git-send-email-zach.brown@oracle.com> <1197117625.19335.3.camel@odie.local> In-Reply-To: <1197117625.19335.3.camel@odie.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 19 >> + extern asmlinkage long (*sys_call_table[])(long, long, long, > This should be something like below instead, otherwise gcc wont parse > asmlinkage as being an attribute of the function signature. > extern long (asmlinkage *sys_call_table[])(long, long, long, Yeah, thanks for pointing these out. As it happened, Jens beat you to it :). Both problems have been fixed in the git repositories for the guilt series and userspace tools, respectively. You can always fetch the most recent versions from there. - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/