Received-SPF: pass (google.com: domain of linux-kernel+bounces-7006-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 20 Dec 2023 07:58:26 -0600
From: Rob Herring <robh@kernel.org>
To: Anshul Dalal <anshulusr@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>, devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>, Shuah Khan <skhan@linuxfoundation.org>, Conor Dooley <conor+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: dac: add MCP4821
Message-ID: <170308069917.116385.808780928089948753.robh@kernel.org>
References: <20231219090252.818754-1-anshulusr@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231219090252.818754-1-anshulusr@gmail.com>


On Tue, 19 Dec 2023 14:32:50 +0530, Anshul Dalal wrote:
> Adds support for MCP48xx series of DACs.
> 
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/22244B.pdf #MCP48x1
> Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/20002249B.pdf #MCP48x2
> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
> 
> ---
> 
> Changes for v4:
> - Removed 'Reviewed-by: Conor Dooley' due to changes
> - Renamed shdn-gpios to powerdown-gpios to conform to
>   gpio-consumer-common.yaml
> 
> Changes for v3:
> - Added gpios for ldac and shutdown pins
> - Added spi-cpha and spi-cpol for the SPI mode 0 and 3
> 
> Changes for v2:
> - Changed order in device table to numerical
> - Made vdd_supply required
> - Added 'Reviewed-by: Conor Dooley'
> 
> Previous versions:
> v3: https://lore.kernel.org/lkml/20231218164735.787199-1-anshulusr@gmail.com/
> v2: https://lore.kernel.org/lkml/20231217180836.584828-1-anshulusr@gmail.com/
> v1: https://lore.kernel.org/lkml/20231117073040.685860-1-anshulusr@gmail.com/
> ---
>  .../bindings/iio/dac/microchip,mcp4821.yaml   | 86 +++++++++++++++++++
>  1 file changed, 86 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4821.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>