Received: by 2002:a05:7412:d024:b0:f9:90c9:de9f with SMTP id bd36csp46755rdb; Wed, 20 Dec 2023 06:04:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyF/ukIlDTTMpF5oYb2VQZ7kaKs5EHxcgxVP897I1MLyflpFq0lnwhZPToLhxqm+/FeWwL X-Received: by 2002:a05:6214:224e:b0:67f:39b0:39a8 with SMTP id c14-20020a056214224e00b0067f39b039a8mr8600900qvc.95.1703081057609; Wed, 20 Dec 2023 06:04:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703081057; cv=none; d=google.com; s=arc-20160816; b=M5jt1JJOgTpR2j5OVoMrJrwm0Hvy/5ZrlD1eC4GIWzXjxQTxfUpqAALeSVNwufis6C mNEFMsNzewu5qf43v9nnsEEsgv6UV6dTtABhlw9g9RLCGjJAez5CF6l53YbphQ9uQugX IkBFI76FZY4oKI11CZLuhNZDwRLyaZJsL8mLYrEvVhXEoKzl7QQTsGejPkbwlLETi20Q VDQS3LhY9mx3bMPBCJhUp3JiqnRJbokvSBOe8Rf3eq3C+usL2v4u9a2i2SEfaCvBEWQF 6xb3eTiao1RxIx6OggEdRqo0ulILJxsInZak4SXx9NDC6yfI85VAy4qBCUTr5QiKNu6N PnPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=JTqpvDQYqhjfFV5RduDIL88xc14VK/R07myJ1uW9Vk4=; fh=TFQI+YzLUQlYl4kOcmLiE6H8IBxzIqYzJVz8pYCx9C4=; b=UnovFAb/COYWolSecGefSSkX2pMCkh0Qrwx6M5qJQsH/z2B396eGdPjyyYVSuF9EcL EGQpNb8xiyt7WFIwt5AfYKEoUgi5kIR/Mqd6szosOrX+sT+WUU/xl1SutxQ+QIKadVcZ 3JHdc1DQv5kpnbqdrbCtsfNhQnxclYvWb/AGTJdtbHPum27TyQ1z2lBFHKvQNnZP591G ++QM3g1qhfjczP76KzyS+q3+vOz4GYcqSoa9lQBjXLeZjirjIL1XGHrZ7h5XPHdKrQml 3Dbf6XdoTrf0hUdu0FTKuGnOxI8hdzfYJynDul493tLG0qBPOPWS4Dgw2yf7PGOGK1pu fvBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E2DHSkyS; spf=pass (google.com: domain of linux-kernel+bounces-7025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id r10-20020a0ccc0a000000b0067f3acb6c6asi8101937qvk.113.2023.12.20.06.04.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 06:04:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=E2DHSkyS; spf=pass (google.com: domain of linux-kernel+bounces-7025-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 65A6D1C2484E for ; Wed, 20 Dec 2023 14:04:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34C4538F9B; Wed, 20 Dec 2023 14:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E2DHSkyS" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27AF738F8B; Wed, 20 Dec 2023 14:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703081016; x=1734617016; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=73XKsW1ZgCZGQbP0ufu1p+PpSauwCpYAIatA4xw2yCo=; b=E2DHSkySCm+fvXY9pAQ+AGNGkuGCJ9N8fFQg6odXqEQ4XrdY5yUuo1Tw s6G8BRmuCngjk45f3vhU4EsksJMxRviRFDQXSvXjUVtWVModVPNLoMm9O 9VvXxUnSaglQ0wb04+uhHY+uG94FYl8vqLvP+6KnQpglFKj6ZskTugQN2 qc/3hCKuEQ+0r2dI+xDdSL55kV6yO2CUTY3CGX89bWORoSry8HvvYKooI Aiq5uQ3kZpt0k0eTiDMl0r0KWoDi8JxPREjsnsTz5S/+k5FFYiBQHYidX KsmCL749Bnl/7gQHosu6ddKaKc6V4giY3vzRFt9+88xCGE5/6yOIbaQLk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="375306135" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="375306135" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 06:03:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="1107734943" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="1107734943" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 06:03:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rFxAY-00000007YLI-15sy; Wed, 20 Dec 2023 16:03:30 +0200 Date: Wed, 20 Dec 2023 16:03:29 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Kent Gibson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [RFC PATCH] gpiolib: remove extra_checks Message-ID: References: <20231219201102.41639-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219201102.41639-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Dec 19, 2023 at 09:11:02PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > extra_checks is only used in a few places. It also depends on > a non-standard DEBUG define one needs to add to the source file. Huh?! What then CONFIG_DEBUG_GPIO is about? > The > overhead of removing it should be minimal (we already use pure > might_sleep() in the code anyway) so drop it. ... I agree on might_sleep() changes, but WARN_ON(), see above why. -- With Best Regards, Andy Shevchenko