Received-SPF: pass (google.com: domain of linux-kernel+bounces-7049-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d7826ddcd6db86773b57ffe603df9b18d95a5252.camel@linux.ibm.com>
Subject: Re: [PATCH v2 0/3] evm: disable EVM on overlayfs
From: Mimi Zohar <zohar@linux.ibm.com>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-unionfs@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
        Seth
 Forshee <sforshee@kernel.org>,
        Roberto Sassu <roberto.sassu@huaweicloud.com>
Date: Wed, 20 Dec 2023 09:19:20 -0500
In-Reply-To: <20231220-komprimieren-kooperativ-cdb5e8803ce0@brauner>
References: <20231219175206.12342-1-zohar@linux.ibm.com>
	 <20231220-komprimieren-kooperativ-cdb5e8803ce0@brauner>
Content-Type: text/plain; charset="ISO-8859-15"
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Wed, 2023-12-20 at 13:35 +0100, Christian Brauner wrote:
> On Tue, Dec 19, 2023 at 12:52:03PM -0500, Mimi Zohar wrote:
> > EVM verifies the existing 'security.evm' value, before allowing it
> > to be updated.  The EVM HMAC and the original file signatures contain
> > filesystem specific metadata (e.g. i_ino, i_generation and s_uuid).
> > 
> > This poses a challenge when transitioning from the lower backing file
> > to the upper backing file.
> > 
> > Until a complete solution is developed, disable EVM on overlayfs.
> > 
> > Changelog v2:
> > Addressed Amir's comments:
> > - Simplified security_inode_copy_up_xattr() return.
> > - Identified filesystems that don't support EVM based on a new SB_I flag.
> 
> We're wasting a flag for a single filesystem but we do have enough of
> them left so I think this is ok,

Thanks, Christian.

> 
> Reviewed-by: Christian Brauner <brauner@kernel.org>