Received: by 2002:a05:7412:d024:b0:f9:90c9:de9f with SMTP id bd36csp68933rdb; Wed, 20 Dec 2023 06:33:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhPNWNH/DFzS8GGTbc8f3gopdNIzVjIxxtCgp59YxiWmbxN036PHmBfjtQmLLf2PAoJXq1 X-Received: by 2002:a17:907:9344:b0:a26:97fe:b8cc with SMTP id bv4-20020a170907934400b00a2697feb8ccmr553832ejc.66.1703082829938; Wed, 20 Dec 2023 06:33:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703082829; cv=none; d=google.com; s=arc-20160816; b=0SSlmtfn9IWtJQq7xgPZkttLFFy5DO1ncwhiQ81ETPOt94lduJ8DLfsdcmKQII6NRc H2uimLEuqcLSgujJqzAVTKphuUy9jd1teWpXoo/8neO73YspK4QQ11byV//RK+Efea+J I64lVHid9RNKY/QPQmO7lSIZGmyZtH+soU+HVOJPgnSR28l6HnfgPKgHKR/X9Y81cGCI 1kTLi3BHSydEFHgx8CdoPcSMerTzgmX7GlUpPV2LAdPi/S3ZrPj5QsRNgfGZ+KO6fZIt pTD1DWnoXY9Ss+yjx5FxSV+nwDQj9qVQVBOva231/DZURkHXfenVM6mShadZaxEF4rvu 5VeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=QCDlEbzW5TXyMCl1UgCkBMj1mXpk7iFNAzzxSB/CW7k=; fh=ABWBaMehZP2Os1+EK5Q829Rni/ThTUOddiItMakPv7A=; b=veNcfozXJT+zND5sRphfy2/t4WzkJkCc67j+5LZ22gV50FJSSq7Vsyd/Hcq19X7qeU zz6VcFZPpqOXEWqsH+L+Z4VYYYbln2AQ8RSfPTFKM1z0+vmNjUbQbq1+jG53EvG3TLXY ACsjep1LqtRLesBQE0aNmxhusgNrbGGuexpm34ryH5nZEf9VTB9z2FC4vTFX2ielY7J1 8q1BUKttqjfU7k12lKhxLwfsf8o846NlKCh+b48BC+Kt15XF+TIEtnfzMyv+qR2v3xKn kOdvaWSnQekNc7zywWAftioawAe+7IxHe2U25encTzdsSCfjqmhor2cJobFoKU4efPyz VPFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="Sg/diu03"; spf=pass (google.com: domain of linux-kernel+bounces-7064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lj1-20020a170906f9c100b00a1c56d97dd9si11788253ejb.416.2023.12.20.06.33.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 06:33:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="Sg/diu03"; spf=pass (google.com: domain of linux-kernel+bounces-7064-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AF0091F22AB3 for ; Wed, 20 Dec 2023 14:33:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F05643B188; Wed, 20 Dec 2023 14:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Sg/diu03" X-Original-To: linux-kernel@vger.kernel.org Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.219]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D96B73AC02 for ; Wed, 20 Dec 2023 14:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=QCDlE bzW5TXyMCl1UgCkBMj1mXpk7iFNAzzxSB/CW7k=; b=Sg/diu03Ax4XfZjm6TMk7 5OlqjZgDlajl/+R3TSyeRgkfPDV47LhVUbmqu229lig4gFeHFv4n76B5BcCfmbbK c9lxpd0jyTrey/QQ9rSjWjzI9ZUWPgW5VK7VFzdDOvsu04LdnNjthwu1QYjqo/qo F2u9D970PErHVz+ofWtOdI= Received: from localhost.localdomain (unknown [120.229.70.191]) by zwqz-smtp-mta-g1-3 (Coremail) with SMTP id _____wD3_xQR+4JlSE6KDA--.26908S2; Wed, 20 Dec 2023 22:32:51 +0800 (CST) From: Junwen Wu To: laoar.shao@gmail.com Cc: bristot@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, vincent.guittot@linaro.org, vschneid@redhat.com, wudaemon@163.com Subject: Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error in sched_stat_wait trace_point Date: Wed, 20 Dec 2023 14:32:49 +0000 Message-Id: <20231220143249.833273-1-wudaemon@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231220140112.821992-1-wudaemon@163.com> References: <20231220140112.821992-1-wudaemon@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3_xQR+4JlSE6KDA--.26908S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjfUn189UUUUU X-CM-SenderInfo: 5zxgtvxprqqiywtou0bp/1tbisA9MbWV4G6E+9AABsy >>I think we'd better use if (!on_rt_rq(rt_se)) >> >> + update_stats_wait_end_rt(rt_rq, rt_se); >> hi, Yafang.when execute update_stats_dequeue_rt, rt_se->on_rq is still 0, util dequeue_rt_stack, the method is not effect. I this we can use if (p && p != rq->curr) /*Mark the end of the wait period if dequeueing task*/ because schedstats is not supported for rt group,we only need to update rt_se that is realy task. -- Best regards