Received-SPF: pass (google.com: domain of linux-kernel+bounces-7067-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 20 Dec 2023 06:34:45 -0800
From: Luis Chamberlain <mcgrof@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>,
	Joel Granados <j.granados@samsung.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Iurii Zaikin <yzaikin@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 00/18] sysctl: constify sysctl ctl_tables
Message-ID: <ZYL7hS1ARS6ygPBP@bombadil.infradead.org>
References: <20231212090930.y4omk62wenxgo5by@localhost>
 <ZXligolK0ekZ+Zuf@bombadil.infradead.org>
 <20231217120201.z4gr3ksjd4ai2nlk@localhost>
 <908dc370-7cf6-4b2b-b7c9-066779bc48eb@t-8ch.de>
 <ZYC37Vco1p4vD8ji@bombadil.infradead.org>
 <a0d96e7b-544f-42d5-b8da-85bc4ca087a9@t-8ch.de>
 <ZYIGi9Gf7oVI7ksf@bombadil.infradead.org>
 <alpine.DEB.2.22.394.2312192218050.3196@hadrien>
 <ZYIwpHXkqBkMB8zl@bombadil.infradead.org>
 <alpine.DEB.2.22.394.2312200838160.3151@hadrien>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2312200838160.3151@hadrien>
Sender: Luis Chamberlain <mcgrof@infradead.org>

On Wed, Dec 20, 2023 at 08:39:20AM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 19 Dec 2023, Luis Chamberlain wrote:
> 
> > On Tue, Dec 19, 2023 at 10:21:25PM +0100, Julia Lawall wrote:
> > > > As I noted, I think this is a generically neat endeavor and so I think
> > > > it would be nice to shorthand *any* member of the struct. ctl->any.
> > > > Julia, is that possible?
> > >
> > > What do you mean by *any* member?
> >
> > I meant when any code tries to assign a new variable to any of the
> > members of the struct ctl_table *foo, so any foo->*any*
> 
> Declaring any to be an identifier metavariable would be sufficient.

Fantastic thanks!

> > > If any is an identifier typed
> > > metavariable then that would get any immediate member.  But maybe you want
> > > something like
> > >
> > > <+...ctl->any...+>
> > >
> > > that will match anything that has ctl->any as a subexpression?
> >
> > If as just an expression, then no, we really want this to be tied to
> > the data struture in question we want to modify.
> 
> What about foo->a.b?  Or maybe that doesn't occur in your structure?

We'll consider that too, good idea!

  Luis