Received-SPF: pass (google.com: domain of linux-kernel+bounces-7075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231212134844.1213381-1-lukasz.luba@arm.com> <20231212134844.1213381-6-lukasz.luba@arm.com>
In-Reply-To: <20231212134844.1213381-6-lukasz.luba@arm.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 20 Dec 2023 15:41:41 +0100
Message-ID: <CAJZ5v0hmzRbEG3V9WeJ7d2Kx1va-Fox18rKafms_wkNe36H_YQ@mail.gmail.com>
Subject: Re: [PATCH v2 5/8] thermal: gov_power_allocator: Refactor checks in divvy_up_power()
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, 
	linux-pm@vger.kernel.org, rui.zhang@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 12, 2023 at 2:48=E2=80=AFPM Lukasz Luba <lukasz.luba@arm.com> w=
rote:
>
> Simplify the code and remove one extra 'if' block.
>
> No intentional functional impact.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>  drivers/thermal/gov_power_allocator.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_=
power_allocator.c
> index 1a605fd9c8c6..574aa5822112 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -349,7 +349,8 @@ static void divvy_up_power(u32 *req_power, u32 *max_p=
ower, int num_actors,
>                            u32 total_req_power, u32 power_range,
>                            u32 *granted_power, u32 *extra_actor_power)
>  {
> -       u32 extra_power, capped_extra_power;
> +       u32 capped_extra_power =3D 0;
> +       u32 extra_power =3D 0;
>         int i;
>
>         /*
> @@ -358,8 +359,6 @@ static void divvy_up_power(u32 *req_power, u32 *max_p=
ower, int num_actors,
>         if (!total_req_power)
>                 total_req_power =3D 1;
>
> -       capped_extra_power =3D 0;
> -       extra_power =3D 0;
>         for (i =3D 0; i < num_actors; i++) {
>                 u64 req_range =3D (u64)req_power[i] * power_range;
>
> @@ -375,7 +374,7 @@ static void divvy_up_power(u32 *req_power, u32 *max_p=
ower, int num_actors,
>                 capped_extra_power +=3D extra_actor_power[i];
>         }
>
> -       if (!extra_power)
> +       if (!extra_power || !capped_extra_power)
>                 return;
>
>         /*
> @@ -383,12 +382,13 @@ static void divvy_up_power(u32 *req_power, u32 *max=
_power, int num_actors,
>          * how far they are from the max
>          */
>         extra_power =3D min(extra_power, capped_extra_power);
> -       if (capped_extra_power > 0)
> -               for (i =3D 0; i < num_actors; i++) {
> -                       u64 extra_range =3D (u64)extra_actor_power[i] * e=
xtra_power;
> -                       granted_power[i] +=3D DIV_ROUND_CLOSEST_ULL(extra=
_range,
> -                                                        capped_extra_pow=
er);
> -               }
> +
> +       for (i =3D 0; i < num_actors; i++) {
> +               u64 extra_range =3D (u64)extra_actor_power[i] * extra_pow=
er;
> +
> +               granted_power[i] +=3D DIV_ROUND_CLOSEST_ULL(extra_range,
> +                                                capped_extra_power);
> +       }
>  }
>
>  static int allocate_power(struct thermal_zone_device *tz, int control_te=
mp)
> --

Looks good to me.