Received-SPF: pass (google.com: domain of linux-kernel+bounces-7076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e9e9777d-f8c1-48cd-b433-0292c77f6d57@amd.com>
Date: Wed, 20 Dec 2023 08:45:01 -0600
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v8 2/3] dts: zynqmp: add properties for TCM in remoteproc
To: Michal Simek <michal.simek@amd.com>, andersson@kernel.org,
 mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20231215235725.1247350-1-tanmay.shah@amd.com>
 <20231215235725.1247350-3-tanmay.shah@amd.com>
 <6ab19ceb-38ed-4e4c-aabc-a959bc123cf2@amd.com>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <6ab19ceb-38ed-4e4c-aabc-a959bc123cf2@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?alRMV1dSaktGZWk2NE91NExHM3Uza1dRRnhSK0ZvOFgvZ1c3OFhPTTQ4NWRk?=
 =?utf-8?B?Q3I0TXpqMU1EOTFUc3dMcFJjYmc2aFZhVFdTRzdlbW1JRVJtRVpSRk55eDhx?=
 =?utf-8?B?OTNFaENNbExFMkRLa2IvRE1LeWR5YTdxbXFtUnRFSStySzNXNzFDcDd2VHZy?=
 =?utf-8?B?YVh0YmM0VTNmd2paeWQ1KzRxTXIzekkrMFlSZ0wvRDhuendZbTV6YXNpUWJB?=
 =?utf-8?B?MnNzR1ZMWmFHa1VmRCtNc1IweUQyb0dtNk9VbjdKdFR4NWZiUlluZkd5Mmpk?=
 =?utf-8?B?VXNZMWRMZjcxdmp4VHJtR2Z6aTdMd1JVdjlPcXFaZFlPdWlqV21ROVZhYy9v?=
 =?utf-8?B?L0tJSk81YnlMSTVuOFFhdm8xRWFHcGxMS3VRUkhHbUU0WEQrbmpvMTZ6V3l1?=
 =?utf-8?B?ZWQzOXpyU2NkTE01ZE1EcU1yMDh6a1NYbEh2VzVlR0lHQkVNZTU5MklwaEEr?=
 =?utf-8?B?Y1cwbjRvcW1BMWxNTzA5QTRXaEM3ODc2QjRaYXVsVldCcTZoZ3lMcHZNbE11?=
 =?utf-8?B?REl3dk10dFlFcjU5MGpOdTl1V0NEeVRMNVRaMHYzMHV2RVp6QVczVFpBaCtj?=
 =?utf-8?B?Smw3a25OUFR0WXRpQmFGNzA4Q2VKdFVHeW05cCszRlZUYi85WDFyVEhmM3Z3?=
 =?utf-8?B?anp3c3NFMFNKUzBncVREMzJCMXUzbXRpU0EvYklpZFBvTlNFSVZucVJiN0Vr?=
 =?utf-8?B?aHcrdVV3UHcrTUNPY3U0Rkt5TEtoVm5DRkw1VGZ1Vm53em9Kc3NLODdyZ2wy?=
 =?utf-8?B?MmtFbnMzdTlLcE50dG80YTZuSEtZcGY0c2VQMFBXcytwZEhvek1CZVB0UGJ3?=
 =?utf-8?B?Tk44WVpIcjhrZWk5em1BbW9kTld5MkxCNnh1aTlHRzl4NnRLcjZUNVM4Wlly?=
 =?utf-8?B?OUZHd01TZ0NGdkY0cldKdlZLaXM1NDgydjZ0SWRoZzhhSGNVY0xoSjZsM0c5?=
 =?utf-8?B?alVTbG0xT25YUGpnclVIdUsvN3RiL2xhVUg0RUQydDRaZndSZlRzVEFzSDJx?=
 =?utf-8?B?ZGJnV3NBdk84U0NoMVdZZHp3NWN6SmJUVWU0NHJoTDIydlJ0WmEzMVU5R3JH?=
 =?utf-8?B?QlBORUNMR1VRcC9GaThVNVkvQmpQeFUvVHZ2bFNhSmtJbTMzZU1GKy9taXIw?=
 =?utf-8?B?UlkweDBWa3N0QkxxOGRnczgwUGxHUEowQ0JaNXBLTGE4d3UyU3Q5cXQ3Znla?=
 =?utf-8?B?OFBxTERuTnZGVDM5K1YwajB4cU5RZElEMjdoMGhOWjNHa1ppSStXWkpTQ05h?=
 =?utf-8?B?MHA3UzU4TDlTYzNwYyttcjNqTGNXRVRCdzlZcmUzVUNyNHIra3cvUzFpdHEy?=
 =?utf-8?B?ODhsUWxDREJYQ25zSmU0TEY2cFAzemNqeXh5dzl2TEw4VkUyeGU1K1B2VDR3?=
 =?utf-8?B?NzRDejdlYjJoUkg1VjBuQnJBYVU3Qk1oK21hVFovdHFkQWhiYk9XVWFhNml5?=
 =?utf-8?B?Y2tHQzNNQk1JZGhOWFdSMDBDQkk0TGxLdXZoOWFEUWxoaWp4SGRZOXAxbit6?=
 =?utf-8?B?bGVPbEhBemlHRWZ0d1drWk4vZzAyTmNkcHVvZ2o0SmdkSEpESktsM0Z2RXlQ?=
 =?utf-8?B?aVAzMHI2R2JDcEdTZi9NRmdpa0FBMXdxV21qNlFaNGRRcExrL0xqMmJ4ZHA5?=
 =?utf-8?B?ZmxrWjg1bmcvZVZDOS9tZkFDTnE5RXZ6d21CbHJYcm5JODJaRU9jZ3UwQUxB?=
 =?utf-8?B?cGFIb3EvK1ViOGhsbDVmUG90UXU3S1gvVEFOZmFZOTBIL3lDeVJyVmxDUmxz?=
 =?utf-8?B?Q3diekhMUGVLak9NdWFTM0pWc3dTV1h0V1RXR0Y1OE9pTDNSTy96K3lPNFQ3?=
 =?utf-8?B?Mnp2Q0pRbDFBYVV6eTBkWldDK3NYTURyOFQ5UFpUSzIzbG9HOWZ6dWVkQzZZ?=
 =?utf-8?B?ZzUyZnk5U2VzTy9RdVdnd21FK20za1lQWkloeG9ueFhGczNjZThPUWt3OTNt?=
 =?utf-8?B?d1dzTHlQWGd6bGU2dUJuK1JQS21lVmdONkRPUEVkLzcrNWRWYUFaRkpYN2Q1?=
 =?utf-8?B?Yy9rYUlBeDdraVI5N3ZVUE5GcmRFMXZnalRvVkdOUDFOdnNCR2dmTE9LTzNx?=
 =?utf-8?B?YzZwenQ4UmtDK0FGSXFPVVp5M1lsU3hqdHNySXVpbnAvdnRuL0dlb0VwK1Ba?=
 =?utf-8?Q?jbgAvqeEINNhuAbjmGD5iB5p6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d19e6217-d755-449b-ee23-08dc016a40c2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3683.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 14:45:04.6631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K31QPcrOQc0C2caPZ6tzqETCOtmCUH2B73PsCEjZJ3oEaBfgkU3pFd5o46wpHsFe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9194


On 12/20/23 7:14 AM, Michal Simek wrote:
>
> On 12/16/23 00:57, Tanmay Shah wrote:
> > Add properties as per new bindings in zynqmp remoteproc node
> > to represent TCM address and size.
> > 
> > This patch also adds alternative remoteproc node to represent
> > remoteproc cluster in split mode. By default lockstep mode is
> > enabled and users should disable it before using split mode
> > dts. Both device-tree nodes can't be used simultaneously one
> > of them must be disabled. For zcu102-1.0 and zcu102-1.1 board
> > remoteproc split mode dts node is enabled and lockstep mode
> > dts is disabled.
> > 
> > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> > ---
> >   .../boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts  |  8 +++
> >   arch/arm64/boot/dts/xilinx/zynqmp.dtsi        | 60 +++++++++++++++++--
> >   2 files changed, 63 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts
> > index c8f71a1aec89..495ca94b45db 100644
> > --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts
> > +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts
> > @@ -14,6 +14,14 @@ / {
> >   	compatible = "xlnx,zynqmp-zcu102-rev1.0", "xlnx,zynqmp-zcu102", "xlnx,zynqmp";
> >   };
> >   
> > +&rproc_split {
> > +	status = "okay";
> > +};
> > +
> > +&rproc_lockstep {
> > +	status = "disabled";
> > +};
> > +
> >   &eeprom {
> >   	#address-cells = <1>;
> >   	#size-cells = <1>;
> > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > index b61fc99cd911..602e6aba7ac5 100644
> > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> > @@ -247,19 +247,69 @@ fpga_full: fpga-full {
> >   		ranges;
> >   	};
> >   
> > -	remoteproc {
> > +	rproc_lockstep: remoteproc@ffe00000 {
> >   		compatible = "xlnx,zynqmp-r5fss";
> >   		xlnx,cluster-mode = <1>;
> >   
> > -		r5f-0 {
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +
> > +		ranges = <0x0 0x0 0x0 0xffe00000 0x0 0x20000>,
> > +			 <0x0 0x20000 0x0 0xffe20000 0x0 0x20000>,
> > +			 <0x1 0x0 0x0 0xffe90000 0x0 0x10000>,
> > +			 <0x1 0x20000 0x0 0xffeb0000 0x0 0x10000>;
> > +
> > +		r5f@0 {
> > +			compatible = "xlnx,zynqmp-r5f";
> > +			reg = <0x0 0x0 0x0 0x20000>, <0x0 0x20000 0x0 0x20000>;
> > +			reg-names = "atcm", "btcm";
> > +			power-domains = <&zynqmp_firmware PD_RPU_0>,
> > +					<&zynqmp_firmware PD_R5_0_ATCM>,
> > +					<&zynqmp_firmware PD_R5_0_BTCM>;
> > +			memory-region = <&rproc_0_fw_image>;
> > +		};
> > +
> > +		r5f@1 {
> > +			compatible = "xlnx,zynqmp-r5f";
> > +			reg = <0x1 0x0 0x0 0x10000>, <0x1 0x20000 0x0 0x10000>;
> > +			reg-names = "atcm", "btcm";
> > +			power-domains = <&zynqmp_firmware PD_RPU_1>,
> > +					<&zynqmp_firmware PD_R5_1_ATCM>,
> > +					<&zynqmp_firmware PD_R5_1_BTCM>;
> > +			memory-region = <&rproc_1_fw_image>;
> > +		};
> > +	};
> > +
> > +	rproc_split: remoteproc-split@ffe00000 {
> > +		status = "disabled";
> > +		compatible = "xlnx,zynqmp-r5fss";
> > +		xlnx,cluster-mode = <0>;
> > +
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +
> > +		ranges = <0x0 0x0 0x0 0xffe00000 0x0 0x10000>,
> > +			 <0x0 0x20000 0x0 0xffe20000 0x0 0x10000>,
> > +			 <0x1 0x0 0x0 0xffe90000 0x0 0x10000>,
> > +			 <0x1 0x20000 0x0 0xffeb0000 0x0 0x10000>;
> > +
> > +		r5f@0 {
> >   			compatible = "xlnx,zynqmp-r5f";
> > -			power-domains = <&zynqmp_firmware PD_RPU_0>;
> > +			reg = <0x0 0x0 0x0 0x10000>, <0x0 0x20000 0x0 0x10000>;
> > +			reg-names = "atcm", "btcm";
> > +			power-domains = <&zynqmp_firmware PD_RPU_0>,
> > +					<&zynqmp_firmware PD_R5_0_ATCM>,
> > +					<&zynqmp_firmware PD_R5_0_BTCM>;
> >   			memory-region = <&rproc_0_fw_image>;
> >   		};
> >   
> > -		r5f-1 {
> > +		r5f@1 {
> >   			compatible = "xlnx,zynqmp-r5f";
> > -			power-domains = <&zynqmp_firmware PD_RPU_1>;
> > +			reg = <0x1 0x0 0x0 0x10000>, <0x1 0x20000 0x0 0x10000>;
> > +			reg-names = "atcm", "btcm";
> > +			power-domains = <&zynqmp_firmware PD_RPU_1>,
> > +					<&zynqmp_firmware PD_R5_1_ATCM>,
> > +					<&zynqmp_firmware PD_R5_1_BTCM>;
> >   			memory-region = <&rproc_1_fw_image>;
> >   		};
> >   	};
>
> Acked-by: Michal Simek <michal.simek@amd.com>
>
> Let me know if you want me to take this via my tree.

Hi Michal,

Thanks for reviews. I will ping you once driver changes are approved.

Or Mathieu can take this in remoteproc tree, either way is fine.

But I would like to wait till driver changes are approved.

Tanmay

>
> Thanks,
> Michal