Received-SPF: pass (google.com: domain of linux-kernel+bounces-7094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231212134844.1213381-1-lukasz.luba@arm.com> <20231212134844.1213381-8-lukasz.luba@arm.com>
In-Reply-To: <20231212134844.1213381-8-lukasz.luba@arm.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 20 Dec 2023 15:57:06 +0100
Message-ID: <CAJZ5v0h=1yXYzS0LH6dVT1YCMqJ_rYeBJXCmkRsgZEyDK8QCpA@mail.gmail.com>
Subject: Re: [PATCH v2 7/8] thermal/sysfs: Update governors when the 'weight'
 has changed
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, 
	linux-pm@vger.kernel.org, rui.zhang@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 12, 2023 at 2:48=E2=80=AFPM Lukasz Luba <lukasz.luba@arm.com> w=
rote:
>
> Support governors update when the thermal instance's weight has changed.
> This allows to adjust internal state for the governor.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>  drivers/thermal/thermal_sysfs.c | 9 +++++++++
>  include/linux/thermal.h         | 1 +
>  2 files changed, 10 insertions(+)
>
> diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sy=
sfs.c
> index df85df7d4a88..9afa2e2b76b9 100644
> --- a/drivers/thermal/thermal_sysfs.c
> +++ b/drivers/thermal/thermal_sysfs.c
> @@ -957,6 +957,14 @@ weight_show(struct device *dev, struct device_attrib=
ute *attr, char *buf)
>         return sprintf(buf, "%d\n", instance->weight);
>  }
>
> +static void handle_weight_update(struct thermal_zone_device *tz)
> +{
> +       if (!tz->governor || !tz->governor->update_tz)
> +               return;
> +
> +       tz->governor->update_tz(tz, THERMAL_INSTANCE_WEIGHT_UPDATE);
> +}

So if you follow my advice from the comment on the first patch, you'll
be able to use the helper as is without introducing a new one.

> +
>  ssize_t weight_store(struct device *dev, struct device_attribute *attr,
>                      const char *buf, size_t count)
>  {
> @@ -974,6 +982,7 @@ ssize_t weight_store(struct device *dev, struct devic=
e_attribute *attr,
>         /* Don't race with governors using the 'weight' value */
>         mutex_lock(&tz->lock);
>         instance->weight =3D weight;
> +       handle_weight_update(tz);

So this will become

thermal_governor_update_tz(tz, THERMAL_INSTANCE_WEIGHT_UPDATE);

>         mutex_unlock(&tz->lock);
>
>         return count;
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 9fd0d3fb234a..24176f075fbf 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -52,6 +52,7 @@ enum thermal_notify_event {
>         THERMAL_TABLE_CHANGED, /* Thermal table(s) changed */
>         THERMAL_EVENT_KEEP_ALIVE, /* Request for user space handler to re=
spond */
>         THERMAL_INSTANCE_LIST_UPDATE, /* List of thermal instances change=
d */
> +       THERMAL_INSTANCE_WEIGHT_UPDATE, /* Thermal instance weight change=
d */

And I'd slightly prefer THERMAL_INSTANCE_WEIGHT_CHANGE.

>  };
>
>  /**
> --