Received-SPF: pass (google.com: domain of linux-kernel+bounces-7117-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d8e455b9-0a27-4361-8f92-9f1cb1fff537@gmx.de>
Date: Wed, 20 Dec 2023 16:09:51 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] hwmon: (acpi_power_meter) Install IPMI handler for Dell
 systems
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, jdelvare@suse.com,
 linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231220051350.392350-1-kai.heng.feng@canonical.com>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20231220051350.392350-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:tKS1Lk1+9CI=;yjbvVaAnZS2MS8n59Q+kv8j0bjP
 c5UlZlTALQTLNlrooBrnnmBWSjEslLxGyqRici9Bu5rDAzVWI+kskOlGz0T1DLM5oajNJuYgL
 vk9Vy4xry7Ig6ywzVT+jcU5/SNK9GN3VbcpEYIV78P/T5FKOlbmhUi9UblOhWAxsMSf1+JTOz
 0SdC9o3reqpfSRDgTVB0peMbWDpiEyc0f8fzoMTGtNBIkQNXJxszO1Q9oYGs8h/WEV42XnqBc
 edszaYTX/JsrOGH98wk+Vib3STf1N5mpv2ZAlYZfENcBg0Zu8X6JTDdRgey8sn07LXm+zNN4r
 dwPFZigXVYJWRamwrfSU2h9D6YERwh06Q1ugYawZ+lk4bnerHkYzUQcEmBEvu1AAH7eXbbIFe
 jAMgJG2o/kDjxN0rw9dEgX/ggjYcICG9BKJjiJALQRsuUxXU0uMgWozIS/vUcUab7a9qoqLia
 32w8r6QaQgKZYWe8XaahFrfLpHXUDKUipAomS5Q65O4w6vFNIni0Uu9/Ff1Pf7riQCdU0oTrO
 G8Nw61LTuHBHi+WgH+orz9vD+CmfsNzhxelLnvPazZmPKuJhcVxz6rzdsb5YslF6BN0mas7CU
 2w/LrRiON1L22AR7cFXZAMALojK+W1aAoj8zi7CTEYDk2zQoNsKHOSit2B/IhJV21afCcnDdR
 VNQxnE4E2lKL91H+N6ZKi5/AQDs0CSMDzIhB9xI4YYq2lz8SoEUEtHSTNugJJJyXlPM8rgu55
 QK0mah29bJ5rwglUkrP1b3na9seQ2izJu0k4W5TmWfA8EZ+m34N82tGontGyAs1fcUw3P9YDp
 Cttz7RQVXUV/obzgK68h69YqXruPFQC04mQfSgeI2ZtKLtkJZA6DVCexeI2HyOUjYCWrFQ4CF
 Jl3bqAzZnNEaKxoFhZehdoYh3rvYg3aWjj3nT4ixG0ETYy1CTw1nDydUlMTKGhxP6Q8xfiS+L
 2DVbkQSp6SfSLusb2XfMxh+x0RM=

Am 20.12.23 um 06:13 schrieb Kai-Heng Feng:

> The following error can be observed at boot:
> [    3.717920] ACPI Error: No handler for Region [SYSI] (00000000ab9e62c=
5) [IPMI] (20230628/evregion-130)
> [    3.717928] ACPI Error: Region IPMI (ID=3D7) has no handler (20230628=
/exfldio-261)
>
> [    3.717936] No Local Variables are initialized for Method [_GHL]
>
> [    3.717938] No Arguments are initialized for method [_GHL]
>
> [    3.717940] ACPI Error: Aborting method \_SB.PMI0._GHL due to previou=
s error (AE_NOT_EXIST) (20230628/psparse-529)
> [    3.717949] ACPI Error: Aborting method \_SB.PMI0._PMC due to previou=
s error (AE_NOT_EXIST) (20230628/psparse-529)
> [    3.717957] ACPI: \_SB_.PMI0: _PMC evaluation failed: AE_NOT_EXIST
>
> On Dell systems several methods of acpi_power_meter access variables in
> IPMI region [0], so request module 'ipmi_si' which will load 'acpi_ipmi'
> and install the region handler accordingly.

Hi,

this driver should be loaded automatically if an ACPI IPMI device is prese=
nt.
Can you share the output of "acpidump"?

Armin Wolf

> [0] https://www.dell.com/support/manuals/en-us/redhat-enterprise-linux-v=
8.0/rhel8_rn_pub/advanced-configuration-and-power-interface-acpi-error-mes=
sages-displayed-in-dmesg?guid=3Dguid-0d5ae482-1977-42cf-b417-3ed5c3f5ee62
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>   drivers/hwmon/acpi_power_meter.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power=
_meter.c
> index 703666b95bf4..b9db53166bc9 100644
> --- a/drivers/hwmon/acpi_power_meter.c
> +++ b/drivers/hwmon/acpi_power_meter.c
> @@ -882,6 +882,8 @@ static int acpi_power_meter_add(struct acpi_device *=
device)
>   	strcpy(acpi_device_name(device), ACPI_POWER_METER_DEVICE_NAME);
>   	strcpy(acpi_device_class(device), ACPI_POWER_METER_CLASS);
>   	device->driver_data =3D resource;
> +	if (dmi_match(DMI_SYS_VENDOR, "Dell Inc."))
> +		request_module("ipmi_si");
>
>   	res =3D read_capabilities(resource);
>   	if (res)