Received-SPF: pass (google.com: domain of linux-kernel+bounces-7145-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231220140112.821992-1-wudaemon@163.com> <20231220143249.833273-1-wudaemon@163.com>
In-Reply-To: <20231220143249.833273-1-wudaemon@163.com>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Wed, 20 Dec 2023 23:18:01 +0800
Message-ID: <CALOAHbAXdRbX9Wbn8qpH5eFUKcju4Ahb+VjMx=JjJL=cVox5tg@mail.gmail.com>
Subject: Re: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error
 in sched_stat_wait trace_point
To: Junwen Wu <wudaemon@163.com>
Cc: bristot@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com, 
	juri.lelli@redhat.com, linux-kernel@vger.kernel.org, mgorman@suse.de, 
	mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, 
	vincent.guittot@linaro.org, vschneid@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 10:33=E2=80=AFPM Junwen Wu <wudaemon@163.com> wrote=
:
>
> >>I think we'd better use if (!on_rt_rq(rt_se))
> >>
> >> +               update_stats_wait_end_rt(rt_rq, rt_se);
> >>
> hi, Yafang.when execute update_stats_dequeue_rt, rt_se->on_rq is still 0,=
 util dequeue_rt_stack,
> the method is not effect.

Ah, you are right.

> I this we can use if (p && p !=3D rq->curr) /*Mark the end of the wait pe=
riod if dequeueing task*/

Agreed.

> because schedstats is not supported for rt group,we only need to update r=
t_se that is realy task.
> --
> Best regards
>


--=20
Regards
Yafang