Received: by 2002:a05:7412:d024:b0:f9:90c9:de9f with SMTP id bd36csp105656rdb; Wed, 20 Dec 2023 07:25:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/wuf7ayv5SNRRN3kVdEH5PrDMO/y0fGiUczRLwAeiRJosD6B/2/loZ8gTfSXN9Hkcr/+O X-Received: by 2002:a2e:9e41:0:b0:2cc:9768:efd1 with SMTP id g1-20020a2e9e41000000b002cc9768efd1mr186299ljk.10.1703085923148; Wed, 20 Dec 2023 07:25:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703085923; cv=none; d=google.com; s=arc-20160816; b=rYnFZQrbJVmR7XlVE2KDjtSNPAtURLn6H0Kr47KeszXgJRPQeRe/r5eme7vYZCMu8+ kuT4rCt5Iv5DpkzHcVTTOknNPm64OqyGdpyOTNjsLwCojEC5KraiDPV7Dw34k96nYA2r Hu0z/iOhtwpr/FoRothK0qQbtda8IS+OGwiCpwf2K9s3asWvV3ltONdu6pCmfrSrdSWe SJb0RHnO5CSquBA0Z/pW+1DXwq8N0nOjuP/n7Y5R0ViGfku3cPWpN+YKdjtEO5iKD0O+ acxFpwF0MSlZs4l/xRuRbru5dQlNKfQezXTZqkdzrWEGQQYRAtWXYIBpvGYOgcA7eWVp fKBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XsA5doFtYguYAcqHD/lZo7afISfl4+rlm8W8kD/h3S8=; fh=d/E2z1QQElzRMHsxE/EJDS8jKHpOB/nyYxWejrJGOIw=; b=SmxGVSuHPG9ohmYBDJfxsldZaRWH5BAj3xu4Kp7wwxCOcRSfqdkBTOsR5L1uFqKcsn 123Lsrd0yMyRBkCdOyqZF2Thu6F/xLR/gTstIPfHheAVDNCLEhMdKAAPVTUt3xpCVbOL 1e03LLP7tImNfpUv4uSHxxOprIktwoUe+inr2HM41bz/gcQTORa7YWPNWOIDIm1nhb6u Q0Ib4k1aZluhIVOdwSZZ7jn15EQSaBCpcmXZr01FUFW6iZNOHWvdlGa40Qno+zD1m3WH /dVJJwtOACuPY+QV+lymIQcDF2+4WIkM1B57sQCQBH4/OZxUEly90KAfSKrZfJfTGIvy rAAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FPUCjTa2; spf=pass (google.com: domain of linux-kernel+bounces-7148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7148-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i28-20020a50871c000000b005539e083f7csi1441257edb.535.2023.12.20.07.25.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 07:25:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FPUCjTa2; spf=pass (google.com: domain of linux-kernel+bounces-7148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7148-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DF9011F25204 for ; Wed, 20 Dec 2023 15:25:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DF1D647790; Wed, 20 Dec 2023 15:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FPUCjTa2" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CFC54778D; Wed, 20 Dec 2023 15:22:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34BEAC433C8; Wed, 20 Dec 2023 15:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703085731; bh=/VBEJow9gZvDr3dfVllZGJwgfM/5tIcquyK819mX7Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FPUCjTa2by5PlCM/epGHDql/dkP1aSRo7SsmjSgHp7GxMPmhqbjFPV9zEptgfMbQO dx8Xg/s1rJCz2HqfzQe7eOyL6jTqv2mghxi0SFz7w5MI+3WDqPmasE+N2nHoiYygNw +ILdlv/Kz7/A6cXBRXOw0cKqom6EsXzDxns3c5KRncm4xfBUcNdTWjLHSx2xJ4Goda nIK/AikrMbJwkhK+wz6yKU/oVfEP7aGDfo1rBCY/zQTgKdY9LlnhU5QniA6sUSjEuW qP0+sm7GvrbZzn1OGxPN2/kfS25No7hemBDnUnR+VaycRl9rtUoApcIAs0UJNLD1wG dBfVyCwZDBskQ== Received: (nullmailer pid 242348 invoked by uid 1000); Wed, 20 Dec 2023 15:22:09 -0000 Date: Wed, 20 Dec 2023 09:22:09 -0600 From: Rob Herring To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Tobias Waldekranz Subject: Re: [net-next PATCH v4 1/4] dt-bindings: net: phy: Document new LEDs polarity property Message-ID: <20231220152209.GA229412-robh@kernel.org> References: <20231215212244.1658-1-ansuelsmth@gmail.com> <20231215212244.1658-2-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215212244.1658-2-ansuelsmth@gmail.com> On Fri, Dec 15, 2023 at 10:22:41PM +0100, Christian Marangi wrote: > Document new LEDs polarity property to define what mode the LED needs to > be put to turn it on. > > Currently supported modes are: > > - active-low > - active-high > - active-low-tristate > - active-high-tristate Why is having a polarity unique to LEDs on ethernet PHYs? It's not. We already have 'active-low' established on several LED bindings. Please move the definition to leds/common.yaml and extend it. I would simply add an 'inactive-tristate' boolean property (if there's an actual user). I do worry this continues to evolve until we've re-created the pinctrl binding... Rob