Received: by 2002:a05:7412:d024:b0:f9:90c9:de9f with SMTP id bd36csp123990rdb; Wed, 20 Dec 2023 07:53:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBMn/acOXi113+Dwnz0TypAHzShOLE6g4rd/I8Qm0zD734i0jTE2ZHAmQ1SBDc0ahA2FNw X-Received: by 2002:a05:622a:2cb:b0:427:8e97:1054 with SMTP id a11-20020a05622a02cb00b004278e971054mr1072779qtx.50.1703087632412; Wed, 20 Dec 2023 07:53:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703087632; cv=none; d=google.com; s=arc-20160816; b=dbg05HCvx6ndwNbNTkH8OodroVwqYv1hXTRoX927YkwFFVvq/nPsau1C3ctaSOuwJS 3L1zttrY+nbt5TTu+UA6MD2weakzIjmq0a+jGgVb+0jCO2fhZ+wRwNyRny5xXVMQJ9x2 QgUkt9SZ8cmGMIWO72zG1VZBU3nJDyY3uLATOWRawnOhDs2AoCfNfcaSresYDH+NwU/M qm8jxwjMKk4nIjYoCzhB6I3FOS9PLJeluDRDgI7ObXN/GYROoAPOPIxj1MhBsJNbGF1q GBRY7i2E3QYxF5YMkp4cDwGs11rWRr+jwa4/B8jwNvLcgQ8clzThMWbi1ciB77MWOZkk qJlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=2c6yBcE2Z5vKFBCFCDN5x1IaIatSlRiqPl8BvJv1ogw=; fh=84x5k+UxKWtn9utONVmTCwEaeXEDBZb5aQPEIueE9UU=; b=pobet4iQ1WAgonNCR6R8RmPdR+mKfsaPwfbQuMnhd00e7tuQgbTRiUArbaSaFANTEO mD5wsKMWiNnHnClBnDYmYzNEIVX+IynrP/kwmmFySVu0iODscH2xR6ds/ewGg3pypluQ p7rQz7irGJUtXs8+1mm75xaLIXp57+K46lDFD3n43rjP76doZci9OjixPCD0bJr8aXGT Y+9Tn4SUtNJKC2qSVyzFKJ4fOrRGlr6/6Bhq3jVSHzUhQuY3rSpfJeobKSxgJ1HmlW3I kvN3zWpuLeGtOLGM+mUUMDnetVwnuQyaaEkppQF77zcwf7s5OLiJ7bJtw89ncbDBoenp qtiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-7205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h14-20020ac8584e000000b00423d65e0344si29216762qth.359.2023.12.20.07.53.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 07:53:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-7205-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7205-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 300121C244D8 for ; Wed, 20 Dec 2023 15:53:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 30CBF4175B; Wed, 20 Dec 2023 15:52:57 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8351C4184F; Wed, 20 Dec 2023 15:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="462283009" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="462283009" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 07:52:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="805306455" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="805306455" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 07:52:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rFysL-00000007apN-0A7P; Wed, 20 Dec 2023 17:52:49 +0200 Date: Wed, 20 Dec 2023 17:52:48 +0200 From: Andy Shevchenko To: Hugo Villeneuve Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, jringle@gridpoint.com, kubakici@wp.pl, phil@raspberrypi.org, bo.svangard@embeddedart.se, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Hugo Villeneuve Subject: Re: [PATCH 12/18] serial: sc16is7xx: replace hardcoded divisor value with BIT() macro Message-ID: References: <20231219171903.3530985-1-hugo@hugovil.com> <20231219171903.3530985-13-hugo@hugovil.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231219171903.3530985-13-hugo@hugovil.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Dec 19, 2023 at 12:18:56PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > To better show why the limit is what it is, since we have only 16 bits for > the divisor. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko