Received: by 2002:a05:7412:d024:b0:f9:90c9:de9f with SMTP id bd36csp132485rdb; Wed, 20 Dec 2023 08:05:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGequutq3R+eESWjWPRQO0LpHHeEmFACH0zGSLyX7XUgiiL+qRNFKnsyUINCHpnn0YpK0E9 X-Received: by 2002:a05:6358:91a1:b0:172:a50f:a215 with SMTP id j33-20020a05635891a100b00172a50fa215mr13592042rwa.25.1703088313308; Wed, 20 Dec 2023 08:05:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703088313; cv=none; d=google.com; s=arc-20160816; b=Fx90AwN8SD9jJ4VuGE5sFr+M5xEWrSfqzc5oXxl3rLpomFOCGd2d4SUeQJ1okH06ue NHj++pEzShJeOyx8QCLxwYV3mpoAx58uuB5EYb5u31L0AE/dod5LaF8ZuFkcUMV/6VLf tKxr+lMJYNUVWvMBdyDM+Fb1FlZnH6LyZg1LcHKrx7qjH5F1ARIZatLd454m7Hb9v8T5 XsyEQH9lgmBqPYQy23KEMbUlAblmlieqjiW267g2rkm7LLAx8/QPw+acQTvq/k8gCpaA fcDcBL0MuPgVHCFWmUWsPQxSCmWDievdthyPFIWOtd5xi1N09oelXEUOD2l2UjZfajkS ASIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=6UBkA/ezD6R8+4tp8W5kHmiXlx8K7IntkqN6qkzYD2s=; fh=H7rhZUnZ+NlyyU7vxDXWwpu6VPK6D0cjPor36M8Xy6o=; b=PQSRCbz+nwUYCv6D4Ti6+gMxM3Y5towWKdVJWe48eIKsQ1zVEK5lnNPl1EiFxmVexz cIJygGrbiZ4BfwNSWQX3mvVb/IIZafcHVqWP2Vuq4bOvx4DfxwzXkI6ErOtofp5XlaI9 WdQK/Ty+dyLzguDdcNHR7esHNMONKoUFtGKQffNGYXp1nHl5v2NR32UUo8b0K7dN1tNm LkMvrvlNC/xZV3jTktmAnPz1AvTzmYQ71wynboQTeUhOHZ4KJlFQe6jkiyg//VydHm1B COS6j9xJDqZFdqFgh6rehINgM8zU7R3YYhZiBp0bRJCNdVo2Z6niLao8lCx/AtSRetvx IWbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-7241-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7241-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e4-20020a63e004000000b005b902b61cbcsi977242pgh.723.2023.12.20.08.05.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 08:05:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7241-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-7241-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7241-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DD3B9280E26 for ; Wed, 20 Dec 2023 16:05:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C2F747765; Wed, 20 Dec 2023 16:01:58 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ECF045C09; Wed, 20 Dec 2023 16:01:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A679C433D9; Wed, 20 Dec 2023 16:01:56 +0000 (UTC) Date: Wed, 20 Dec 2023 11:02:57 -0500 From: Steven Rostedt To: Vincent Donnefort Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v8 0/2] Introducing trace buffer mapping by user-space Message-ID: <20231220110257.2b338dce@gandalf.local.home> In-Reply-To: References: <20231219184556.1552951-1-vdonnefort@google.com> <20231219153924.2ff9c132@gandalf.local.home> <20231220082932.1b391355@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 20 Dec 2023 13:49:30 +0000 Vincent Donnefort wrote: > I meant, to only do in rb_wake_up_waiters() > > if (rbwork->is_cpu_buffer) > rb_update_meta_page(cpu_buffer) > > And skip the meta-page update for the !is_cpu_buffer case? Ah yeah, that works. -- Steve