Received-SPF: pass (google.com: domain of linux-kernel+bounces-7287-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 20 Dec 2023 17:22:06 +0100
From: Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jean Delvare <jdelvare@suse.com>, Andi Shyti <andi.shyti@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: i801: Add 0x29 as =?utf-8?B?ScKy?=
 =?utf-8?Q?C?= address for lis3lv02d in Dell XPS 15 7590
Message-ID: <20231220162206.h6rlpvusgnoe7exq@pali>
References: <20231220161003.68310-1-pmenzel@molgen.mpg.de>
 <20231220161003.68310-2-pmenzel@molgen.mpg.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231220161003.68310-2-pmenzel@molgen.mpg.de>
User-Agent: NeoMutt/20180716

On Wednesday 20 December 2023 17:10:02 Paul Menzel wrote:
> On the Dell XPS 15 7590/0VYV0G, BIOS 1.24.0 09/11/2023, Linux prints the
> warning below.
> 
>     i801_smbus 0000:00:1f.4: Accelerometer lis3lv02d is present on SMBus but its address is unknown, skipping registration
> 
> Following the same suggestions by Wolfram Sang as for the Dell Precision
> 3540 [1], the accelerometer can be successfully found on I²C bus 2 at
> address 0x29.
> 
>     $ echo lis3lv02d 0x29 | sudo tee /sys/bus/i2c/devices/i2c-2/new_device
>     lis3lv02d 0x29
>     $ dmesg | tail -5
>     [  549.522876] lis3lv02d_i2c 2-0029: supply Vdd not found, using dummy regulator
>     [  549.522904] lis3lv02d_i2c 2-0029: supply Vdd_IO not found, using dummy regulator
>     [  549.542486] lis3lv02d: 8 bits 3DC sensor found
>     [  549.630022] input: ST LIS3LV02DL Accelerometer as /devices/platform/lis3lv02d/input/input35
>     [  549.630586] i2c i2c-2: new_device: Instantiated device lis3lv02d at 0x29
> 
> So, the device has that accelerometer. Add the I²C address to the
> mapping list, and test it successfully on the device.
> 
> [1]: https://lore.kernel.org/linux-i2c/97708c11-ac85-fb62-2c8e-d37739ca826f@molgen.mpg.de/
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

If the accelerometer is working fine then I have no objections.

Acked-by: Pali Rohár <pali@kernel.org>

> ---
>  drivers/i2c/busses/i2c-i801.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index cb9660f84117..3932e8d96a17 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1233,6 +1233,7 @@ static const struct {
>  	{ "Precision 3540",     0x29 },
>  	{ "Vostro V131",        0x1d },
>  	{ "Vostro 5568",        0x29 },
> +	{ "XPS 15 7590",        0x29 },
>  };
>  
>  static void register_dell_lis3lv02d_i2c_device(struct i801_priv *priv)
> -- 
> 2.43.0
>