Received-SPF: pass (google.com: domain of linux-kernel+bounces-7356-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 20 Dec 2023 17:37:10 +0000
From: Al Viro <viro@zeniv.linux.org.uk>
To: Baoquan He <bhe@redhat.com>
Cc: kernel test robot <lkp@intel.com>, oe-kbuild-all@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: arch/sh/kernel/relocate_kernel.S:38: Error: invalid operands for
 opcode
Message-ID: <20231220173710.GX1674809@ZenIV>
References: <202312182200.Ka7MzifQ-lkp@intel.com>
 <ZYJ/M1HZ9ITfs4qe@MiWiFi-R3L-srv>
 <20231220060030.GV1674809@ZenIV>
 <ZYLrxFyei79R5D8N@MiWiFi-R3L-srv>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZYLrxFyei79R5D8N@MiWiFi-R3L-srv>
Sender: Al Viro <viro@ftp.linux.org.uk>

On Wed, Dec 20, 2023 at 09:27:32PM +0800, Baoquan He wrote:
> Since the kexec_core code building depends on CONFIG_MMU=y, we may
> need to add dependency on MMU for ARCH_SUPPORTS_CRASH_DUMP. I made below
> change, do you think it's OK?
> 
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 7500521b2b98..fe1500871648 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -548,6 +548,7 @@ config ARCH_SUPPORTS_KEXEC
>  
>  config ARCH_SUPPORTS_CRASH_DUMP
>         def_bool BROKEN_ON_SMP
> +       depends on MMU
>  
>  config ARCH_SUPPORTS_KEXEC_JUMP
>         def_bool y
> 

I'm *not* familiar with crashdump or kexec machinery, let alone the
current changes in there, so take the following with a cartload of
salt, but...  does sh crash dump support depend upon the code in
question?  From quick grep it looks like we only want it in machine_kexec(),
so the conditionals used in the commit in question might be wrong...