Received-SPF: pass (google.com: domain of linux-kernel+bounces-7367-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231220012123.2787-1-cuibixuan@vivo.com> <20231220012123.2787-3-cuibixuan@vivo.com>
In-Reply-To: <20231220012123.2787-3-cuibixuan@vivo.com>
From: Yu Zhao <yuzhao@google.com>
Date: Wed, 20 Dec 2023 10:54:37 -0700
Message-ID: <CAOUHufZjxjra9Cfw8YC2eA-xsikPw=K5=1ew55hKTdYhMwjUig@mail.gmail.com>
Subject: Re: [PATCH -next v4 2/2] mm: vmscan: add new event to trace shrink lru
To: Bixuan Cui <cuibixuan@vivo.com>
Cc: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, 
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org, 
	linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, 
	opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 19, 2023 at 6:22=E2=80=AFPM Bixuan Cui <cuibixuan@vivo.com> wro=
te:
>
> From: cuibixuan <cuibixuan@vivo.com>
>
> Add a new event to calculate the shrink_inactive_list()/shrink_active_lis=
t()
> execution time.
>
> Example of output:
>          kswapd0-103     [007] .....  1098.353020: mm_vmscan_lru_shrink_a=
ctive_start: nid=3D0
>          kswapd0-103     [007] .....  1098.353040: mm_vmscan_lru_shrink_a=
ctive_end: nid=3D0 nr_taken=3D32 nr_active=3D0 nr_deactivated=3D32 nr_refer=
enced=3D0 priority=3D6 flags=3DRECLAIM_WB_FILE|RECLAIM_WB_ASYNC
>          kswapd0-103     [007] .....  1098.353040: mm_vmscan_lru_shrink_i=
nactive_start: nid=3D0
>          kswapd0-103     [007] .....  1098.353094: mm_vmscan_lru_shrink_i=
nactive_end: nid=3D0 nr_scanned=3D32 nr_reclaimed=3D0 nr_dirty=3D0 nr_write=
back=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activate=
_file=3D0 nr_ref_keep=3D32 nr_unmap_fail=3D0 priority=3D6 flags=3DRECLAIM_W=
B_ANON|RECLAIM_WB_ASYNC
>          kswapd0-103     [007] .....  1098.353094: mm_vmscan_lru_shrink_i=
nactive_start: nid=3D0
>          kswapd0-103     [007] .....  1098.353162: mm_vmscan_lru_shrink_i=
nactive_end: nid=3D0 nr_scanned=3D32 nr_reclaimed=3D21 nr_dirty=3D0 nr_writ=
eback=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activat=
e_file=3D0 nr_ref_keep=3D11 nr_unmap_fail=3D0 priority=3D6 flags=3DRECLAIM_=
WB_FILE|RECLAIM_WB_ASYNC
>
> Signed-off-by: Bixuan Cui <cuibixuan@vivo.com>
> Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> v4: Add Reviewed-by and Changlog to every patch.

Where did Andrew provide his Reviewed-by?

> v2: Modify trace_mm_vmscan_lru_shrink_inactive() in evict_folios() at the=
 same time to fix build error.

The reason v3 was NAK'ed was not mentioned or fixed in v4.

So NAK again.