Received-SPF: pass (google.com: domain of linux-kernel+bounces-7382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <bce801b2-b2a1-8014-a84d-87a18460cd1b@amd.com>
Date: Wed, 20 Dec 2023 10:50:48 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v5 0/8] Miscellaneous xdma driver enhancements
Content-Language: en-US
To: Jan Kuliga <jankul@alatek.krakow.pl>, <brian.xu@amd.com>,
	<raj.kumar.rampelli@amd.com>, <vkoul@kernel.org>, <michal.simek@amd.com>,
	<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<miquel.raynal@bootlin.com>
References: <20231218113904.9071-1-jankul@alatek.krakow.pl>
From: Lizhi Hou <lizhi.hou@amd.com>
In-Reply-To: <20231218113904.9071-1-jankul@alatek.krakow.pl>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 18:50:54.9909
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a554635b-cfe2-414e-26ec-08dc018c98db
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource:
	CO1PEPF000044FD.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5945

Verified this patch series with our device (sg interface)


Thanks,

Lizhi

On 12/18/23 03:39, Jan Kuliga wrote:
> Hi,
>
> This patchset introduces a couple of xdma driver enhancements. The most
> important change is the introduction of interleaved DMA transfers
> feature, which is a big deal, as it allows DMAEngine clients to express
> DMA transfers in an arbitrary way. This is extremely useful in FPGA
> environments, where in one FPGA system there may be a need to do DMA both
> to/from FIFO at a fixed address and to/from a (non)contiguous RAM.
>
> It is a another reroll of my previous patch series [1], but it is heavily
> modified one as it is based on Miquel's patchset [2]. We agreed on doing
> it that way, as both our patchsets touched the very same piece of code.
> The discussion took place under [2] thread.
>
> I tested it with XDMA v4.1 (Rev.20) IP core, with both sg and
> interleaved DMA transfers.
>
> Jan
>
> Changes since v1:
> [PATCH 1/5]:
> Complete a terminated descriptor with dma_cookie_complete()
> Don't reinitialize temporary list head in xdma_terminate_all()
> [PATCH 4/5]:
> Fix incorrect text wrapping
>
> Changes since v2:
> [PATCH 1/5]:
> DO NOT schedule callback from within xdma_terminate_all()
>
> Changes since v3:
> Base patchset on Miquel's [2] series
> Reorganize commits` structure
> Introduce interleaved DMA transfers feature
> Implement transfer error reporting
>
> Changes since v4:
> Get rid of duplicated line of code
> Fix various coding style issues
>
> [1]:
> https://lore.kernel.org/dmaengine/20231124192524.134989-1-jankul@alatek.krakow.pl/T/#t
>
> [2]:
> https://lore.kernel.org/dmaengine/20231130111315.729430-1-miquel.raynal@bootlin.com/T/#t
>
> ---
> Jan Kuliga (8):
>    dmaengine: xilinx: xdma: Get rid of unused code
>    dmaengine: xilinx: xdma: Add necessary macro definitions
>    dmaengine: xilinx: xdma: Ease dma_pool alignment requirements
>    dmaengine: xilinx: xdma: Rework xdma_terminate_all()
>    dmaengine: xilinx: xdma: Add error checking in xdma_channel_isr()
>    dmaengine: xilinx: xdma: Add transfer error reporting
>    dmaengine: xilinx: xdma: Prepare the introduction of interleaved DMA
>      transfers
>    dmaengine: xilinx: xdma: Implement interleaved DMA transfers
>
>   drivers/dma/xilinx/xdma-regs.h |  30 ++--
>   drivers/dma/xilinx/xdma.c      | 283 +++++++++++++++++++++++----------
>   2 files changed, 210 insertions(+), 103 deletions(-)
>