Received-SPF: pass (google.com: domain of linux-kernel+bounces-7403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 20 Dec 2023 11:55:33 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: fan <nifan.cxl@gmail.com>, Ira Weiny <ira.weiny@intel.com>
CC: Jonathan Cameron <jonathan.cameron@huawei.com>, Fan Ni
	<nifan.cxl@gmail.com>, Dave Jiang <dave.jiang@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Huai-Cheng Kuo
	<hchkuo@avery-design.com.tw>
Subject: Re: [PATCH v2 1/2] cxl/cdat: Handle cdat table build errors
Message-ID: <658346b553a01_34d57294d4@iweiny-mobl.notmuch>
References: <20231117-fix-cdat-cs-v2-0-715399976d4d@intel.com>
 <20231117-fix-cdat-cs-v2-1-715399976d4d@intel.com>
 <ZYHWZjsnQwcBEDpd@debian>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZYHWZjsnQwcBEDpd@debian>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oTyTrqXBBxZ0qEvqmvYnzIeCfyrL+vscnPErl/bULi3yepqIvvdyn3nlzk07?=
 =?us-ascii?Q?BzRSMJbwEzcmvtvVjkBAjXIVn2BVYIhKX7H1l5NmXt5283bdODhWCTmzfk+q?=
 =?us-ascii?Q?4N4pZ3PwDbnOA4h2/kczb/YUEJ1YbNN+sirVSgXYsUaz29TwpYkustxYSxg+?=
 =?us-ascii?Q?vjVNOGEQJ0ctdn2qjaPahhiHH9DuJZKVWbmls0XuiTI07RfmaXHngeNlET4B?=
 =?us-ascii?Q?nh+FsyTsPln4TN/HeV4T9Cui278a6ZtiSeh3nGiEW7asOBjOt4w5ZUhG8xFS?=
 =?us-ascii?Q?LJBtvqoezzoXW5826aPZYOnHrRc2K9boKOzD3s6M7uhLstp4h7aKh8HVa5Wa?=
 =?us-ascii?Q?huPayvkMjSpkhQ4RKJ8P+yvpkZBtxCHxJiP2bT6hgwz+x9+w/w6sIFtR3+pq?=
 =?us-ascii?Q?UyXe0te93eMTPyfFezDVI5z8JlOU9zeAkoxeTcQux8LBQbOs9dHyB2OaC2KJ?=
 =?us-ascii?Q?GNytcdQoqYCj/f/ahIOe6svUEaj0BtzjveLjU18d6l+XI8nWtYrbBGv7FlBV?=
 =?us-ascii?Q?dlzTF77z9Pyf6CXOeqhhrjh/5XreLyDbftnPu4C82QxdV6bnIAYdnrFS39d0?=
 =?us-ascii?Q?v4VP/vTNbkYwWxkJ7Btu7Xp7cTv++A4gLwa4+6ZgoB2z1i9QLc/IWTK//rOf?=
 =?us-ascii?Q?02liun9+glzpNdP+C05fcvY+4OFI6KKw48hfvD2WT1vemDqI664YUufMTQ+K?=
 =?us-ascii?Q?njsxm+O3q0xjwfawkTC1sya3VGxWnObH9NzebHT8XaiN8t2B+idxYkNRCDij?=
 =?us-ascii?Q?FDpT6AUg/cTcADmiKRx/+IXXTcROEucN5bADY337t8hdgt7GPwiI77tCn+Fa?=
 =?us-ascii?Q?hOkZjRyrLpr6HiNnTkNVsplb12K4Z6RvL+TWU4O+/O8qZX8UNzPB2GduCRek?=
 =?us-ascii?Q?kWNIiBbw61AqZWIFLjg2BMKqskJV+lORrv6QnVCrm6SsbIUNKB5w8v08jfiA?=
 =?us-ascii?Q?ejXWhYJNo7pAqGwAn6ZnVe2frr6kLq1VpWlHrP1DYS4aEIwhM99g/BX/Vxsg?=
 =?us-ascii?Q?IEwVsxvMFUU0prY4c76KkjuW7PH6antJw1tfCVCgYawtlSuzuQjP59K4vhb/?=
 =?us-ascii?Q?3/Pmlk9c4uCSNImru8RDTj7lHlrK8kMcortdSxZh12Dmw1OHta1gM44cj0gw?=
 =?us-ascii?Q?DgeT1Oa9M3Z/3iUXRHFpDUdSeuPjovQD0TV/15443d/dP8RhbdE6oFJHnBeI?=
 =?us-ascii?Q?3wE71DVnYxYhn1Ra/6PhRGIaW8nH28+EDFFBfXrgNWCxplFUxbDe49FkIcCl?=
 =?us-ascii?Q?ThPbwnqMBiKus9z6uKO9bo4b/MQ0wkfLXn2+h2FXw0zIJZJtD5xS72jz4AGs?=
 =?us-ascii?Q?zFKw0HayUQKF0DZQ96sjKl5ukucHpZtHngq1EYCGe01dbPniq4n0nYLh7t19?=
 =?us-ascii?Q?kHCrG0tNfT0QIG0TaH4otF4LCQilSTwPXSuxMxtc751i8Xz63SCCG0dWFnEB?=
 =?us-ascii?Q?Lp3HAVm2qCodDr3UVSOCXfsvScQr82VNo+4A9HbwJKDbLAY3Z3Afk62ibLU+?=
 =?us-ascii?Q?BA2Dc74gKKSEfTKDsDHurIUTELizKCd3kfiSqIt+7PfTNnk6GvB95M0l1XW6?=
 =?us-ascii?Q?V+wn16vcBuznQxFLYTWmbWH6Wg+AJNxZJ4U/ak1fr23s0aebJ4OXFxSJzCLZ?=
 =?us-ascii?Q?m7YDm9YUI18jHrB4lu5eiHCw77T4l40fpGADtwV2OFlz?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ffe3e8bb-294a-4b01-a9dc-08dc0195a254
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 19:55:36.5947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jw827Ks3XkD5+h16ShUXWlWj4G/f0Bbx0yDb6uflYVvLorG9ITpq4Ah3DVruErMZcA5Tbqb8JqeXwHwnEP8wrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8079
X-OriginatorOrg: intel.com

fan wrote:
> On Wed, Nov 29, 2023 at 05:33:03PM -0800, Ira Weiny wrote:
> > The callback for building CDAT tables may return negative error codes.
> > This was previously unhandled and will result in potentially huge
> > allocations later on in ct3_build_cdat()
> > 
> > Detect the negative error code and defer cdat building.
> > 
> > Fixes: f5ee7413d592 ("hw/mem/cxl-type3: Add CXL CDAT Data Object Exchange")
> > Cc: Huai-Cheng Kuo <hchkuo@avery-design.com.tw>
> > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > ---
> >  hw/cxl/cxl-cdat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c
> > index 639a2db3e17b..24829cf2428d 100644
> > --- a/hw/cxl/cxl-cdat.c
> > +++ b/hw/cxl/cxl-cdat.c
> > @@ -63,7 +63,7 @@ static void ct3_build_cdat(CDATObject *cdat, Error **errp)
> >      cdat->built_buf_len = cdat->build_cdat_table(&cdat->built_buf,
> >                                                   cdat->private);
> >  
> > -    if (!cdat->built_buf_len) {
> > +    if (cdat->built_buf_len <= 0) {
> >          /* Build later as not all data available yet */
> >          cdat->to_update = true;
> >          return;
> > 
> 
> The fix looks good to me. Just curious how to really build cdat table
> again when an error occurs, for example, the memory allocation fails.

I did not go that far as I am unsure as well.

Ira