Received-SPF: pass (google.com: domain of linux-kernel+bounces-7407-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ba20c2000c5c37c14c03b94f208b2961.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20231124151847.1915-3-ansuelsmth@gmail.com>
References: <20231124151847.1915-1-ansuelsmth@gmail.com> <20231124151847.1915-3-ansuelsmth@gmail.com>
Subject: Re: [PATCH v7 2/3] clk: qcom: clk-rcg2: add support for rcg2 freq multi ops
From: Stephen Boyd <sboyd@kernel.org>
Cc: Christian Marangi <ansuelsmth@gmail.com>
To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Christian Marangi <ansuelsmth@gmail.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 20 Dec 2023 12:05:39 -0800
User-Agent: alot/0.10

Quoting Christian Marangi (2023-11-24 07:18:46)
> Some RCG frequency can be reached by multiple configuration.
>=20
> Add clk_rcg2_fm_ops ops to support these special RCG configurations.
>=20
> These alternative ops will select the frequency using a CEIL policy.
>=20
> When the correct frequency is found, the correct config is selected by
> calculating the final rate (by checking the defined parent and values
> in the config that is being checked) and deciding based on the one that
> is less different than the requested one.
>=20
> These check are skipped if there is just on config for the requested

s/on/one/

> freq.
>=20
> qcom_find_freq_multi is added to search the freq with the new struct
> freq_multi_tbl.
> __clk_rcg2_select_conf is used to select the correct conf by simulating
> the final clock.
> If a conf can't be found due to parent not reachable, a WARN is printed
> and -EINVAL is returned.
>=20
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
[...]
> diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
> index e22baf3a7112..2393c7df0402 100644
> --- a/drivers/clk/qcom/clk-rcg2.c
> +++ b/drivers/clk/qcom/clk-rcg2.c
> @@ -266,6 +266,115 @@ static int _freq_tbl_determine_rate(struct clk_hw *=
hw, const struct freq_tbl *f,
>         return 0;
>  }
> =20
> +static const struct freq_conf *
> +__clk_rcg2_select_conf(struct clk_hw *hw, const struct freq_multi_tbl *f,
> +                      unsigned long req_rate)
> +{
> +       unsigned long rate_diff, best_rate_diff =3D ULONG_MAX;
> +       const struct freq_conf *conf, *best_conf =3D NULL;
> +       struct clk_rcg2 *rcg =3D to_clk_rcg2(hw);
> +       const char *name =3D clk_hw_get_name(hw);
> +       unsigned long parent_rate, rate;
> +       struct clk_hw *p;
> +       int index, i;
> +
> +       /* Exit early if only one config is defined */
> +       if (f->num_confs =3D=3D 1) {
> +               best_conf =3D f->confs;
> +               goto exit;
> +       }
> +
> +       /* Search in each provided config the one that is near the wanted=
 rate */
> +       for (i =3D 0, conf =3D f->confs; i < f->num_confs; i++, conf++) {
> +               index =3D qcom_find_src_index(hw, rcg->parent_map, conf->=
src);
> +               if (index < 0)
> +                       continue;
> +
> +               p =3D clk_hw_get_parent_by_index(hw, index);
> +               if (!p)
> +                       continue;
> +
> +               parent_rate =3D  clk_hw_get_rate(p);
> +               rate =3D calc_rate(parent_rate, conf->n, conf->m, conf->n=
, conf->pre_div);
> +
> +               if (rate =3D=3D req_rate) {
> +                       best_conf =3D conf;
> +                       goto exit;
> +               }
> +
> +               rate_diff =3D abs(req_rate - rate);

Use abs_diff() please.

> +               if (rate_diff < best_rate_diff) {
> +                       best_rate_diff =3D rate_diff;
> +                       best_conf =3D conf;
> +               }
> +       }
> +
> +       /*
> +        * Very unlikely. Warn if we couldn't find a correct config
> +        * due to parent not found in every config.
> +        */
> +       if (unlikely(!best_conf)) {
> +               WARN(1, "%s: can't find a configuration for rate %lu.",

Needs a newline in the format string and should drop the period.

> +                    name, req_rate);
> +               return ERR_PTR(-EINVAL);
> +       }
> +
> +exit:
> +       return best_conf;
> +}
> +
[...]
> +
>  static int clk_rcg2_determine_rate(struct clk_hw *hw,
>                                    struct clk_rate_request *req)
>  {
> @@ -377,6 +494,30 @@ static int __clk_rcg2_set_rate(struct clk_hw *hw, un=
signed long rate,
>         return clk_rcg2_configure(rcg, f);
>  }
> =20
> +static int __clk_rcg2_fm_set_rate(struct clk_hw *hw, unsigned long rate)
> +{
> +       struct clk_rcg2 *rcg =3D to_clk_rcg2(hw);
> +       const struct freq_multi_tbl *f;
> +       const struct freq_conf *conf;
> +       struct freq_tbl f_tbl;

		f_tbl =3D { }

In case we want to add more fields so this isn't a time bomb.

> +
> +       f =3D qcom_find_freq_multi(rcg->freq_multi_tbl, rate);
> +       if (!f || !f->confs)
> +               return -EINVAL;
> +
> +       conf =3D __clk_rcg2_select_conf(hw, f, rate);
> +       if (IS_ERR(conf))
> +               return PTR_ERR(conf);
> +
> +       f_tbl.freq =3D f->freq;
> +       f_tbl.src =3D conf->src;
> +       f_tbl.pre_div =3D conf->pre_div;
> +       f_tbl.m =3D conf->m;
> +       f_tbl.n =3D conf->n;
> +
> +       return clk_rcg2_configure(rcg, &f_tbl);
> +}
> +
>  static int clk_rcg2_set_rate(struct clk_hw *hw, unsigned long rate,
>                             unsigned long parent_rate)
>  {