Received-SPF: pass (google.com: domain of linux-kernel+bounces-7408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5bcc0bafc1c31ca4902b9b574f02625d.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20231124151847.1915-2-ansuelsmth@gmail.com>
References: <20231124151847.1915-1-ansuelsmth@gmail.com> <20231124151847.1915-2-ansuelsmth@gmail.com>
Subject: Re: [PATCH v7 1/3] clk: qcom: clk-rcg: introduce support for multiple conf for same freq
From: Stephen Boyd <sboyd@kernel.org>
Cc: Christian Marangi <ansuelsmth@gmail.com>
To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Christian Marangi <ansuelsmth@gmail.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 20 Dec 2023 12:07:37 -0800
User-Agent: alot/0.10

Quoting Christian Marangi (2023-11-24 07:18:45)
> diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h
> index e6d84c8c7989..c81458db6ce4 100644
> --- a/drivers/clk/qcom/clk-rcg.h
> +++ b/drivers/clk/qcom/clk-rcg.h
> @@ -17,6 +17,23 @@ struct freq_tbl {
>         u16 n;
>  };
> =20
> +#define C(s, h, m, n) { (s), (2 * (h) - 1), (m), (n) }
> +#define FM(f, confs) { (f), ARRAY_SIZE(confs), (confs) }
> +#define FMS(f, s, h, m, n) { (f), 1, (const struct freq_conf []){ C(s, h=
, m, n) } }
> +
> +struct freq_conf {
> +       u8 src;
> +       u8 pre_div;
> +       u16 m;
> +       u16 n;
> +};
> +
> +struct freq_multi_tbl {
> +       unsigned long freq;
> +       int num_confs;

size_t?

> +       const struct freq_conf *confs;
> +};
> +
>  /**
>   * struct mn - M/N:D counter
>   * @mnctr_en_bit: bit to enable mn counter