Received-SPF: pass (google.com: domain of linux-kernel+bounces-7423-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 20 Dec 2023 21:50:04 +0100
From: Wolfram Sang <wsa@kernel.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	Rob Herring <robh@kernel.org>, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v5 1/2] dt-bindings: i2c: pca954x: Add custom
 properties for MAX7357
Message-ID: <ZYNTfKLFGrLq8qGY@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
	Naresh Solanki <naresh.solanki@9elements.com>,
	Rob Herring <robh+dt@kernel.org>, Peter Rosin <peda@axentia.se>,
	Andi Shyti <andi.shyti@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Patrick Rudolph <patrick.rudolph@9elements.com>,
	Rob Herring <robh@kernel.org>, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231220082803.345153-1-naresh.solanki@9elements.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9k72YHBHIjnGiFBv"
Content-Disposition: inline
In-Reply-To: <20231220082803.345153-1-naresh.solanki@9elements.com>


--9k72YHBHIjnGiFBv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 01:58:01PM +0530, Naresh Solanki wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>=20
> Maxim Max7357 has a configuration register to enable additional
> features. These features aren't enabled by default & its up to
> board designer to enable the same as it may have unexpected side effects.
>=20
> These should be validated for proper functioning & detection of devices
> in secondary bus as sometimes it can cause secondary bus being disabled.
>=20
> Add booleans for:
>  - maxim,isolate-stuck-channel
>  - maxim,send-flush-out-sequence
>  - maxim,preconnection-wiggle-test-enable
>=20
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Rob, are you really OK with these bindings? They look more like
configuration instead of HW description to me.

> ---
> Changes in V4:
> - Drop max7358.
> Changes in V3:
> - Update commit message
> Changes in V2:
> - Update properties.
> ---
>  .../bindings/i2c/i2c-mux-pca954x.yaml         | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b=
/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> index 2d7bb998b0e9..9aa0585200c9 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
> @@ -71,6 +71,23 @@ properties:
>      description: A voltage regulator supplying power to the chip. On PCA=
9846
>        the regulator supplies power to VDD2 (core logic) and optionally t=
o VDD1.
> =20
> +  maxim,isolate-stuck-channel:
> +    type: boolean
> +    description: Allows to use non faulty channels while a stuck channel=
 is
> +      isolated from the upstream bus. If not set all channels are isolat=
ed from
> +      the upstream bus until the fault is cleared.
> +
> +  maxim,send-flush-out-sequence:
> +    type: boolean
> +    description: Send a flush-out sequence to stuck auxiliary buses
> +      automatically after a stuck channel is being detected.
> +
> +  maxim,preconnection-wiggle-test-enable:
> +    type: boolean
> +    description: Send a STOP condition to the auxiliary buses when the s=
witch
> +      register activates a channel to detect a stuck high fault. On faul=
t the
> +      channel is isolated from the upstream bus.
> +
>  required:
>    - compatible
>    - reg
> @@ -95,6 +112,19 @@ allOf:
>          "#interrupt-cells": false
>          interrupt-controller: false
> =20
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - maxim,max7357
> +    then:
> +      properties:
> +        maxim,isolate-stuck-channel: false
> +        maxim,send-flush-out-sequence: false
> +        maxim,preconnection-wiggle-test-enable: false
> +
>  unevaluatedProperties: false
> =20
>  examples:
>=20
> base-commit: 76998e5bcdf155b36c7066808a0a65b2ee13cb2a
> --=20
> 2.41.0
>=20
>=20

--9k72YHBHIjnGiFBv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmWDU3wACgkQFA3kzBSg
KbYCtg/+IHnU4Dlg5ZuJoczu05tDkIEorMC7QYYZauBkjd14V0PJuzdaQYYs6JBe
Z3uEZyw6hNx5fZT87YEH/hXEzmTVAIRuOUzg2aEVmPPy7FCUD8HG0I0siUJGWzSX
eASSmz9A5YaZS/AFAhPg982vespbLVtd0gubN1b2dabx+JCZvEyt2UN4ooiw7IXD
MdXWye8/RruXLZUMP+LehEmUi7JRbRNP8sBJISEIi4xnel6VLHDvIHKo31JWXjMK
6jyzMgIK82gHW1vOHAQsikKCQMFUSsXHBh2qDV9nMNDJc5LRXF7n2ujt+jgvnzSW
EwP8lRYyHxPGwsYYSdxRJ7QnfNLDvAsM7VEN8StXXt8Hlt+NzpJO6bIO69oKtNHk
21xEVsWlgS62W3p9Ro92h2HaircFk4iEYXHFW6mXhh8RVQfz+pNpAz3B1HfCp1e4
nskkKJPVOB7rchZvhf/dStDC9pZNRlXSO4A3irteWU2YB8RI9oFWkfLjAUGoNuRq
IGQwoEAJVA+ywcHp/dO4xYxzTlDK7CBns5TrGWxC5ke4mKVxOzvVjZXgdJ5rzUAB
RFoQKQ/AD08vPHh6lQXweShhc/h8oJEvvWfBZTH5KW/oICFUDyRU7oTcbtHf68JN
7JMP3aC6jApo69gofOmPhT/l5lj77PhuOh6Dpvrsdoro84pqf9Y=
=982l
-----END PGP SIGNATURE-----

--9k72YHBHIjnGiFBv--