Received-SPF: pass (google.com: domain of linux-kernel+bounces-7445-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20230921061641.273654-1-mic@digikod.net> <20230921061641.273654-2-mic@digikod.net>
In-Reply-To: <20230921061641.273654-2-mic@digikod.net>
From: Paul Moore <paul@paul-moore.com>
Date: Wed, 20 Dec 2023 16:22:05 -0500
Message-ID: <CAHC9VhQ3BNtG6y9gyKJiWrPCn81LpKG0Deep40GxAmUYCbem8w@mail.gmail.com>
Subject: Re: [RFC PATCH v1 1/7] lsm: Add audit_log_lsm_data() helper
To: =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>
Cc: Eric Paris <eparis@redhat.com>, James Morris <jmorris@namei.org>, 
	"Serge E . Hallyn" <serge@hallyn.com>, Ben Scarlato <akhna@google.com>, 
	=?UTF-8?Q?G=C3=BCnther_Noack?= <gnoack@google.com>, 
	Jeff Xu <jeffxu@google.com>, Jorge Lucangeli Obes <jorgelo@google.com>, 
	Konstantin Meskhidze <konstantin.meskhidze@huawei.com>, Shervin Oloumi <enlightened@google.com>, 
	audit@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-security-module@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 21, 2023 at 2:16=E2=80=AFAM Micka=C3=ABl Sala=C3=BCn <mic@digik=
od.net> wrote:
>
> Extract code from common_dump_audit_data() into the audit_log_lsm_data()

Did you mean dump_common_audit_data()?  Assuming you correct the
function name above this looks fine to me.

Acked-by: Paul Moore <paul@paul-moore.com>

> helper. This helps reuse common LSM audit data while not abusing
> AUDIT_AVC records because of the common_lsm_audit() helper.
>
> Signed-off-by: Micka=C3=ABl Sala=C3=BCn <mic@digikod.net>
> ---
>  include/linux/lsm_audit.h |  2 ++
>  security/lsm_audit.c      | 26 +++++++++++++++++---------
>  2 files changed, 19 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/lsm_audit.h b/include/linux/lsm_audit.h
> index 97a8b21eb033..5f9a7ed0e7a5 100644
> --- a/include/linux/lsm_audit.h
> +++ b/include/linux/lsm_audit.h
> @@ -122,6 +122,8 @@ int ipv4_skb_to_auditdata(struct sk_buff *skb,
>  int ipv6_skb_to_auditdata(struct sk_buff *skb,
>                 struct common_audit_data *ad, u8 *proto);
>
> +void audit_log_lsm_data(struct audit_buffer *ab, struct common_audit_dat=
a *a);
> +
>  void common_lsm_audit(struct common_audit_data *a,
>         void (*pre_audit)(struct audit_buffer *, void *),
>         void (*post_audit)(struct audit_buffer *, void *));
> diff --git a/security/lsm_audit.c b/security/lsm_audit.c
> index 849e832719e2..58f9b8bde22a 100644
> --- a/security/lsm_audit.c
> +++ b/security/lsm_audit.c
> @@ -189,16 +189,12 @@ static inline void print_ipv4_addr(struct audit_buf=
fer *ab, __be32 addr,
>  }
>
>  /**
> - * dump_common_audit_data - helper to dump common audit data
> + * audit_log_lsm_data - helper to log common LSM audit data
>   * @ab : the audit buffer
>   * @a : common audit data
> - *
>   */
> -static void dump_common_audit_data(struct audit_buffer *ab,
> -                                  struct common_audit_data *a)
> +void audit_log_lsm_data(struct audit_buffer *ab, struct common_audit_dat=
a *a)
>  {
> -       char comm[sizeof(current->comm)];
> -
>         /*
>          * To keep stack sizes in check force programmers to notice if th=
ey
>          * start making this union too large!  See struct lsm_network_aud=
it
> @@ -206,9 +202,6 @@ static void dump_common_audit_data(struct audit_buffe=
r *ab,
>          */
>         BUILD_BUG_ON(sizeof(a->u) > sizeof(void *)*2);
>
> -       audit_log_format(ab, " pid=3D%d comm=3D", task_tgid_nr(current));
> -       audit_log_untrustedstring(ab, memcpy(comm, current->comm, sizeof(=
comm)));
> -
>         switch (a->type) {
>         case LSM_AUDIT_DATA_NONE:
>                 return;
> @@ -428,6 +421,21 @@ static void dump_common_audit_data(struct audit_buff=
er *ab,
>         } /* switch (a->type) */
>  }
>
> +/**
> + * dump_common_audit_data - helper to dump common audit data
> + * @ab : the audit buffer
> + * @a : common audit data
> + */
> +static void dump_common_audit_data(struct audit_buffer *ab,
> +                                  struct common_audit_data *a)
> +{
> +       char comm[sizeof(current->comm)];
> +
> +       audit_log_format(ab, " pid=3D%d comm=3D", task_tgid_nr(current));
> +       audit_log_untrustedstring(ab, memcpy(comm, current->comm, sizeof(=
comm)));
> +       audit_log_lsm_data(ab, a);
> +}
> +
>  /**
>   * common_lsm_audit - generic LSM auditing function
>   * @a:  auxiliary audit data
> --
> 2.42.0

--
paul-moore.com