Received-SPF: pass (google.com: domain of linux-kernel+bounces-7484-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 20 Dec 2023 14:07:02 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Esther Shimanovich <eshimanovich@chromium.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, Rajat Jain <rajatja@google.com>
Subject: Re: [PATCH v3] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8
Message-ID: <ZYNlhgAzDPaLX8EZ@google.com>
References: <20231220-thunderbolt-pci-patch-4-v3-1-056fd1717d06@chromium.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231220-thunderbolt-pci-patch-4-v3-1-056fd1717d06@chromium.org>

On Wed, Dec 20, 2023 at 03:28:32PM -0500, Esther Shimanovich wrote:
> +
> +/*
> + * We also need to relabel the root port as a consequence of changing
> + * the JHL6540's PCIE hierarchy.
> + */
> +static void carbon_X1_fixup_rootport_not_removable(struct pci_dev *dev)
> +{
> +	if (!dmi_match(DMI_PRODUCT_FAMILY, "ThinkPad X1 Carbon 7th") &&
> +	    !dmi_match(DMI_PRODUCT_FAMILY, "ThinkPad X1 Carbon Gen 8"))
> +		return;

Sorry I did not mention this earlier, but can these checks also be done
based on vendor/product/subvendor/subproduct IDs?

Thanks.

-- 
Dmitry