Received-SPF: pass (google.com: domain of linux-kernel+bounces-7489-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7249a8c0-b97f-4634-a08b-06be503f8c71@intel.com>
Date: Wed, 20 Dec 2023 14:12:10 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add
 JH7100 SoC compatible
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	"Emil Renner Berthing" <kernel@esmil.dk>, Samin Guo
	<samin.guo@starfivetech.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, Maxime
 Coquelin <mcoquelin.stm32@gmail.com>, "Giuseppe Cavallaro"
	<peppe.cavallaro@st.com>, Andrew Lunn <andrew@lunn.ch>
CC: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>, <kernel@collabora.com>
References: <20231220002824.2462655-1-cristian.ciocaltea@collabora.com>
 <20231220002824.2462655-2-cristian.ciocaltea@collabora.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231220002824.2462655-2-cristian.ciocaltea@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUgzckRxVytYOEh3MU95SzdYTCtUOWZYU0xqUml5NjlLeXI3UW1mYXpJQjFt?=
 =?utf-8?B?LzVxT2NyTVFkbXRxVmxFNlRPclgvL2RSNDBkVTE0NHN4eU1aWTN6ZTBYSFdZ?=
 =?utf-8?B?VUFvZEdpdXkvVVozZU45MmR2OHU2d1ZkZXpTVE5OYnhrVDdHSGN1SU85UEs0?=
 =?utf-8?B?TzlMMFo0cE9NTW05THVXNnZ0WTlCUTc4TDJqRUFBREVxSks2NzM2WmhkaTBX?=
 =?utf-8?B?bUUrUkN6K1pRSWhLc2s0ME9TSXZZZFhiNXZLZW1IaG5RTkdHYXFYWjZQSlFv?=
 =?utf-8?B?V21vT2lJaXZtakhCNUwzZnNXdmttWnpZYmF5M2hmS1BhUkZPWHNFZVdkeG1z?=
 =?utf-8?B?OE02UEl4L3N4WjN2NWR0RlQxWVpoNlJIU3ZLUUN0RFM4MS9SSUlPREU5bk44?=
 =?utf-8?B?RE9QaXJGZmRsYldQMGd3TDJXZUJIWkNGcmpveUNEMis5ZTRaMlFlN1FVQ1hV?=
 =?utf-8?B?MnBFRHdFS095Z0xkNjBGY1A2UXU1bkJhNng1MDF2aVRvSDhJZ0FMVU5tdlhF?=
 =?utf-8?B?TTBBbUlxY0ErSmZwZDRYZjlPSS9tVnAvaVc1TWdKdGRTbVNzaWNRWlFPUHBh?=
 =?utf-8?B?SnRJTUxKYXRwTnN0dGNmY1oxUEdjVERWem10cTNpZVQ3ZUU5d3JkYU5jY1Jh?=
 =?utf-8?B?MEdwdk9OVnhHaUUvd09aZ1c2ejhDWGFKODc1dUtXVCtQZFRZOEVzcmNIa3ps?=
 =?utf-8?B?eHhiZ1krR2ZkcFZYYW5yUTluemU2bUZleDQ2R0kzWjBxdktLT3FiRlQ3eHhJ?=
 =?utf-8?B?K3pwK2RhYnpPbVBpd2U0TlR1ZTV6M2tSWFpmM0poazNTTTQxMXRVVWNENENT?=
 =?utf-8?B?Z2h1SEdtcjQ4SU81Ry93MGtST2hFSitiZkZYK0NqTVc0ZXJkK3hFbUxyOGw3?=
 =?utf-8?B?TVpRZE1CV2h0SytpVzZLNm1XMit6dHdzb1VZQytRb2xyT01ONTVKdHBCNVI2?=
 =?utf-8?B?TDdmRUVybWhZQi9EY0s0WVY1VVhwL2dHcnJha2JnTFhkNFVLeVczK2QvZk03?=
 =?utf-8?B?RDhEUkJWRmtTL3gvTk1aa1VGQndnRXU0bEgxaTZyb2MwZDlScTRMZFRreEJE?=
 =?utf-8?B?MmhGbUZFMEZUdXYxSVp3Z2dNVkJ2Zml5eEVTbWQ5WFNWZUZINmRFd2RVZkFa?=
 =?utf-8?B?ZFAzQVdqQnM2SitldnNzbnE1UlcyRXFOVTBzem53R2l5RWdWMDY3YWNRdW13?=
 =?utf-8?B?SVVrdGliRHF4RTRzS3JGMmptOVk5TVNXdHJOYnR2VitpekRMNi9qYVRENWZv?=
 =?utf-8?B?SXpQRFV1S2VXMlkvQm5yN2s0Z1dSMVh1SmxYVTJIVmpKcW1FK1I0Z0tXNXR2?=
 =?utf-8?B?eGdaY3llbTFkQ1lyc3hNVTllZUdBRTVlR2J1TGtPMXdjQjVUbEVOUW15ZkY2?=
 =?utf-8?B?NUVOY3VLNG4wcTdTeGJlRGo3WHA1QXhRRFFzdVY2aFZOaFgydWNJM2xpdEpo?=
 =?utf-8?B?aFdHU2lheG1yQjhocVNDUDMwS0JwUXJVQWRjT1czVDlGVy9kd1krUUk0WUhU?=
 =?utf-8?B?RklWY0pjd2ZUbVU3WjYyd243OEtkQ0xyUU9aYU1KeUVINmhkT1M4WEdxeHpo?=
 =?utf-8?B?WTVmRkd2djA2Y3l3UHJRY1pFQlc4NkJzWVFFRDEyVGQ2dkZ6WFdUcFJKVHFx?=
 =?utf-8?B?eGI4ZTNGc1lmTkcyTzJkY2xIalUxaU5pZHF4ZVVFUnJlblZFUE13cjQ2eHhk?=
 =?utf-8?B?Yk1LY2dlWFhZK0pkT2tUem9TNkpRQkUyTUxQejdPNi9jM3F5ckF6b2FDc1pF?=
 =?utf-8?B?M2orNDc1MGJhWk5FdCtiM2UwV1Vhei9BN1FsQStjTkR5dTFTMDFFRzN3dE1o?=
 =?utf-8?B?Y0xxamJRbWR5VTN6Yk5JTFNRME9PWVYvT3dtTnl4SkdNNVF2TW5DYTlUTTJG?=
 =?utf-8?B?K3I3dzVwLzR1K3YrRkFXSWNqTnVxcTBOVzBjeDY4Q0ptMUkrenc4TDNQZC9K?=
 =?utf-8?B?ZWRtZUZCelJQNC9xbENCTGpXNDd1aVhGcHlmWFhwZTE0d1F1QWdhWllya2Yy?=
 =?utf-8?B?d2xYNFpGdDB2SHVCdmtGMVFobFk4cFBQMHhzQnp5RjhxNTZVY1Fvb0dsOXNq?=
 =?utf-8?B?aWc1eEVzYjYzWmVJWHNVR3RhMlY3R0tsSWZkWERKMC8xRGRUWWtEeEFUK2dh?=
 =?utf-8?B?Y1FoRDY3d2RRQWNjeVdhWjYveWV3VE1CQ1lsVWY0c0l0SldyS2IzUTZxYUt3?=
 =?utf-8?B?R0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 609097b9-0e28-42c9-9268-08dc01a8b7d8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 22:12:13.6463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sc4JWT7ESdcDtKxLoD14huUyY8KDEbyYFAsvLYuvEqzl0zrLwT3Fqct5b/fGjpwNxIMwuqBPFSZC9ObDqVDBhVec0pKDa0KzdOR7SVznnYU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4707
X-OriginatorOrg: intel.com


On 12/19/2023 4:28 PM, Cristian Ciocaltea wrote:
> The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly
> similar to the newer JH7110, but it requires only two interrupts and a
> single reset line, which is 'ahb' instead of the commonly used
> 'stmmaceth'.
> 
> Since the common binding 'snps,dwmac' allows selecting 'ahb' only in
> conjunction with 'stmmaceth', extend the logic to also permit exclusive
> usage of the 'ahb' reset name.  This ensures the following use cases are
> supported:
> 
>   JH7110: reset-names = "stmmaceth", "ahb";
>   JH7100: reset-names = "ahb";
>   other:  reset-names = "stmmaceth";
> 
> Also note the need to use a different dwmac fallback, as v5.20 applies
> to JH7110 only, while JH7100 relies on v3.7x.
> 
> Additionally, drop the reset description items from top-level binding as
> they are already provided by the included snps,dwmac schema.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>