Received: by 2002:a05:7412:a9a8:b0:f9:92ae:e617 with SMTP id o40csp11425rdh; Wed, 20 Dec 2023 14:14:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IE60IAZ30DsL+YvDxkenkNDwTCiZZZ6sxejhDa3J7HItxcT/TYPyDT6oH/rGgamdx85y5v7 X-Received: by 2002:a05:6512:3d0f:b0:50e:54b6:5b30 with SMTP id d15-20020a0565123d0f00b0050e54b65b30mr725920lfv.68.1703110488247; Wed, 20 Dec 2023 14:14:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703110488; cv=none; d=google.com; s=arc-20160816; b=CI6goOWEzkHu9X360NTbvMdNLh2IlEAPOiTXJndF93JAAmAd4iORC7BMt1LgSkT2Ee 3mGVEiUBwk3MNoiNAG9pIOfhBfZhHsa695Po3G6GHL1iADwOnnqIy4nu7MInmMYe9vih aEwwVQVKxd7XwR0a0XvrgJ6WrzYn/3RIOfKb8nyXtmr78qmVxdbdXb0/5YkzNm6rnxt+ 75OhMrSXRE0ZgtU9DVBDMhRCVD1m1SYF7S5WnomSpuTxOfyCLp+4HzmEkW4uOybsS5Al kJ7a37IuxaRN3cjb1Y/TRJA+00qjOzCvCZhyjbfubminYFTsb/K2N6xT8LVZLFwLh/jB 2Wog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ZD3VpyHhC0C+pwwNEc0NgWoPlzlh6lpsOAPY3FHREss=; fh=L+nuQwpo7Lkk7JvXwTjpnOogzXLVA8umr2cjw5/wcYs=; b=oiHzqEzYHJDl0pv509yYAb44op4onWJ0nm4gFhEMIITrLpY7jyuDzOW96mOlx2DvzH onpH/mscCCiNGDSIYuc0C6UG3alAz6epdglFhai8yEe9spAC6Eo+AnnD6mYAJ25hFInd LOMS6P5uJTgijZ0pVa93Gh1KXQClc5vIbve/MCYm+6jIsCU5haOjtMRFp32PL/clD9Om rkF9YO7hHwQRyZ8VuH8K56GfTQceQKWhg/P7CTAMGKRdjplYakB2AOKokrmHwAwrmUzn gfxeN4L6B3RhlhHAkwNNZ4nNc8/39I251T+L2KdfYzQufWAYZVcOq1xgOzYsPkqnmceV 10iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Kf1WrFjb; spf=pass (google.com: domain of linux-kernel+bounces-7497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7497-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a102-20020a509eef000000b0054d84d8246esi212108edf.443.2023.12.20.14.14.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 14:14:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Kf1WrFjb; spf=pass (google.com: domain of linux-kernel+bounces-7497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7497-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 03F441F2383C for ; Wed, 20 Dec 2023 22:14:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE9F34AF83; Wed, 20 Dec 2023 22:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Kf1WrFjb" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD4914AF66 for ; Wed, 20 Dec 2023 22:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d3ac87553bso1683415ad.3 for ; Wed, 20 Dec 2023 14:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703110471; x=1703715271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZD3VpyHhC0C+pwwNEc0NgWoPlzlh6lpsOAPY3FHREss=; b=Kf1WrFjb1PqpB9MFOq9VrDarI1CznPtHkhB1SJO3zDbPKNTLdtRHcWBlwjwmE1eV4j +z8xHDxSsXZv+17LAUzkI48jbdM52Vhos4B6tYPdi6GEiOgkrtPxWdfxBzdCt3fbHZc1 hR2F779yiEhsalGWFiKM8LxsNECs1Kt8mWusE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703110471; x=1703715271; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZD3VpyHhC0C+pwwNEc0NgWoPlzlh6lpsOAPY3FHREss=; b=cMWn8LZMmSbBoTskxP8Tdy9sQZYgoBsZdWAc4+3odcYsKtscUyTxgxa9azOmuziHBV MdmYi+dgLAZfv4ftoSojWZbewdF9BahVmOPPFNifFnzEG998S43kUJgtFlp5xl0g8QOn GToEYJSh5v/N2eg7jUlPIhrtviPp1k5sBMyQUeLn/aTLCu/MyKFuNR/SfiPEsJUQRdSL rw8fX3IBWRNz/iVe2DuBStdkm8/NtM7JLs0bZr+VJUXRzLtwrXqZGIVsLx68W8e7P76c xHgc8Uhn8pJhlQNLCBroFaaFjxud4QspsqF10yAMFada4+MSd36ocdXkgTgJ5BwLUd2X sDoA== X-Gm-Message-State: AOJu0Yx2Ok1z61/dpkdATycdOhrKr8XNbBi2ao+6dXhDBW/nsWg29kQ9 k0zLcIhAaeRcb/26Wsom5MoAeg== X-Received: by 2002:a17:903:1cc:b0:1d3:5f99:17df with SMTP id e12-20020a17090301cc00b001d35f9917dfmr8812369plh.38.1703110471046; Wed, 20 Dec 2023 14:14:31 -0800 (PST) Received: from hsinyi.sjc.corp.google.com ([2620:15c:9d:2:8e1f:dd12:809:b2c8]) by smtp.gmail.com with ESMTPSA id d14-20020a170902aa8e00b001bf52834696sm203086plr.207.2023.12.20.14.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 14:14:30 -0800 (PST) From: Hsin-Yi Wang To: Douglas Anderson Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Linus Walleij , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/panel-edp: use put_sync in unprepare Date: Wed, 20 Dec 2023 14:13:11 -0800 Message-ID: <20231220221418.2610185-1-hsinyi@chromium.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some edp panel requires T10 (Delay from end of valid video data transmitted by the Source device to power-off) less than 500ms. Using autosuspend with delay set as 1000 violates this requirement. Use put_sync_suspend in unprepare to meet the spec. For other cases (such as getting EDID), it still uses autosuspend. Suggested-by: Douglas Anderson Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple") Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/panel/panel-edp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index cd05c76868e3..7d556b1bfa82 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -429,8 +429,7 @@ static int panel_edp_unprepare(struct drm_panel *panel) if (!p->prepared) return 0; - pm_runtime_mark_last_busy(panel->dev); - ret = pm_runtime_put_autosuspend(panel->dev); + ret = pm_runtime_put_sync_suspend(panel->dev); if (ret < 0) return ret; p->prepared = false; -- 2.43.0.472.g3155946c3a-goog