Received-SPF: pass (google.com: domain of linux-kernel+bounces-7504-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <5b971ec5-a455-4796-a3b0-76db8cfad815@intel.com>
Date: Wed, 20 Dec 2023 14:21:23 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 02/12 net-next] qca_spi: Improve SPI IRQ handling
Content-Language: en-US
To: Stefan Wahren <wahrenst@gmx.net>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231218232639.33327-1-wahrenst@gmx.net>
 <20231218232639.33327-3-wahrenst@gmx.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231218232639.33327-3-wahrenst@gmx.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWJpakkxR216Y0pVVnBPTnZ2TXZtTmUzcmZTS24xcDg1RmFlalhJbmFBMWRH?=
 =?utf-8?B?T2NtOGdKd0tCbXE0b2x3WnBoUXFHMVB5VEFxR2ZJcGY2YUhaM2xZNThkd29U?=
 =?utf-8?B?dnR3eC8ybU9DekdVSzA5YmpxeFZwM2RUZlQ1WmJLaDZuUkRPWEEvSElnY1VC?=
 =?utf-8?B?cjREbWhuZmxwcVZveWxSL1NYaTJPUDBjVHg2Zkg5c1VORE8vckRmMExQSXhs?=
 =?utf-8?B?QS9SSWRwZEd3TFlUbDVzWklKNTg5OW1RaHcycEJnTFQxQzR1Z3VXZ05oa003?=
 =?utf-8?B?YVVZYk1TdEo3REtWMHNUNjFKam1PSzBEK0JPUlNXNitkbTEzSGVpU1lWb09X?=
 =?utf-8?B?YWJ5SWs3alBWVzZ6Y0lCbnB3YWZidjRMd05qKzlCN05VU1ZIY0d0Wk5qZkw0?=
 =?utf-8?B?WEt5MmRQbVFyNVRVVkN1QWlBbkJKTndPeWIwMVFQU2toL1hwZ1BPVWg2WGZ0?=
 =?utf-8?B?b29kZWxNa2FjcUVhWWZ1UmJGZ0JIRnVtRURoODcxU0ZwcU8vV0VvWXQxai9V?=
 =?utf-8?B?aUVNT2lINjV2RnI5WTBDZzlrb2gvOHMzTktQeUVhVDJqM0dlOTNwbVhlMmpS?=
 =?utf-8?B?TnZ1SlFWRFcrUDhUR3lyd3ZLRXFGNkg1K2NNZWdEbVBSU2VLaW04VDRxcDFD?=
 =?utf-8?B?TEdZc1I2SDJLVVdkTXJkM3Z6cFk5d3FGS011NTVteVZqaExhSUJYdzJPSC83?=
 =?utf-8?B?OXdOaFJ4MHkrUXR2Z282Sml6RlRFRmRmQ25hYmx4ZmhSL0xUVWwzbkNnOHBQ?=
 =?utf-8?B?ai9QTFpucnd4cXhGQ24wZnV3d2pRc0RwRHR0Q1h5QXZEVFhlUWtaYTAybkwy?=
 =?utf-8?B?YTIzRUZ3Mks4NFo1Y0tvRm1xQjI4dlVFUzZqRENDek1ReU4zTldULzBwOFpK?=
 =?utf-8?B?ci8vMzZnUzRNUmozYWpHQVV4SENwaWl3b3ZaOGgvSEJnWHAyZFpYelBPZ3J0?=
 =?utf-8?B?cTZKbjVKUWZucXU0eWJKaUhyYjBwcVB0cVVYVkF2U1NDQmpVL1hCLzRSMnlj?=
 =?utf-8?B?RWNRZ040eWFGV1ZUcWtZLzA1TTI4Rzl0SFZRTTFhMXRpVGwzRDlYbTdmYlR0?=
 =?utf-8?B?ZEZwYmsyaEFNVTU1a0xrOGl1YktNOWZRa3EwOXZnMXBycm81T0pKUmVYbDBB?=
 =?utf-8?B?TXYvMWsydlloSkdqTjlpYmh0aGg5ZmZycEIwVmM3V0d0eTZvVWdHejIxcWNP?=
 =?utf-8?B?cnh6WFZaK2d6a1VxMmNzSkIrZDJURG1yenM2b3hvNDA5K3Y0dzN4VW1ueVdR?=
 =?utf-8?B?WUhBVmdMZnZpWUozcHVPMEw1QWQ5c0U5alFVZHV0Rm1wTHdkWWhQZ3doRS9D?=
 =?utf-8?B?SGk1T20waDVrQ0ExTGJ6a0o2K2drdURtaW43Z2ZqVTRqQ1VvNVdjck5JQVY3?=
 =?utf-8?B?YkdobWp1bm03d0ZrVmd1ZjYzQkgrNWt2U3JGOEV1VHA1YjN5UEozbjZiQkQx?=
 =?utf-8?B?L0orcmh2NUNDeEU3NFNKeXVMek5pTlFyVjBnVGZaNGZDSVVlOHZ3cCtXZ0Rp?=
 =?utf-8?B?WGJXZTU5YWEzbkg2aTNraFNPTXltcFkveUNkaTA2QkxHUStyMzY0Y2pHYXdP?=
 =?utf-8?B?bCtON2s0V1NYS1lhOWNhUHBzd2dzUXU3YVFZM0IxNTl6TVhSR2VWM0MyMWhJ?=
 =?utf-8?B?ZEtiQ0g5aUJ0ZS94dWVOdFJ4M0xzRzN5emx1aGxUTC9sTVVzeXppUGdjY3lQ?=
 =?utf-8?B?UlliNTdZT1RKV3NtRGRrQmJtSzhYU2VZL0greFdVU1F2cHVwcm5BL0NxMVhX?=
 =?utf-8?B?WTgreklTVHZvWTNRbjlTaVE5TUZPNThqTy8waVFOdzZMWTlkNEo4UGZYN0I1?=
 =?utf-8?B?M0pKWnduVU1XTDVNMzNkeE4vQnZ4MURqVWlMQjFaMVlqaXFrdWRJcEo1Z3ps?=
 =?utf-8?B?TXhEbDkxZ045c1pTQXpiSWMyLzBZTEtvQ200MFlqMEdlK2ZFdElqczh3eEoy?=
 =?utf-8?B?amdTeG5zbEx2ZHVFbE5vOE1kSVBMUzZQZmxvYXNOd3prOThKVnI3SzFCN2pS?=
 =?utf-8?B?dGFPSkN3cDkxQ2poNUp3emxxbkwxYlMwRVhQbWg4dHNENm5aeG96NlhmUXNI?=
 =?utf-8?B?dUhva2VHRTd4WjZENzd2NDJCNDJpUjhmak1xTzFxRUlnYThjcXpSOXdCV09J?=
 =?utf-8?B?MkxUaVZUeklMNCtEYy8wL21HZzFiSVhYMXZuTVB3cVFZT2syampzWlRKdm5T?=
 =?utf-8?B?UXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85e71a38-796f-45d4-25af-08dc01aa0194
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 22:21:26.4263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A7To5lryESppy3h60mKXmJ2GmSVTMjp1kdNQyOMsxN8UatI6pvmQenAwBaBCfYMi0EO8432/pgGwQqVMAfF0sdR1bU7RJy4s76AT/PT+324=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7413
X-OriginatorOrg: intel.com


On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> The functions qcaspi_netdev_open/close are responsible of request &
> free of the SPI interrupt, which wasn't the best choice because
> allocation problems are discovered not during probe. So let us split
> IRQ allocation & enabling, so we can take advantage of a device
> managed IRQ.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Nice cleanup.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>