Received-SPF: pass (google.com: domain of linux-kernel+bounces-7505-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <7a233358-2353-4c61-9d90-9f687f63b8bd@intel.com>
Date: Wed, 20 Dec 2023 14:22:05 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 03/12 net-next] qca_spi: Avoid skb_copy_expand in TX
 path
Content-Language: en-US
To: Stefan Wahren <wahrenst@gmx.net>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231218232639.33327-1-wahrenst@gmx.net>
 <20231218232639.33327-4-wahrenst@gmx.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231218232639.33327-4-wahrenst@gmx.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXRVeVkvNGQ2dGRMbCtDc3ZCMHg2R1lXTUFxOEVVSVJiSVpMRWdvMGNhRTY5?=
 =?utf-8?B?SXhhdXlWMXFJRC9paGw3VEZhekVVNXhJMG94U3dKcVVuOTFMQ1hZYzlmM2lJ?=
 =?utf-8?B?endCSm0zc1ZwTkxFTG5EdVUrWlJmdlFVakVFZzhENXo3dU9kUFNRV2dMTTlI?=
 =?utf-8?B?ZktIUkFmeEt0OEQraE83cEVBRWdmc251by9SVWhXV1RuazFKZXJZS3VpeEgy?=
 =?utf-8?B?WTVUdWtHWldYUk00VGN4TTF0SklVMVV3TEVmbElpV01Dd2UvQkUxQTJVUDhX?=
 =?utf-8?B?U1NOQmgxbm4wLzdnNkU1M2ZISHRMRWsvL0p4NTNqMHNVVmY2WUxtcG9lUkhJ?=
 =?utf-8?B?OXN6RVFvRVQxQXR0d3ZCc09WU2lYTFROalphZWhTeVhrZS80TmFNcDJpbEdS?=
 =?utf-8?B?WlZlU2lIa3orZFgrUVowTVd2MkNVSEJIQ0Q1ZXBtZThwWVJtZUR3cGRuNWNm?=
 =?utf-8?B?bGlTZ1AwRDJZSlQ3R1NvZitUdVpMQ0tsWFFOQ3kxQ292NUhGcW9JQm9FcE84?=
 =?utf-8?B?WlFFYTBUMUVTdkhQY2FWVEJXdStHVW5jK0FEc3JGUFJOMnhlY2pjY1E0dzNG?=
 =?utf-8?B?Ymk1VWVzMWk4Q0FFbWduZkVxMnU5WUtpT2V1N0Q5amE3dElRMTlIVHhnV1NM?=
 =?utf-8?B?WHp5U0ljZEhOa1VON0RoUktUeUo4ZDFBa2tZWCtVRmMyWFo0bTN1eW16VGR2?=
 =?utf-8?B?WjJYMitzSG8rQ2xuYW1RUUYrZ1B0cXlTTk5qOG9IWmdyU25yaEszUGVwY2hr?=
 =?utf-8?B?WG9zbEVwK2c0cGJFdmZReGNiTjRkYlVQdFR0cU0xTEh1blFadGlNMUYrQmU2?=
 =?utf-8?B?ay9CUnlDZWYzdjI2eE5EZ01SWExma1czcjZGbEZrYWYxMWpDVm0xN2ZlOVdD?=
 =?utf-8?B?SWttS2ZFSHhuOG5OcnZsWTNLV3NqcExRbU5BTkxOT1FDOGV1YlFQUHBzaHph?=
 =?utf-8?B?S2RoeEhsSVpabjRHWWs1VXhSZHpwT2ozUFU2QlJ5RmpuVVdGN2dpakM0WjJI?=
 =?utf-8?B?eXgzMHVMZlJpZHpuYXE3K3lkcUJEUjQwblVDL0kvcGNHdS9CeG5TejNJalE3?=
 =?utf-8?B?T3kyTGk1YW9lMXoxRFh3eEhDaUhtSFpRZlVNc2x5Rkl1QWF0WHZOeHVaUmRk?=
 =?utf-8?B?QUVZYVQyaGVna1VFQTY5ZWRtdUlrdktJWWVPSlZDeGNJQ0VhazZTSHRTYThx?=
 =?utf-8?B?YXdOL2I4MG1OczJyckRzNEF0N3lvUzlJUUxCRDVIZHhrbGFMNG1LUmI3N08z?=
 =?utf-8?B?OExobENIYXpyVlJwS0lMdi9VQ0k0UGh3NFJIWkFVNTdKVkcvOFVLYjQ2d0Fa?=
 =?utf-8?B?dDVhOWNVWUJ4VEtiZzVVR0JaTTVTdXM5NWM4dTF4UjQ3WHYxaTBUQ0NrTnhC?=
 =?utf-8?B?Wm0xbWxpeTFaVzkvbEJQbzJaMjFOQ0E0U3NDeVM5cVVHTDJJYU1BbGNpOTkw?=
 =?utf-8?B?UzM3NXVNU2E2UDN0VGJML0ptZ2Jid2RPcENRbTFlVE14eklNMnNkZm4zRWxU?=
 =?utf-8?B?Q2pNelJ3WlJGdHlaL29DcGlWWlM1T0VHSHIrTjlmQTduZXBGbGxHekQxUXov?=
 =?utf-8?B?NWJJNEkxU2ZNUXBlcXBKYXZxaktWNjRnSEJybUY0K0lER3BlaW5SaFliNEhv?=
 =?utf-8?B?UklhTHNsRjlEWEJYTWluVTZDdWtRRTF0NXoyK2UwQis2QTR5UmZmRlBia2xO?=
 =?utf-8?B?WWlsZDJLWE9VR3lseFg1dnBzd2NUd0ZUM3JMRURSbGVLVjZmSTNDWWEzZHBY?=
 =?utf-8?B?RVh6bXpySVkzTVN6YlhOWk13bjVRMUVpemdCZEpNQUVmZkZtVGRpdS82L2Va?=
 =?utf-8?B?ek5uT1BydS90RXdkTGlySkVQM1pPVFFZa1kwbXpheFlZalpmbGdBTXd6akRq?=
 =?utf-8?B?VjNCZXRKQ3dWMzBsV25BTElZUmNUa3pYcVlZYzVTZVFKNHlxWXJtRU1odDBU?=
 =?utf-8?B?TklIcnVCeEVOQlQ1RHlmaExZbE15TzJ1QWw2UUE3c2U4YWxJMlZHcHlLS3Rs?=
 =?utf-8?B?cjRFTngyL1loR21CNnFlTm1FUndadWphc0J5Q0R5ajN5eGxRYXBpTzFlaDl1?=
 =?utf-8?B?VERtZG5UVyt6aTM4NVpBR3M0a1krenZVWGtFd1kxcTJKbzUzOTgrekhFTlEr?=
 =?utf-8?B?b3ZXa0o2alB2Q0tMdzRSTEcydEs2TmpNRzU0b041TlRaOC9FeGwvMkdkUkRS?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 81e143c3-e69e-461d-0fa7-08dc01aa197f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 22:22:06.5293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iop3se0TEthp7blk0dvf2UuzZNDsfHKihEBRJnLy8qVBw1VDgqZDmxjcsxXwADQ8O6EJV1HHUl5pU0POQ2cjMnXXUy4rekeI6xhiPH7PWRA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7413
X-OriginatorOrg: intel.com


On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> The skb spare room needs to be expanded for SPI header, footer
> and possible padding within the TX path. So announce the necessary
> space in order to avoid expensive skb_copy_expand calls.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>