Received-SPF: pass (google.com: domain of linux-kernel+bounces-7508-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <940c4d0c-b354-4d85-b1c7-b290be1d0d19@intel.com>
Date: Wed, 20 Dec 2023 14:23:26 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 04/12 net-next] qca_7k_common: Drop unnecessary
 function description
Content-Language: en-US
To: Stefan Wahren <wahrenst@gmx.net>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231218232639.33327-1-wahrenst@gmx.net>
 <20231218232639.33327-5-wahrenst@gmx.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231218232639.33327-5-wahrenst@gmx.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEFDYkIvbVFwZ0RUOXF1QU5kaS9rNTVDRnJZRXVQcFVabFhMYndnRnZHN3Fy?=
 =?utf-8?B?eUpRRUZVKzNzUzkrWWgxSjdTTms0c3N0WitvN2tEZTVwSnhmbk1TalFWK0ta?=
 =?utf-8?B?NGQ3byt4cFFjMGh2RnZhYkZYSDVvaVg2KzkwMi9sa2xEdjErYmJOWWdvbzRq?=
 =?utf-8?B?dWtsUklZUkVRQUUwM3JzWE1lWXNKWjBYODJOMkpSTzA5c2kvNjVDV3VCUzFI?=
 =?utf-8?B?NEpUdFhDc01yT2diWE1YZ0pLZHZheE9GdUVoMGtIUUVSaU8xVHh6cFZiY1VN?=
 =?utf-8?B?bHlvNXlrL3lLbk5SUTFMMGo1bm9zMjNxQkxpRmlBWkJEY3NScGgwTjJCODNl?=
 =?utf-8?B?M21WNkNCcmZxOHlJalJXQVhCQ2NYQ1h2aWdYTDgvY0RkdEl6YkoxSlBjNTd4?=
 =?utf-8?B?L0NSS3U2eXAwTGVwTTR0SURxWjkxajdKV2c1S3Y3eE1yKzlyTVBkRVlZTmdj?=
 =?utf-8?B?K2JrTGJ5Z25WRmR2RTk0MzJueFFuRHBmTzFHZTNOdkRPSG5keWp3REdqWUIz?=
 =?utf-8?B?SWY4VTlqZGNxcTBsZ3F0MmlXL3NHQUMxK1RIMW1oakNnVWZSeURRWEh6cVlN?=
 =?utf-8?B?MnVJejc0Q01yU1RtQ0w3ZldUYzJWNnlKVmQvb0VuQnA5dWZENFJ6WHVhSWNq?=
 =?utf-8?B?QWVwMWZ3bWY2VjJEcnlnb2hLRnptbzlYaW4rcGNzZGpIQ3A4WndkMWQ3dnRW?=
 =?utf-8?B?OWdnUVUyd1NScWd1VzlnNmRzeEhqZkhrME1YUUhGMzlYbml5ME9JdmJTZkxy?=
 =?utf-8?B?dzdzSTF2dlNnL1Y3c1cxMDFWK3VEbC9mVFBiY1dselFGSmtlOWFMclFJbWox?=
 =?utf-8?B?NDRua2tuYzVQNFFjcUZEZ3cwdTZMZTY0dEpGNWRqSmNoZUlXd0NML1lXS2h4?=
 =?utf-8?B?L2tkVXFOWUdHYmlONjBPYTVPN296WUluNmJYQkJkNXNWcnpYWGRCeldUR1Qx?=
 =?utf-8?B?aVhOR2c0d0huUVgrTHgyNndJTDZkVG1IZ1VCMzNSWVhxUjBZbW5jc0NnZ29z?=
 =?utf-8?B?dXJlenc5M3lHcEs2V3lhMWNCWkNoOUhvQjIvRTQvVld0djVmZ1hrQlFzSEtP?=
 =?utf-8?B?NFlQV1YrQ1pRSlh2eFN3QmUzSS9scUM1MEhzM1kxN1BKdzR6SXhnMkdzaG52?=
 =?utf-8?B?c0V3OTBDRFlNTVJpSzJhRS8ybEFSRlpCaXpOOVZSMzZPMU5RNUtMeDU3TUdG?=
 =?utf-8?B?MU9wbld2TlpDMXEyMlpoTmhwRDNXRjFUK0RXKytIbFE3RE4rSUIwRnpOQy9i?=
 =?utf-8?B?UkRiQ0NTdUZpSitpTTNpSVBVekV4TE1UQzVKdnNkY3hqcGk1ZFhpajZXczdD?=
 =?utf-8?B?dCtDSkZLaXZwcUhzSHhGWTlRY0dDbnpxL1JmUGxydk91TlIwNWJudjBsV0kx?=
 =?utf-8?B?T1RsbWM2WTRLV09RRUFaang2c1VZcnp2S1pJa3ozdWxNS2djWWUyVVR2amMz?=
 =?utf-8?B?RUkwZHE4U2FkMUpycEp3VGNGaHZCQ2dNTUJTL3pyVFh4b1VaZ3RvWXV2aTU0?=
 =?utf-8?B?aThreGxaakFBKzd5U001bVJmV0w0dzZVUDMvYnBhT2xEYnB1a1NkT3pGenhn?=
 =?utf-8?B?RUZQSW5TRU1wQXNneFdyYjFWUTVzZUV0WHU5K1ZGa2FTQmpVR3ByZFNZZlVw?=
 =?utf-8?B?UDRPTWpDSEczVzUrUjNiVXNpK2EzUThMbWMvUXFFK1Rsekp2TWpYdXdtQmly?=
 =?utf-8?B?Y054SUJvT3FVMnpGbHB3SUdsTHgvK25zdDZ5ZkV0WVpiL2lySW1yMDc3TkZT?=
 =?utf-8?B?NndVVUdWUFFnbFFVZ1l2SHVYTTVOOXZMRlVaeTNLb2FkcEtRVjlNVzBEaHUr?=
 =?utf-8?B?Zi9GdXB3YzlnTkJPRGdjT1duT0cyMURzTGdzeGcxKzJOR2t1VjNLcTZkRmt5?=
 =?utf-8?B?dWUvRFoxVGlLR0pMcXRKbS9mWXVzcGxndE5OVGpYSzZQZCtrM2tHeDJ0UFg0?=
 =?utf-8?B?VWxUUUhnVjJ6dWxESGJ0ZUM4NlU5aUxnamxyZXFGUEhNRGJDZE1DZ1k4T25S?=
 =?utf-8?B?V0ZLQlNKMmlXY0dxYjFRZjJvR2JpLzdoWXQ4UVJpSjNnTTRyQjhXTFBNWEJz?=
 =?utf-8?B?Vk8yOFU4Q2dzY3FqT1krWlNqQSs1N3BWUnZrV0k3MTJMa2NwaU9hQ2V6cGd3?=
 =?utf-8?B?K3dJaE9zUGNpYVBBMWZhd0cvSnUxMTBLK0h2K3R0SjMraXVIYStyTDFPSDdo?=
 =?utf-8?B?Nmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49da782f-e393-4aa3-8c7c-08dc01aa4965
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 22:23:26.8909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eGqkYTKeC8lyu9+3hX+CeDdUY3cKof01NIjb4ZEUAHH33td4AS/BHiayA/4aVPtf86mVl/q284KwD8z3Lsn5maab8cjlD/rXPdWAkL/Peao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4926
X-OriginatorOrg: intel.com


On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> qcafrm_fsm_decode has the almost the same function description in
> qca_7k_common.c. So drop the comment here.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---

Better to have this in only one place so its less likely to become
stale. Users who want to review just the doc and prototypes can generate
this from the kernel-doc. Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>