Received-SPF: pass (google.com: domain of linux-kernel+bounces-7514-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <a24f00ed-460c-4ba2-bcf9-c767aacda70c@intel.com>
Date: Wed, 20 Dec 2023 14:26:34 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 07/12 net-next] qca_spi: Introduce QCASPI_RX_MAX_FRAMES
Content-Language: en-US
To: Stefan Wahren <wahrenst@gmx.net>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231218232639.33327-1-wahrenst@gmx.net>
 <20231218232639.33327-8-wahrenst@gmx.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231218232639.33327-8-wahrenst@gmx.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzdjY1FKdFJIVFFjdkFjZFp1OWF2bXZJME5LbUg0OFlJUVM1R3R4VW0yNVFJ?=
 =?utf-8?B?OXFrcm5ETWs5RWJXRHlmaTgybGtoRXg3VjR3NEVkTzViZmFLeGg4Z2gxakF6?=
 =?utf-8?B?bS8wcVZ0Q1NYckRtSE04T0kra3NxRW9KOWZNLzYyRCtHUTczZGZjbzBwZkhu?=
 =?utf-8?B?WjROc3ZTNnlWaWd3SWhqWGVQdWtwRjE0eWkrTDNaNXJxbTJ6RUdHRStmMUxi?=
 =?utf-8?B?c2tNOXMzOXN6YTYzQ2YxQ3M1VFlhRE01bnV1TmVXNDdsUC9zY21hT2VibkVD?=
 =?utf-8?B?bC9KTUFwT1B4YVIyZFNUWEZySm12VlJrZWpoUWN5WUlZbEp5OTlMZnBZWTZQ?=
 =?utf-8?B?Uk1ZSVNzUEE0clN0K0UwRTcxUSthczVnKzIzTHhTZElyNzJMdnpCamlTMFdJ?=
 =?utf-8?B?YUl0M2p5bCtVTG9ocmg4NUtTNnJ1Q2JvN1R2TmhaSW9oQ0wrN1phenpVNHpW?=
 =?utf-8?B?OG4yVERTMTMxN3kxQlhjVWhLM29BUUUwWm8rTWxxakFpUGxLNy83YUIwVjVL?=
 =?utf-8?B?T0s1TzFsUUIzMUVKeEs3bm1oZjQ0OXdXcHEwT2EvNGFGV2h6NkEySWwySWVZ?=
 =?utf-8?B?THRZVEJGQk8rdGlYU0xDOGgwYmNlUWhZOUVlWVZJeVlUejJKS3haYy9Mdi81?=
 =?utf-8?B?UWg0UWgyMyt6R0tSU09DSkRjbUNBRzBuMXlLYWFqaXZFZ3dKalFOUEFXamJ2?=
 =?utf-8?B?S0kwWlhLbHdKS3JKZGNTckFyQ3VlMFptNnBvWUQzLzNYWHY3cHNoK2dLbDJB?=
 =?utf-8?B?S0IxQ0RuVnFqN1kvYjRMK2xtL3lJNnl5UkFueW9FZnhSTWV2a1FEcEE3aGFU?=
 =?utf-8?B?UmQxeTdkUDBPbkxqS2NwUWNyb0RzYWxwUi9rVVhlMHM2aWFiMGcrSDlSS1Zl?=
 =?utf-8?B?NnNNeDhZUnNiK29NSzY5K1doWFMzTVduS3JscWVpOTMzYVFPTWZicEhnWFdP?=
 =?utf-8?B?N1VoYWx5Zm9uNkVZUTQzUlJadUNZUjV3dlVuMVgyZ0VjYUdOTkpvNE52TGt2?=
 =?utf-8?B?RjJDZU1xa0xKbHdXbDRpWCswRndpdWQ4R3NpejAvYVhzYnJqWWE1Q3dRMVJO?=
 =?utf-8?B?amFHVnN2YUlzUDk2aGFqak1kV1paNDdvcWxvdlVXYzB5eVRQcmloMjhseVdU?=
 =?utf-8?B?OVB6ZHJ6TjArL0Fyci9jRjVMcFV0TktpcktOQk9EUC9HSC9rSkZRMnk1bWcw?=
 =?utf-8?B?WFZpRFVZMmtlRFZMTlpIaWRtNmp1NG4wTU55SDIvNmE1ZE93R3ExM0hOWHlz?=
 =?utf-8?B?VFp0QVQvTlJRWWlmQjlkRGM0bWpHdkhWejh6b2ZKdThRL2VFc1AyY1hvWE1N?=
 =?utf-8?B?THcwcTljTkVZeEwyN3lVdncrTy92ZGxyS01JUUhIZlFFNEgrT1VrNGZpSDU4?=
 =?utf-8?B?UnV3UU1QcS94dXN2Z0p6a054NXVDN0xYU1hKbU9ORDZmMmJVYXNGcjBpSmUv?=
 =?utf-8?B?bTJZM1NjUndic3YzZnEwamlPTHk1STBDRWlxSzlpOWtSTUh1RUhwcUU5UWJW?=
 =?utf-8?B?T282Q29ieVZTbTVvOU4yTHpwaWFiTFVCc05qWUVnd3gySU1JanhNa3o3eHNK?=
 =?utf-8?B?VE9yczcwYytPZnFjL20xVGY3bEltdDduNFFiZlJqdlVEM1l5Y1NVR3N6QVZ4?=
 =?utf-8?B?VTFzNjNKWTVUYU5YM1FJSW5IYlhXTFlVbUJrQ3YwSmNuUUpoMWFPVUtMWEJU?=
 =?utf-8?B?c0NNYWJ4SWZlU1AxQ3JIK0l2WkpXaXBhV3N2bldoblhJaWJ6UW1JRGFoamdN?=
 =?utf-8?B?NlU0M0FoRC9zZmx0TFJtdWV2TTZvNEF3akc2ZWhES082Qjl1ZHQxcUplcHhX?=
 =?utf-8?B?WHUrM1lrWkluS20vNHZhZXZLRjlZY2tyMUo3VEFHb2xYdHJQSHBUVHdJZDBm?=
 =?utf-8?B?R3ZHdTVsZmFUcnVIZGtHZzFPMlpMVTZLZkM4QldWSGdGbFNGMWVvdGt3dllT?=
 =?utf-8?B?MzltamJCcTlwRVVEY0hKSmEyZDJCU1lDMkdqUlBueWZPZ052c1pTK1N5SUZw?=
 =?utf-8?B?L09UNmlMZ093aTFmT1VONGJsNlV4N2dvMGJoc1RrdUgwQ0o0b09IcXlaMXlM?=
 =?utf-8?B?YW40MkpEaUdVREZmN0o0d2UwY3ZPSS9IajJvci9oTStpWmcwSElwbkVKYThw?=
 =?utf-8?B?OHVZTk5RWmlZM0g0ei9UalNpbWNwQUhkWUlsa1l2T1ZJREVSVjV4RUxIbldn?=
 =?utf-8?B?dVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dbada0ef-1af3-4147-ca96-08dc01aab996
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 22:26:35.1417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dF5LD8q43Iuxn3TG6VjefZHHmdwRpD2/FfEbxArWGe71AqsjA4BB2ryFiR8M7z1q+QfAk6noRA6X/1kPaAjnRclW89bHHanM0bwpI9aA65E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8092
X-OriginatorOrg: intel.com


On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> Currently qca_spi reserves enough space for 4 complete Ethernet over SPI
> frames in the receive buffer. Unfortunately this is hidden under a magic
> number. So replace it with a more self explaining define.
> 

Yea, this is lot more descriptive to say "RX_MAX_FRAMES", rather than
just 4.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---