Received: by 2002:a05:7412:a9a8:b0:f9:92ae:e617 with SMTP id o40csp33712rdh; Wed, 20 Dec 2023 15:08:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZbUbwzY0Fq0MFvmaPnUQLr/G9KgMTdPuP+k8v07o/drhEu7W/NdfNB0h1C6ZC7mOlnYTO X-Received: by 2002:a05:6a21:6d94:b0:18f:97c:8a27 with SMTP id wl20-20020a056a216d9400b0018f097c8a27mr494057pzb.82.1703113734626; Wed, 20 Dec 2023 15:08:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703113734; cv=none; d=google.com; s=arc-20160816; b=hXflCmcvlqrime36TUU4idbJWz1bUlHaOoCUH0MgY7EhKdCCUewRKj7cwLjuCWKeTU ke0m97liE7ynWUV0wfmNIV9EPUj2yeZY3pygkwiSNOqd+6kwXH0Ou3K59UMwPJlKGnf5 m3PXdeqjg0UiSRnjLy56fcfaOZF8h5aBvHFRpC1dapsYrar0XifHRJ++oUb9h1KQ4/KS nqbGAYbXwzQp3OgKsxCC9Tybw+a3Nua0WQN5g5Ju/J+226I5XckibUtdnsaFf71Xa9Hi Hed7TCvqNPY9sXsxIM9aNRYY13vm/b7nZe6hjCPQaTsEhZng23qAPDpWgs+G0p2bqx3H TAAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=zwHHhlXrWPXO/4jePm24jC5xrVtR1eDI9aBc8Gwcrbg=; fh=UlFXU+hKOMcm6idRzNfe3Pu+B5L1f7aeir3C6i/NWQA=; b=wj6BRz2H2oN/hDlkCg259TxpaUc/UjUINJz6iXpW8sorU0rG2tQ+etyOO2erB5tdeA 87ai46cfQLPGmgM1zioNQ9WDUV/O/I8oLigoB1DiYJdL/D1yWMVEKngpiHnOT0zHDifG T8sAP7lb7+Ni0IMppOGVlTXw7D47eOcui0x/QPWep8XKKceivHYAwvBrkxMqTHt2PcQe +KPBh9DddYQG3XAlafcTPzkv8e418fpIaknsAJRhs768/gvj2gNRqqIWERvEqmZK0WgC ZKjZmCPmNRU6rKRFaNfoi3NFgZ1Q9esU8KVTLb/BjcBhmOhud7Zxb3R/sfNGan6wuoeU hHMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HkZltjKZ; spf=pass (google.com: domain of linux-kernel+bounces-7607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7607-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y63-20020a638a42000000b005c65ed0f688si468948pgd.296.2023.12.20.15.08.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 15:08:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HkZltjKZ; spf=pass (google.com: domain of linux-kernel+bounces-7607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7607-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4AD45283764 for ; Wed, 20 Dec 2023 23:08:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4041A7AE78; Wed, 20 Dec 2023 22:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HkZltjKZ" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE3C7AE62 for ; Wed, 20 Dec 2023 22:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703112416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zwHHhlXrWPXO/4jePm24jC5xrVtR1eDI9aBc8Gwcrbg=; b=HkZltjKZC3ul53coi6baNmb8Xc+F8tG2XV18mKdXiKgeiYbbn9OPBeUWdh5ztAimjbnpFB 2GilE/3J5f0GR7BFekMsnA105T6Tj1V3o4vskWNbm00HErq2KJUn8n+qngWdk5GDZkKe0E o5RyMOJJs+PYvY0E2HPFUJ4lXC+XsoM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-ZzFw3tvFOO2FjpEXoDI-bg-1; Wed, 20 Dec 2023 17:46:53 -0500 X-MC-Unique: ZzFw3tvFOO2FjpEXoDI-bg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 405B3863B83; Wed, 20 Dec 2023 22:46:52 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2D0D40C6EB9; Wed, 20 Dec 2023 22:46:49 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu Subject: [PATCH v2 40/40] mm: remove one last reference to page_add_*_rmap() Date: Wed, 20 Dec 2023 23:45:04 +0100 Message-ID: <20231220224504.646757-41-david@redhat.com> In-Reply-To: <20231220224504.646757-1-david@redhat.com> References: <20231220224504.646757-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Let's fixup one remaining comment. Note that the only trace remaining of the old rmap interface is in an example in Documentation/trace/ftrace.rst, that we'll just leave alone. Signed-off-by: David Hildenbrand --- mm/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index 188807d2aebc5..ac40c3d003368 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -650,7 +650,7 @@ folio_within_vma(struct folio *folio, struct vm_area_struct *vma) * should be called with vma's mmap_lock held for read or write, * under page table lock for the pte/pmd being added or removed. * - * mlock is usually called at the end of page_add_*_rmap(), munlock at + * mlock is usually called at the end of folio_add_*_rmap_*(), munlock at * the end of folio_remove_rmap_*(); but new anon folios are managed by * folio_add_lru_vma() calling mlock_new_folio(). */ -- 2.43.0