Received-SPF: pass (google.com: domain of linux-kernel+bounces-7615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <530f5c55-969e-4113-87ba-02a6f8ad31c1@intel.com>
Date: Wed, 20 Dec 2023 15:01:17 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 09/12 net-next] qca_spi: Log expected signature in
 error case
Content-Language: en-US
To: Stefan Wahren <wahrenst@gmx.net>, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231218232639.33327-1-wahrenst@gmx.net>
 <20231218232639.33327-10-wahrenst@gmx.net>
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231218232639.33327-10-wahrenst@gmx.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YktKTVZxeFIxWEhEOVRkT3EwK0dwRzhrK0ppWXh2dDJSRTdhZGZyUXp4TTcy?=
 =?utf-8?B?Uy9iL25vWGl3bDVYVW1WZDlOWW5Nb0JFeDdBTnhMSlErcWk0TWxUZk5OOXVx?=
 =?utf-8?B?cTNKelloQVNndkZaZXdhdlgyNnBGOTlWRXhrQWxjT0NYT2xnd2V4bUUyc21l?=
 =?utf-8?B?d3lxSkJiMEp1VDN0V0x2R1RqY1pPSk11ekFUNzJyZHVjaHREN0NUcXRhVStY?=
 =?utf-8?B?QWdpaE1MdUJGeEhjMWhObEFNUnRnZHVKdEFiUlFSVTZVMVNYQVJOTE9UQ0Qw?=
 =?utf-8?B?ZTB5TzROWGpNNytkelFhczFuV1ZxVjZxSndXQTlZV3l4TDB4V1c5b3lrOVVl?=
 =?utf-8?B?Vk54VXFaV0lQQlF2Z0VEQXI4TFJGWkxtMDZaL1V5S3o3dmpsQlFleC9GUGhl?=
 =?utf-8?B?QXV4eWhzQ240N0U1SGdIcWhKOG5DUkdmQmF0R3BpZks1NVZqQ21tamRWUnBy?=
 =?utf-8?B?VlIwRXQ4dDRFeElCaVpJSXUvbGNJNkVYSlVTOE5KWXFQbklZNG5kQ1lkcTFK?=
 =?utf-8?B?OTlTb0pZM0IzUlI0eDlrejUyQzhCRzZPSVVtbGh0WDNhTkpHbzdFZXByQzBs?=
 =?utf-8?B?MDl6ck9sZi9NWE5mUVdxMXkzTFhxalR0M3FiOVZac29sZFVNcVR1ckVEcWdX?=
 =?utf-8?B?NTlKZzBiMVVwL3pkaXp5aSttWW9tYmU2QzNyaVVjVDhyWU42M29kc2dKK09t?=
 =?utf-8?B?SCsyVjhyR0t4aE1oakk5WGYyY2ZuZEQ4cU9LRDJrUDZNd2VQRDZHQ0E1Zm9w?=
 =?utf-8?B?QWZMNmJRdCtKWkt3K00xTERXZjZQSFRyTWxtTEhlNlNpSnRYSUJOdVBJWXdu?=
 =?utf-8?B?a25lMExxclNNU2VlVDJ5S2JrSml2bTFWdGFmc3h0MnBSNGY3ckVsWnpxTlRG?=
 =?utf-8?B?WlVsbk9ld2xvbTM2VTYwY3ZvYnNpSWJ0NENuUWNlNkh1R0krTG5tamlKQlcv?=
 =?utf-8?B?NUxTME1WaG9vTmtoOUJGVzhQNXZ2Q0VRdVdWUEtTRjVzbmpwN09ZcHp6aDBP?=
 =?utf-8?B?Ulhxdi9GcnhIT0c1N01xc2VFNHNCL21lMVFSSEdZbXRuZSt1MUVLYm9DNVZn?=
 =?utf-8?B?SWsvRDlOSVFMcVFuU2VRQWlHSFlUMVhMQnVtU05OOTVscmpCeklUUXhPU1F6?=
 =?utf-8?B?dFpiUmVlWHBLMU51bVRYcE9xb3VDcjNycjJZMlhaL0hrZkpkdHBjV1lKRGRE?=
 =?utf-8?B?RDkzTlByRUlGakM4WWw2TUE0MEhZRFJVSWkvMlVvcFJzOHlVOUJQYlQyTmVE?=
 =?utf-8?B?R1ZFV1NTY2tYVE9XZGtlRWpRR2p2Rld6VExaTDdlbVZaaUZwNVFFNHBGZXBa?=
 =?utf-8?B?S3NCYk42a3h2emRaNVlLcGZLSVY3UUhSUGxSU2k3UThMdW82MkJIMFlyZm9l?=
 =?utf-8?B?dC9ZeWMxdEpMTldLdG1sYmRFQi96cnV6emUxcy9Ma29rSExPTmUxUGxuTmho?=
 =?utf-8?B?SERyZm9mLzFiWE01cS9jTjQrZ20wcTdhb29KU25KVkIxbG9oVGpDVXQydllJ?=
 =?utf-8?B?RGFtOFQxemNpZ2V5aytlVVZrM0U4djJiSERlME1MdmFGT1lUazREeVV2azBB?=
 =?utf-8?B?blpYeDg1WTBKVWsyWVlHRkQzTUhWcmJwaDNzV3l3cWR2ei94Rk1CSXFYMTBl?=
 =?utf-8?B?OVdkellLaHZzV3ZjOFhRdjVhUmVGTm4za0x2YVNJb2ZuaEMyT3NDeVpZMHJu?=
 =?utf-8?B?VDBqOFJ6TnlWbWp3WElWSGEyc3YrT2RCR0V6RGphR2RsWlVKK1hJSllLVm03?=
 =?utf-8?B?RVBUNmVFZjhHUGRLMzN4M3JpSi9yTHIza3U1TGZDUGhncXVTTzhSQTZybjRG?=
 =?utf-8?B?SG94TDM2RWFBZjZXRUZOY3BZc1dsbmNzanpsTXljWmQvekVFeDZRa2lZTlFp?=
 =?utf-8?B?cjJGeDhmWFd5WDFjejBsSXB1anRMVFRKL0VxNkYvcFBkTmg1eFV2UzJ3YzJj?=
 =?utf-8?B?TDNoenZZNFpVbkdPZTdtMDR2YmpDZVNucnAwZzZKOFpUa3AwU1VubFhTamRv?=
 =?utf-8?B?RlcveEVTVW1WQnkvcnZ1cUVYcDJVbVY4WDh3OU9oUEtZQnczblFGeXZvSTJu?=
 =?utf-8?B?K0Ezb1JIeWxidU11aW9jWGl6MlZ3RmRrbnVSSnhJbENIUlRwbUJKZVVZanQ3?=
 =?utf-8?B?aWFaR1k5b0pJMnByVTFwcmttUEpuVDQzUy9NQjdPZWo5ejc4ck9KQ0JMNWsz?=
 =?utf-8?B?bXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 586358b3-daf7-4b58-e0db-08dc01af9374
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 23:01:18.6851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HnlXOjsM6qmlpu7ooniTMFLzEqA/rCIWw4oJnq2y3DgpBpSHfBX/UsXcTxkl+pFxNyC7lCRTjclbN129sQg6Rtr9zCrXN05EN21LQvZP4jA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6073
X-OriginatorOrg: intel.com


On 12/18/2023 3:26 PM, Stefan Wahren wrote:
> Most of the users doesn't know the expected signature of the QCA700x.
> So provide it within the error message. Btw use lowercase for hex as
> in the rest of the driver.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---
>  drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
> index 6d2859aad921..c5d240fe4146 100644
> --- a/drivers/net/ethernet/qualcomm/qca_spi.c
> +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
> @@ -1005,8 +1005,8 @@ qca_spi_probe(struct spi_device *spi)
>  		qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);
> 
>  		if (signature != QCASPI_GOOD_SIGNATURE) {
> -			dev_err(&spi->dev, "Invalid signature (0x%04X)\n",
> -				signature);
> +			dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n",
> +				QCASPI_GOOD_SIGNATURE, signature);

Makes sense. Helpful to see whats expected vs whats there.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>