Received-SPF: pass (google.com: domain of linux-kernel+bounces-7649-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 20 Dec 2023 15:48:29 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Ira Weiny
	<ira.weiny@intel.com>
CC: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>, Dan Williams
	<dan.j.williams@intel.com>, Shiju Jose <shiju.jose@huawei.com>, Yazen Ghannam
	<yazen.ghannam@amd.com>, Davidlohr Bueso <dave@stgolabs.net>, Dave Jiang
	<dave.jiang@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events
Message-ID: <65837d4ddfd0_34d57294cb@iweiny-mobl.notmuch>
References: <20230601-cxl-cper-v4-0-47bb901f135e@intel.com>
 <20230601-cxl-cper-v4-5-47bb901f135e@intel.com>
 <7ec6d2af-c860-9b05-7eaf-c82f50f8e66e@amd.com>
 <65674a71ef4d0_a1b25294e4@iweiny-mobl.notmuch>
 <20231213171351.00004579@Huawei.com>
 <657a2ff3bcc0b_25c9c7294ab@iweiny-mobl.notmuch>
 <20231219171210.000078a6@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231219171210.000078a6@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0UIafOHthSRe4KrmTpMkgZF03cPIWM+JSL+E+Goy8HwnyPTLmufyJnuWek8o?=
 =?us-ascii?Q?gMbOiBJRrezLqcNik3UTJLpiheqC+Sscdm/mgaBWbZ4izoyHzQXMP1Upx/z9?=
 =?us-ascii?Q?6L1IzOohtNKLrjF2JbNEeuISgIglHXR/Xir5rfE5N0Ti7T8UCxIhtl0KXfiV?=
 =?us-ascii?Q?T/+jJAU7xyHsfS6+aCmUrzy20JUOokN+i9fQ6cjSak2dVfbucOHOZDK6XnLJ?=
 =?us-ascii?Q?7l2/fWyZLRu0pAcTRhnmsDstAdplkp9eM3ZnUOsh5xn9yxFAz8HXtBGj03AF?=
 =?us-ascii?Q?vRYSszX/FSLaELGhMKY9Ojm5qupykvXDoPVPWY2LOj8AeXQwO+vkivNz/e0X?=
 =?us-ascii?Q?H1tgyS1BU0+UTfpderSwrQlzIcPzm7TimSTq2g4mPn74sfE/2T48OYfKxs8B?=
 =?us-ascii?Q?yToeG4yJN8zyhyVKAgWDVyEhspcZeti2ZNyZ+VMJajrKVbtsy3Ummx2Q9usv?=
 =?us-ascii?Q?jKLFMZOZ4zPH9uiA+RV7JyPCYDy5zt40R0FrpDpc2BR1TW4rll5vzvk8FYD4?=
 =?us-ascii?Q?ndtcuyYDrRUlLgxAs42vWhDZUT/M/FPXOSCCEr+ca1zhiGUDtnQHZjU7q2+k?=
 =?us-ascii?Q?Jr9F7GNA023iSM1GthBggDs0qbz4r16Ign40zePqfc7cv+d8Pik+zz0FM42L?=
 =?us-ascii?Q?KDJA2dNg9P8pXtfH/gHiVOXa6bKK2b5MNwvfHWnQoI1do8X369raUt3jaWki?=
 =?us-ascii?Q?b05XBBzWsxFFL3+8Ondv4E4qY7qeq4ATv4DLd1NU9aM1bTOuFczYdPXgq77O?=
 =?us-ascii?Q?uwR6rl6FAU7CN6mRZGTvDXXkUTBKz/q2BGVObseGi2KaNqzwJW7mYh1UNF/X?=
 =?us-ascii?Q?c022XfDPqvsCbIYq3hBvC+ehxam+sHnD5se+XkBMP+ba3aZhuXg6I/3uTQU1?=
 =?us-ascii?Q?PuHf8ZAtEKAwnjLr4PzLpt++8Yjz5bnX47L+lqZEvw8l4wASZ6/rVhYHqvDi?=
 =?us-ascii?Q?yakA3TjVBzoy8Eb45xSXtF0ZLRWO3o2EWpDQ+8TfD01EdhtkObrdVNfNm0nZ?=
 =?us-ascii?Q?hZNOv3aqXQj4ru8EO4bFWyGGFo+lwA3fLVegb/ZLADUKQCYYTO5q5yx/ss+t?=
 =?us-ascii?Q?6fDyFA2IwuR0e66nwAJ2630xNYbLsK8o8bvmZ19P353Pvyg47Qz6qJvA7PqJ?=
 =?us-ascii?Q?CSNqpi9jsL/WBfs+Tm/Hj8gXfqiBKZmTVxcDytOwj6aTszTH1kovKupz3PHs?=
 =?us-ascii?Q?a61dBo4hYvbpHPhZLlZRKQpusyK3KQpdIsNKbm80VwYxrrXGNSQT7vRRJ4b6?=
 =?us-ascii?Q?lD/X6ezeAZeAGusy1J8KJ+j5Ft+PKswuIyC1ziIzLTcmgCY4rOqWFJTyghMh?=
 =?us-ascii?Q?XY/WI2kVplifxxs6pjmCuZqk65pYws2SQY4iOQhyAhlTPJtEv2443QERBbYf?=
 =?us-ascii?Q?MgZ7KuxZbv1DcPOVRhlD8GZK9mNdeihSNn1O3b2XNxkZ7DF9a3SLn1MsClAB?=
 =?us-ascii?Q?2bv0Ooo7pqS/8t0NY7pJ2jprHSHxuxx1XuLmyQiEFt12636ncz4xL1hmP/nv?=
 =?us-ascii?Q?3NoZGl9HIDtz+mYYUfg2uTOcLqZyUIPQdVPeM+c3ddqPvMWGupCAru+Jv7RZ?=
 =?us-ascii?Q?jmXkFtgo5NylRPe8lBtSX6Iz2bluGYNU7kRqzijH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b87e4194-48e9-4be3-cb37-08dc01b62dc7
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 23:48:34.6344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cCZgeCTarxgiO/AuKZL4ggcDs6XfhPPeEUlOlyWMdykJhri32OqCWu4/Ri0silEt5HT58YN0vewbKBkpV7Y1hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7542
X-OriginatorOrg: intel.com

Jonathan Cameron wrote:
> On Wed, 13 Dec 2023 14:28:03 -0800
> Ira Weiny <ira.weiny@intel.com> wrote:
> 
> > Jonathan Cameron wrote:
> > > On Wed, 29 Nov 2023 06:28:01 -0800
> > > Ira Weiny <ira.weiny@intel.com> wrote:
> > >   
> > 
> > [snip]
> > 
> > > > > __packed attribute just for cper_cxl_event_rec still fails to properly 
> > > > > align structure elements. Looks like, __packed attribute is needed for 
> > > > > all structs (cper_cxl_event_devid and cper_cxl_event_sn) inside 
> > > > > cper_cxl_event_rec.
> > > > > 
> > > > > Seems easier to use global pragma instead.. I could test and obtain the 
> > > > > output as expected using pragma..    
> > > > 
> > > > I did not know that was acceptable in the kernel but I see you used it in
> > > > cper_cxl.h before...
> > > > 
> > > > Ok I'll do that and spin again.
> > > > 
> > > > Thanks so much for testing this!  I was out last week and still don't have
> > > > a test environment.  
> > > 
> > > Easy to hack into QEMU :)  Hmm. I have a CCIX patch set from years ago
> > > somewhere that does similar. Would be easy to repurposed. Looks like
> > > I never published them (just told people to ask if they wanted them :( ).
> > > 
> > > Anyhow, if useful I can dig them out.  
> > 
> > If you have a branch with them with a somewhat latest qemu that could work
> > too.
> They are ancient and based on GHES emulation that got reworked before being
> merged. I had a quick go at a forwards port but this is a bigger job than
> I expected. May be a little while :(
> 

Let's not waste the time on it then.  Dan and I would like to get this
merged in 6.8 if possible.

Ira