Received: by 2002:a05:7412:a9a8:b0:f9:92ae:e617 with SMTP id o40csp53626rdh; Wed, 20 Dec 2023 15:55:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaWdBPU4+nXbxadC93PVE3w6hygFEivSXrlwfm5RBKBYMjeri01JUgMyuookrNe7+ifGzz X-Received: by 2002:a05:6a00:3394:b0:6d9:2ecc:7851 with SMTP id cm20-20020a056a00339400b006d92ecc7851mr4059107pfb.42.1703116547283; Wed, 20 Dec 2023 15:55:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703116547; cv=none; d=google.com; s=arc-20160816; b=eEcn++Vc3kersDYc0yYkVPxfISyGbc3G4l2NSYdunU+DcGg4jofbCKbX7+7FFE70F/ i0bhgk6icy7w+mg6pwPQ88qV8VIHMy9Dq1t3V/n1a9AY8TX+aI7DpYyugWg0md/7EV4f P1era1a0GXFUQWbmCzkPzqwxgnFkI6NCD3kcLI6FZEJevOB3Z+pkhAILbl3ZLOp8t2Q2 zHoyV8QoyJLtavZpgz+F33uPUxUwQPDUio+bDgvkC6+HN20KY3BSe0uDPKcRehOGl7yD CJYUY/HzvlN1GLgn3G2B69zyhLgOPq97Tx2Z639ACPIgqnebd0PdU0paoGkuuxAoflra mPqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=wqPdBL+/GuMSQccpt6uaKdYbWfswQmujpY/bP5YPpNI=; fh=rSP0cbDw6wFciwp+gswvmJInEGxrHURILuLTS1UJHas=; b=uOStOC8lqDvXexuaND6lWETFyWr6HgnlTT3+j4uYk2YfJqozwLRHNOwJINgh3R6XP8 OjTtk35QVof7oauM7OXU8Rt5CXfNB4qU9hPQwT0T+q44O5PZ+qPQRbLd0scwN4oFePMY 2W8Uw8/6jMJJu3XQqSS84kY4mtcogx4wbynzSPiGoLXSDuRftZZCYPvcy/b0ryvFVqMI DJG49Yz4YRbGvRecTf/MCuJZx2R79QhhQx1+ASLn9TPD06VyY52HHaqRmW9cQPeHXYLw h9wWB+3DayHO+Is4UsNHfgu0GMKg5ncXejzd3W3NdCoOsO8HBPZ+u1vu4+zN5slEifYw 48bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Q8hr8pYq; spf=pass (google.com: domain of linux-kernel+bounces-7654-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a14-20020aa78e8e000000b006d96e528a6dsi226863pfr.344.2023.12.20.15.55.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 15:55:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7654-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Q8hr8pYq; spf=pass (google.com: domain of linux-kernel+bounces-7654-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B1E47284ECA for ; Wed, 20 Dec 2023 23:55:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4DDB24C3C7; Wed, 20 Dec 2023 23:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q8hr8pYq" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CBA64B15B for ; Wed, 20 Dec 2023 23:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-7b7fb34265fso9415339f.3 for ; Wed, 20 Dec 2023 15:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703116507; x=1703721307; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wqPdBL+/GuMSQccpt6uaKdYbWfswQmujpY/bP5YPpNI=; b=Q8hr8pYq4FWBKc/qoEPWCGlisUvxT579O0+S7xTRUw6cEhEunxdUKX+ta5Gc9u14O/ LRKRHBoOcgL0kh2n53OIED0PpLHs+H0EX9n3VQfo4jul8nSkwJ/UvbbPPbMv00c35V9x lW4VQtlDijHZXwOZQuj2r6ZaTqbfQUAkN1wB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703116507; x=1703721307; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wqPdBL+/GuMSQccpt6uaKdYbWfswQmujpY/bP5YPpNI=; b=CsZsjcvaL6Ml/M0rVpJuYV1dne4tXEwS8MnHkePu1Z4ESXdQKJl7nqqR1Ng1Uctu2Z 1TKbZfHAajH4xMdyv5JbxkhpgLBgSMBQabWizrRh3uGvegMSTtZoeGLlCQROJIn4jmqj zAyBS1wI62ObUiDTZhq/KGPtx9QN7CAvrXjDu47Apl7iobnSyBj/3Q2Rr+w9mTm5kPls +9+jtFKj7HVXjQTVea9klOhUIIC6bOVHxqjqdLMK4XEt9blcWRbZBgce48Fa/x8LgOkF GGK0Czs2MOd6hYmOgHpSgfYL4fM9UekCTOkQV77ADFr7V2nEYUG7VsTtpW9qRCaniEbs jAdQ== X-Gm-Message-State: AOJu0Yz5v9zPrvKbw8iJi5UmXIm2U2+smQ1r6P1gRH6QQNlIES/90nwU uUes2wbtiHVS/z+zOtgISiwUfsvHW3OWKEV3IscrSg== X-Received: by 2002:a05:6602:4148:b0:7b7:b370:bd51 with SMTP id bv8-20020a056602414800b007b7b370bd51mr10520071iob.35.1703116507495; Wed, 20 Dec 2023 15:55:07 -0800 (PST) Received: from markhas1.lan (71-218-50-136.hlrn.qwest.net. [71.218.50.136]) by smtp.gmail.com with ESMTPSA id bp22-20020a056638441600b0046b39a6f404sm177805jab.17.2023.12.20.15.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 15:55:07 -0800 (PST) From: Mark Hasemeyer To: LKML Cc: AngeloGioacchino Del Regno , Krzysztof Kozlowski , Tzung-Bi Shih , Raul Rangel , Konrad Dybcio , Andy Shevchenko , Rob Herring , Sudeep Holla , Mark Hasemeyer , Alim Akhtar , Andre Przywara , Andy Shevchenko , Bartosz Golaszewski , Benson Leung , Bhanu Prakash Maiya , Bjorn Andersson , Chen-Yu Tsai , Conor Dooley , Daniel Scally , David Gow , Enric Balletbo i Serra , Frank Rowand , Greg Kroah-Hartman , Guenter Roeck , Heikki Krogerus , Heiko Stuebner , Jesper Nilsson , Jisheng Zhang , Jonathan Hunter , Krzysztof Kozlowski , Kunihiko Hayashi , Lee Jones , Len Brown , Linus Walleij , Mark Brown , Matthias Brugger , Mika Westerberg , Patrice Chotard , Prashant Malani , "Rafael J. Wysocki" , Rob Barnes , Rob Herring , Romain Perier , Sakari Ailus , Stephen Boyd , Takashi Iwai , Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Wei Xu , Wolfram Sang , chrome-platform@lists.linux.dev, cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v2 00/22] Improve IRQ wake capability reporting and update the cros_ec driver to use it Date: Wed, 20 Dec 2023 16:54:14 -0700 Message-ID: <20231220235459.2965548-1-markhas@chromium.org> X-Mailer: git-send-email 2.43.0.472.g3155946c3a-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the cros_ec driver assumes that its associated interrupt is wake capable. This is an incorrect assumption as some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. This patch train updates the driver to query the underlying ACPI/DT data to determine whether or not the IRQ should be enabled for wake. Both the device tree and ACPI systems have methods for reporting IRQ wake capability. In device tree based systems, a node can advertise itself as a 'wakeup-source'. In ACPI based systems, GpioInt and Interrupt resource descriptors can use the 'SharedAndWake' or 'ExclusiveAndWake' share types. Some logic is added to the platform, ACPI, and DT subsystems to more easily pipe wakeirq information up to the driver. Changes in v2: -Rebase on linux-next -Add cover letter -See each patch for patch specific changes Mark Hasemeyer (22): gpiolib: acpi: Modify acpi_dev_irq_wake_get_by() to use resource i2c: acpi: Modify i2c_acpi_get_irq() to use resource Documentation: devicetree: Clarify wording for wakeup-source property ARM: dts: tegra: Enable cros-ec-spi as wake source ARM: dts: rockchip: rk3288: Enable cros-ec-spi as wake source ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source ARM: dts: samsung: exynos5800: Enable cros-ec-spi as wake source arm64: dts: mediatek: mt8173: Enable cros-ec-spi as wake source arm64: dts: mediatek: mt8183: Enable cros-ec-spi as wake source arm64: dts: mediatek: mt8192: Enable cros-ec-spi as wake source arm64: dts: mediatek: mt8195: Enable cros-ec-spi as wake source arm64: dts: tegra: Enable cros-ec-spi as wake source arm64: dts: qcom: sc7180: Enable cros-ec-spi as wake source arm64: dts: qcom: sc7280: Enable cros-ec-spi as wake source arm64: dts: qcom: sdm845: Enable cros-ec-spi as wake source arm64: dts: rockchip: rk3399: Enable cros-ec-spi as wake source of: irq: add wake capable bit to of_irq_resource() of: irq: Add default implementation for of_irq_to_resource() of: irq: Remove extern from function declarations device property: Modify fwnode irq_get() to use resource platform: Modify platform_get_irq_optional() to use resource platform/chrome: cros_ec: Use PM subsystem to manage wakeirq .../bindings/power/wakeup-source.txt | 18 +++-- arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi | 1 + arch/arm/boot/dts/nvidia/tegra124-venice2.dts | 1 + .../rockchip/rk3288-veyron-chromebook.dtsi | 1 + .../boot/dts/samsung/exynos5420-peach-pit.dts | 1 + .../boot/dts/samsung/exynos5800-peach-pi.dts | 1 + arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 + .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + .../boot/dts/mediatek/mt8192-asurada.dtsi | 1 + .../boot/dts/mediatek/mt8195-cherry.dtsi | 1 + .../arm64/boot/dts/nvidia/tegra132-norrin.dts | 1 + arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 + .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 1 + arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 + drivers/acpi/property.c | 11 ++- drivers/base/platform.c | 74 +++++++++++++------ drivers/base/property.c | 24 +++++- drivers/gpio/gpiolib-acpi.c | 25 ++++--- drivers/i2c/i2c-core-acpi.c | 38 +++++----- drivers/i2c/i2c-core-base.c | 6 +- drivers/i2c/i2c-core.h | 4 +- drivers/of/irq.c | 32 +++++++- drivers/of/property.c | 8 +- drivers/platform/chrome/cros_ec.c | 9 --- drivers/platform/chrome/cros_ec_lpc.c | 52 ++++++++++++- drivers/platform/chrome/cros_ec_spi.c | 41 ++++++++-- drivers/platform/chrome/cros_ec_uart.c | 34 +++++++-- include/linux/acpi.h | 23 +++--- include/linux/fwnode.h | 8 +- include/linux/of_irq.h | 41 +++++----- include/linux/platform_data/cros_ec_proto.h | 2 - include/linux/platform_device.h | 3 + include/linux/property.h | 2 + 35 files changed, 328 insertions(+), 142 deletions(-) -- 2.43.0.472.g3155946c3a-goog