Received-SPF: pass (google.com: domain of linux-kernel+bounces-7716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 21 Dec 2023 12:17:45 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Fabio Estevam <festevam@denx.de>, Zhang Rui <rui.zhang@intel.com>, Linux
 Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the thermal tree
Message-ID: <20231221121745.2771ab8a@canb.auug.org.au>
In-Reply-To: <c2a170ea-39e8-49bf-9aeb-60eb20a22454@linaro.org>
References: <20231219103457.4e034e9a@canb.auug.org.au>
	<68012fb93e0057f62c03a5d9b01237c4@denx.de>
	<c2a170ea-39e8-49bf-9aeb-60eb20a22454@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Pwu/KAh5DGTsDjKpWgLYzm4";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/Pwu/KAh5DGTsDjKpWgLYzm4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Daniel,

On Tue, 19 Dec 2023 18:59:14 +0100 Daniel Lezcano <daniel.lezcano@linaro.or=
g> wrote:
>
> On 19/12/2023 03:10, Fabio Estevam wrote:
> >=20
> > On 18/12/2023 20:34, Stephen Rothwell wrote: =20
> >> Hi all,
> >>
> >> After merging the thermal tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: modpost: "__hw_protection_shutdown"
> >> [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> >>
> >> Caused by commit
> >>
> >> =C2=A0 726edaad90f6 ("thermal/core: Prepare for introduction of therma=
l >> reboot") =20
> >=20
> > Thanks for reporting.
> >=20
> > Daniel,
> >=20
> > Could you please squash the following fix to the commit above?
> >=20
> > diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index 07eb6537ed8b..f814568525f1 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -1002,6 +1002,7 @@ void __hw_protection_shutdown(const char *reason,=
 > int ms_until_forced, bool shut
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (shutdown)
> >  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 orderly_poweroff(true);
> >  =C2=A0}
> > +EXPORT_SYMBOL_GPL(__hw_protection_shutdown); =20
>=20
> Yeah, I've done it

Forgot to push out?
--=20
Cheers,
Stephen Rothwell

--Sig_/Pwu/KAh5DGTsDjKpWgLYzm4
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWDkjkACgkQAVBC80lX
0GwiuQf/WHt1ViM+2dq8s9X1CmgWhoAFblnctgEGXTq8oeyjwtfvHKtGTJGKf3wS
AellQ835ruI8IH8HyHgnGF9z1oa6/zz8L0GbiwS9ttJrAsnQZ34JsU+wKnYYvj7a
1/dEeLE7UdQz1GlVe8z70Sf5FM8Xt5SdsTeVgjDsgayYiqGNT+R5qrGK3Cwx91O/
XIlcPXfqtpc4btmvcryrgnvKUEZQWDe5ghL9kbc5/hxwcC8wRo9Fxexg//RP/jCv
9zlQBf5FmcGSaX35rm9wZB63msPZicciP78ViRftkLH1yyNpKF0JrtCr8gdX2udA
nqB86w9hOuwFqavF1d1Nsx+i7+CFCg==
=6+mI
-----END PGP SIGNATURE-----

--Sig_/Pwu/KAh5DGTsDjKpWgLYzm4--