Received-SPF: pass (google.com: domain of linux-kernel+bounces-7725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
CC: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Conor Dooley
	<conor+dt@kernel.org>, Cristian Marussi <cristian.marussi@arm.com>, "Peng Fan
 (OSS)" <peng.fan@oss.nxp.com>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Linus
 Walleij <linus.walleij@linaro.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Oleksii
 Moisieiev <oleksii_moisieiev@epam.com>, Pengutronix Kernel Team
	<kernel@pengutronix.de>, Sudeep Holla <sudeep.holla@arm.com>, Fabio Estevam
	<festevam@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
 protocol
Thread-Topic: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
 protocol
Thread-Index:
 AQHaL00vUsuXdEJTYUWYoB3T3FLKXbCxBK8AgABsGdCAALFEgIAAAH0ggAABhoCAANgEsA==
Date: Thu, 21 Dec 2023 01:31:27 +0000
Message-ID:
 <DU0PR04MB941736A1EEE3A98F188A59488895A@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20231215-pinctrl-scmi-v1-0-0fe35e4611f7@nxp.com>
 <20231215-pinctrl-scmi-v1-4-0fe35e4611f7@nxp.com>
 <20231219192912.yulmczvqbuh4jizg@pengutronix.de>
 <DU0PR04MB94170BCA413C2FD48A397B538896A@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <20231220123033.nrbperhbr4jifuvh@pengutronix.de>
 <DU0PR04MB9417E926CBD95BD7298B64D28896A@DU0PR04MB9417.eurprd04.prod.outlook.com>
 <20231220123745.ksdumfymu4xruufa@pengutronix.de>
In-Reply-To: <20231220123745.ksdumfymu4xruufa@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?CyKOASUHnmeROaHzDne9GtFuJlxymWKhaLLJMc3+8v2AnqbOtXgyGZsZPqSr?=
 =?us-ascii?Q?DC1mGoxZvsZnsT4RUH9t6V8O9CHbtU5lxC54YcpW1OwaTh2p6WA0ePsIRW83?=
 =?us-ascii?Q?/KXq3/RPGfDbqHQUQNIAOAH8yHXmrlu0v8Xx0Y1FpEheLgX4GehSr0hyHVsZ?=
 =?us-ascii?Q?KOgNq4rMokteQAeI+QPDw2QfUJ4kYvAwbMm4CT9X/8KGgq9GW67p3VLTe0n+?=
 =?us-ascii?Q?m4DEqMPiwfPPfPrmKhcni84YFWtYOI3kZ1eY9dMzWYmX2ko24Bqk7xWIkITy?=
 =?us-ascii?Q?LniqD/HQ4ZjYxiYgGtmsbYIa+PJtK6T2kMXkH6Ab59+9IWUGkPPt4ZO1TmI3?=
 =?us-ascii?Q?KE8G7mK+E+XbnRngehI9ZfXYMnyPsHYXHxYy+z8wc4vQXaFnD8KIX1lV9waR?=
 =?us-ascii?Q?T4mnPqLeKXjlkc1SkKX8zjh3M4he9fn6RL9rIS8k6yHe/M7fuuiUexiIvMAw?=
 =?us-ascii?Q?eQyFkFCreWpNFjLqo+Ad89LB6foxguk04SoziRr1rwZOMn835sz8Y+Y9zE+/?=
 =?us-ascii?Q?p0+Zp4J/xMzTgei119NRaM9o13hx6bfKqVI8K4vdi1XttwTQVbTHsANqZfts?=
 =?us-ascii?Q?4ohIIKbB8K27BOqf/m9dvfMSEikHS9rsNkJPvR0dDHcNTFBLJANqE8mgW13l?=
 =?us-ascii?Q?3uDtapupTsDXrcXVAjTWiSR1ZiBlkdOFJPiCC83NI5yyAfRrMOYgG1bggU1f?=
 =?us-ascii?Q?dP4gyBqi4LCr3tA0O0DdyFCT6V9z1aT4y2fr+rxNeBEcgfdjM1L/RnKx0cY4?=
 =?us-ascii?Q?MePH3qlZWTU8Vt/2V1p6cq0awKopaj6Z+Ibvd5es8JoOdEVJDMZ4h635jlTb?=
 =?us-ascii?Q?oYRQrFH0Mg5oJ4YEBr5PEmW1ysPwy2wsmegFB/vW7IxeX7l+p08qZHEe3pjs?=
 =?us-ascii?Q?Jfbb5F1oO9cv7EQNeM14+wdjeynzsZxBq+LGRFRMLQ6QBNN6ujMv/27eq57x?=
 =?us-ascii?Q?Way0q1JAgqY4WmfZxy9TFKLhPuljOnOFM0Djb1Rk1hAWlpRGasybIR5k3ph4?=
 =?us-ascii?Q?e3iHYbdz8SRBXJwCRcISYrNrImQzkALOZ3tcXePQdrL94W/CpRBGBLw8K3vx?=
 =?us-ascii?Q?3ldYsnr7v70+k4k/Qso5W/rEXiYxubJuCWqshyRJQbc282nzJhwU5J5kcezl?=
 =?us-ascii?Q?cPbCY2c5e8knRiGqkG6H7Q/udyATgcqEbfogd5pZ+WzuSBNpMVVAcU19p2UH?=
 =?us-ascii?Q?g2HWDbZj+iQqjOPkKLwcFE5WFc2dYW/kyZ26C6ljIHa6WAl98kksAwOKVM9K?=
 =?us-ascii?Q?j5Ni6WTlSl77W/y5HW4gPFQM3ckwmrkP1oxb8XB08Fm9xMPZQbdHnbvRCjyB?=
 =?us-ascii?Q?ioMU6k7sBwWr5HHRkSYn6NuRgt882K12R5RbM6R24pnaZa1rdzC2u7Ooeb4N?=
 =?us-ascii?Q?bIAuFs5W0xWEvMMCVmzgKYJ9WMZ3I62R3UMy5xFBkK587jsTZHn97lIxrSOM?=
 =?us-ascii?Q?nFmCK2aJLx2/3XXq1NJ2LylYxa5kbizApXqe7Q4tGVk+cDt+vd+lKvvcdCoN?=
 =?us-ascii?Q?vvRyaZe7wDIn4JBE8lYZLi7XiU5SHZA9MasC36Ska+t6CSpUo5Lu2oTMM0QE?=
 =?us-ascii?Q?HvtCY9aNTDDhcNFnSFc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 988d9df1-5604-4071-71e5-08dc01c48d55
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2023 01:31:27.5927
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yU6ejnToMkv/hR+pnmHAlOaIKhRod315Xpg/0FE5IBakXnGHBQ/BRvLQF00gS4MoVk71INWOIIizG7zL+V1oEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7415

> Subject: Re: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support pinctrl
> protocol
>=20
> On 23-12-20, Peng Fan wrote:
> > > Subject: Re: [PATCH 4/7] dt-bindings: firmware: arm,scmi: support
> > > pinctrl protocol
> > >
> > > On 23-12-20, Peng Fan wrote:
> > > > > Subject: Re: [PATCH 4/7] dt-bindings: firmware: arm,scmi:
> > > > > support pinctrl protocol
> > > > >
> > > > > Hi Peng,
> > > > >
> > > > > On 23-12-15, Peng Fan (OSS) wrote:
> > > > > > From: Peng Fan <peng.fan@nxp.com>
> > > > > >
> > > > > > Add SCMI v3.2 pinctrl protocol bindings and example.
> > > > > >
> > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > > > ---
> > > > > >  .../devicetree/bindings/firmware/arm,scmi.yaml     | 99
> > > > > ++++++++++++++++++++++
> > > > > >  1 file changed, 99 insertions(+)
> > > > > >
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > index 4591523b51a0..bfd2b6a89979 100644
> > > > > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > @@ -247,6 +247,85 @@ properties:
> > > > > >        reg:
> > > > > >          const: 0x18
> > > > > >
> > > > > > +  protocol@19:
> > > > >
> > > > > ...
> > > > >
> > > > > > @@ -401,6 +480,26 @@ examples:
> > > > > >              scmi_powercap: protocol@18 {
> > > > > >                  reg =3D <0x18>;
> > > > > >              };
> > > > > > +
> > > > > > +            scmi_pinctrl: protocol@19 {
> > > > > > +                reg =3D <0x19>;
> > > > > > +                #pinctrl-cells =3D <0>;
> > > > > > +
> > > > > > +                i2c2-pins {
> > > > > > +                    groups =3D "i2c2_a", "i2c2_b";
> > > > > > +                    function =3D "i2c2";
> > > > > > +                };
> > > > > > +
> > > > > > +                mdio-pins {
> > > > > > +                    groups =3D "avb_mdio";
> > > > > > +                    drive-strength =3D <24>;
> > > > > > +                };
> > > > > > +
> > > > > > +                keys_pins: keys-pins {
> > > > > > +                    pins =3D "GP_5_17", "GP_5_20", "GP_5_22", =
"GP_2_1";
> > > > > > +                    bias-pull-up;
> > > > > > +                };
> > > > > > +            };
> > > > >
> > > > > This example is different to the one you mentioned within the
> > > > > cover-letter. I didn't checked all patches just want to ask
> > > > > which API will be implemented by this patchset?
> > > >
> > > > I kept this change since it was tested by Oleksii, but anyway i.MX
> > > > not use
> > > these.
> > > >
> > > > The API, I suppose you are asking about this?
> > > > static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops =3D {
> > > >         .get_groups_count =3D pinctrl_scmi_get_groups_count,
> > > >         .get_group_name =3D pinctrl_scmi_get_group_name,
> > > >         .get_group_pins =3D pinctrl_scmi_get_group_pins, #ifdef
> > > > CONFIG_OF
> > > >         .dt_node_to_map =3D pinconf_generic_dt_node_to_map_all,
> > > >         .dt_free_map =3D pinconf_generic_dt_free_map, #endif };
> > > >
> > > > static const struct pinctrl_ops pinctrl_scmi_imx_pinctrl_ops =3D {
> > > >         .get_groups_count =3D pinctrl_scmi_get_groups_count,
> > > >         .get_group_name =3D pinctrl_scmi_get_group_name,
> > > >         .get_group_pins =3D pinctrl_scmi_get_group_pins, #ifdef
> > > > CONFIG_OF
> > > >         .dt_node_to_map =3D pinctrl_scmi_imx_dt_node_to_map,
> > > >         .dt_free_map =3D pinconf_generic_dt_free_map, #endif };
> > >
> > > I see, thanks for the clarification. In short: the i.MX SMCI pinctrl
> > > DT-API is the same as the non-SCMI pinctrl API since the dt_node_to_m=
ap
> will convert it.
> >
> > Yes, the fsl,pins format is same whether SCMI or non-SCMI. But we need
> > to pack the data to a format that matches the i.MX OEM SCMI PINCTRL
> > protocol, so we need to dedicated dt_node_to_map here.
>=20
> Yes, I saw that you're using the enum values 192-255 for the OEM specific
> part and the packing. Does you have public access to the FW implementing
> the SCMI?
>=20
The system manager firmware:
https://github.com/nxp-imx/imx-sm

Regards,
Peng.

> Regards,
>   Marco
>=20
> >
> > Thanks,
> > Peng.
> >
> > >
> > > Regards,
> > >   Marco
> >
> >