Received-SPF: pass (google.com: domain of linux-kernel+bounces-7816-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2dd7c5fd-7ecf-6741-1848-1585705d1589@intel.com>
Date: Wed, 20 Dec 2023 19:44:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v2] dmaengine: idxd: Remove usage of the deprecated
 ida_simple_xx() API
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Dave Jiang
	<dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
	<dmaengine@vger.kernel.org>
References: <ac991f5f42112fa782a881d391d447529cbc4a23.1702967302.git.christophe.jaillet@wanadoo.fr>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <ac991f5f42112fa782a881d391d447529cbc4a23.1702967302.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3JFYktpcmx5WnE5cThubzVVZjV0VTczU1lIcW5NbUkxamE2YjRSSHpBOExs?=
 =?utf-8?B?U2lZNGJwVGQ5VXdZZG1HRmd4Q1FVZUI5OFo4SHdIYkZTc0dXenNLbFBxVlFT?=
 =?utf-8?B?Vkp2eUV2STh1eEFvUG1UWHExejRTdU94b3krcXhhS0JPM2c5R2tIdzdlZ205?=
 =?utf-8?B?YlhVMmVEaXhVaXlLSzhjdy9lZllSZGs0TUI1TkhIczhmcWJiQWxLaG9aaHVH?=
 =?utf-8?B?Y3N2TG9FMERrS0l1dU5DR2JaQWRaQjFDNTBlcWRTRWM2YmZTWCtuN0xxYlRa?=
 =?utf-8?B?Nll5VFhiQmdidHp2SEswYmpMNktZRkZCSWZHQlNML0Y0eEtoWTg0ME01bU8z?=
 =?utf-8?B?MzBwVlNLejVPUk10T1FWaURLTWVuRTEwSm5tRXZYak4yNHQzckdXRno4UUlW?=
 =?utf-8?B?eUV1MjczQzRhK1Z6a0pkWC9DME92ZWp2Z1hER2pwMys4TFhTcTVHTllWVXRV?=
 =?utf-8?B?MmlTQ1JXVHdGMUJrb3hjZUd0eTU0alB0OHc1QVVTS1B2NVorTDVLcENEVE03?=
 =?utf-8?B?R0h3cDZObGgzU01NYnZwSjRHVEhaZzA1ZmF3cExRb1RqdmIwanBLUUU5Q3p4?=
 =?utf-8?B?bXcyaXF6Mm0raHI0ckVWVHZmSStYeWZPV3lNK05DVlJCY3FIK3czQ1lMd2JR?=
 =?utf-8?B?WkF0RVFTYnRSdHpsanEzblpiTXFpNWU4empMZUs0dy9pcEwzbjZocFY0enF2?=
 =?utf-8?B?dmMwWE9DUjMzUlJwYm5vYldxMTBhSmFRWUo0bW9VTlBNcGxaZHZmZXFlRGRw?=
 =?utf-8?B?c3k5NXhJbzM0c2lDL2RGanB0enU5dDQ5Q2R2c3locW5ESDFNNmFFd04zVkNh?=
 =?utf-8?B?c2hBaFZtSEhyYjZhK0F3eFhVU3h4OTRvOTRST3d4aW5pMjlZTitVckdXVW1r?=
 =?utf-8?B?ODQvYXV5SWpxb1h6Mk11MHNXVWhvWHhyV0xtazhPVnVPeHFXU0dhd1oxSXNI?=
 =?utf-8?B?TFpyd25XYWhacGdpZDl5UUs2U3dWNTV6dkdvYVI5ek1Oa0pFakxscHZrei9o?=
 =?utf-8?B?Q3U0TXJiNWwybGdielMxUlNrYU9xWmZ1Y1BiQjkyd2FnSGJmVDRjRFRzR3Z6?=
 =?utf-8?B?QVhaemQrRkNwVWI0WXhGeHhNUVhyN2NrOHJhRnNsRHE5SGRTdDJHcG1rQU52?=
 =?utf-8?B?UlJtdTdoejFWNHZ4ZkNBNC96OHBnMTdSMzJqNzRFeER1VE1sSmFNV3YvN2Zh?=
 =?utf-8?B?eURLVUQ0UFYxTGdhb2UrZG04eVBHekhPbCtKcTJOeFJaVUR4SVJoeFFiYnda?=
 =?utf-8?B?emVWYWtuUEQyejExZTVyT1BuQnZRMXFMV1VEUStsZTZBM3plMEFVdXAyYXIx?=
 =?utf-8?B?azd3RU1hUHd5eW9GZlRncVFDbE1qTyt3TlBBcmMxUm1jSWs2MHVlOFMwVjEx?=
 =?utf-8?B?b2djaTNQL3dmQ1JqeTczSCtFanNZdmZCNmMwSUJ3amgyR2RCdzY3Vit6Qjdn?=
 =?utf-8?B?YzR4YUJOb0tUQ3NNOFRDSmR2V1YwcXBYOEVzdEhkYjlPYmJ1NURzL3pVYkYx?=
 =?utf-8?B?K3R5WEtOc2tsdWdtNm1UNHlZUlZFQ2ZuOGxZMEJpM3FNWXA0d2JLR3ZuaHZ3?=
 =?utf-8?B?T3VEbnVPcm1yd3k3MnVmZ0kzMXoyeGdVR0J3OGZUN0RsVGQvWjVERmFKQ3M4?=
 =?utf-8?B?TysxRm5mYm1jZVh2VEZlY25GV0U4OHR3OWtGZDNTbDJUY0xlRFdHeDJCRVF6?=
 =?utf-8?B?REFXVnJsVUh2cXh5dlVmK0VyY055bDJySFpiTjJMQVZwc3pmeU4vckg5NlZ4?=
 =?utf-8?B?TUxwWGQyVTlnMjRPV2pCN01mbFErZk9yTk1uQUQ5czBxMjdaeVhoa1NNVmhq?=
 =?utf-8?B?ZXdHZjdPWkJVTExNK1JPbm9ldUt6QnNvQlVhS2FjeFNHbkhBaWtPaWVsME0x?=
 =?utf-8?B?L1RtclBYWlB2QjhLQ0JmMnJTV1BTR3lZNzNBM1BObXVYM0ZjQTBNLy9YOXpH?=
 =?utf-8?B?dFRPZ2N6N2ZiSGxZUVc0bHg1WG9ubEgrOWFsSTB3aUhsZjN2RVgvWGpGUUow?=
 =?utf-8?B?ZXJEL0NFNm1vZWREeU9Id0FidXI5d093WW51R1BSVG5kRnltVGJRemd1MnhM?=
 =?utf-8?B?UndmUWNhclZkcHk5cDZVcGNJUnpBd1ova2lQZSs0Nml6aDcxSDMrRVNPQi8v?=
 =?utf-8?Q?mDM+bgGqkronoGC1JJ7yaKuCj?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 96579a96-8ca5-4b1e-d2b9-08dc01d73127
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 03:44:53.5868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g9IX9R+aLH1r2+8ILOyLwzdn4uIDzkvLiqBAxaj1BOHZf2bp4R67UBW6wqHzDrAhsp7gBvToJwx17wrmiXr2Cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6416
X-OriginatorOrg: intel.com


On 12/19/23 11:33, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
> 
> This is less verbose.
> 
> Note that the upper limit of ida_simple_get() is exclusive, but the one of
> ida_alloc_range() is inclusive. Sothis change allows one more device.
> 
> MINORMASK is ((1U << MINORBITS) - 1), so allowing MINORMASK as a maximum value
> makes sense. It is also consistent with other "ida_.*MINORMASK" and
> "ida_*MINOR()" usages.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua