Received: by 2002:a05:7412:a9a3:b0:f9:93eb:408e with SMTP id o35csp10251rdh; Wed, 20 Dec 2023 20:33:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRGayHk0wgwW/iZ/uHx0f807JhKTdlsHbv9SQgTdzo6NAcQITOj3yb1ha1F0ASzeIECMhh X-Received: by 2002:a05:620a:1721:b0:77e:fba3:3e86 with SMTP id az33-20020a05620a172100b0077efba33e86mr127142qkb.79.1703133234933; Wed, 20 Dec 2023 20:33:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703133234; cv=none; d=google.com; s=arc-20160816; b=iJqcM+mDGzFhnpGMH63RtP4q34qjn1hWQc3bbw1/kh1a8Nn8UpXYpXRj729bHqR5pq 3xyBnsA0J7+qu0Sij/WlNy8kwZlhXc9qzjfEgzPHOH5aYL2D3/RBOXJ55dJkPJZr4dFs Q+ukXob6S4dhhLRRntXikV9XfBX7Z/lw/V952Epl+bG47FW/2tqcjGNNhbB9lIvXC97j ObFfuy3b1Y70jcalVnD8SrmF9t5uG/fGsa2uf73SD4tIkaO5XOdAUax3X1RayMrXOYBg LLo0nR6zLQcVW25RfQEdpgS5szVDNV835Z58eUGIZ0JkL55x37uH9iNiJsdCCR5nF/U1 YADA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cB5JX0tcfLHov/oOLKrnY2gF6gOzh9ftJuk4/XCl/z0=; fh=D060EaIwFX0dl8OBnu4R/wB2FjZeORUtACjexQPKTMk=; b=SjgzlKjVhLy6zpGllhhN2YJ/+1xA2CgiGE4RZGeDkkjO1KgdSPCB5/C+K/ECP9i15/ exdiWa+fYIoz8CZMRl+tz2IRtKn4Bk1xhzCfKG0LFJjR8TEzWiwXBecZ5o6IYeH7pSys 3ZoTp7Oq3LGar5OLcTTHPweaAJp8wmJi3+g1Jax6nWNMP/wG8ABsWydSQvlNzmLG7NXQ ch7R1H6kd8jVgd0q5ZZ8NhH48esMHQphRTgKcZL/KRsLfz16imgvGqGXgyM5xgxS13rp naiCVf690H4vlWDQyOsjoQDVhscXgyQur+ebiq+RSpNxNSbFzmxPPFCWFElkhs0ddh/f 7TLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="HTyM/uIy"; spf=pass (google.com: domain of linux-kernel+bounces-7836-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7836-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id qr6-20020a05620a390600b0077db734a0desi1449986qkn.125.2023.12.20.20.33.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 20:33:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7836-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="HTyM/uIy"; spf=pass (google.com: domain of linux-kernel+bounces-7836-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7836-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A78E21C23186 for ; Thu, 21 Dec 2023 04:33:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2859AD58; Thu, 21 Dec 2023 04:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HTyM/uIy" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40B5AD31 for ; Thu, 21 Dec 2023 04:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cB5JX0tcfLHov/oOLKrnY2gF6gOzh9ftJuk4/XCl/z0=; b=HTyM/uIyDJmBjphHYszMh9jD7H 3JXXxZqMtbbq/4YNg/S0iNx94XKARoA+K4F7ARByzGmOOkIi3c9jkyGT8ydHjA/34VEq5a920K/5c mmuLZO1rLYSXeZC6HAfjAgrRmPNl1cKQXJnuJvYptdaqUCKPXqU/Hz6Z0qduM9mjiCr1dTcPlFOl6 1UoD6Gm1eRCx5wsxdmSVg1RWiw2CuCuwDKXKHTI5i6zRcvT4+/O1omxD/v/9nY5Qb/PrONQeyFA/t T4zTRNkWCLDHdrRn5CCGLioaLx1bjUGRrHL44+2ovj1D/MZW1/QDGoOz+Om/WuF4amGKoanCZTY6S AWXvKEYQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGAke-004f14-MS; Thu, 21 Dec 2023 04:33:40 +0000 Date: Thu, 21 Dec 2023 04:33:40 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu , Muchun Song Subject: Re: [PATCH v2 01/40] mm/rmap: rename hugepage_add* to hugetlb_add* Message-ID: References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-2-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231220224504.646757-2-david@redhat.com> On Wed, Dec 20, 2023 at 11:44:25PM +0100, David Hildenbrand wrote: > Let's just call it "hugetlb_". > > Yes, it's all already inconsistent and confusing because we have a lot > of "hugepage_" functions for legacy reasons. But "hugetlb" cannot possibly > be confused with transparent huge pages, and it matches "hugetlb.c" and > "folio_test_hugetlb()". So let's minimize confusion in rmap code. > > Reviewed-by: Muchun Song > Signed-off-by: David Hildenbrand Reviewed-by: Matthew Wilcox (Oracle)