Received: by 2002:a05:7412:a9a3:b0:f9:93eb:408e with SMTP id o35csp18912rdh; Wed, 20 Dec 2023 21:02:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEvRKYx1qaro5tYaP3YlIHOfepkNavqJyEbaRjaXzsbIEk6hTuzxftQA0fiJ7OUsqq7u4Mt X-Received: by 2002:a05:6358:907:b0:172:b741:c5ae with SMTP id r7-20020a056358090700b00172b741c5aemr587025rwi.57.1703134959326; Wed, 20 Dec 2023 21:02:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703134959; cv=none; d=google.com; s=arc-20160816; b=cQg9QS5pQo89Gkh8PGmqNPlFewACHggtcMBmwSrYnEp/nu58/Z9A0PF13HmXYDD/xE 1gxrFl+rG+Y9wV2xw+d2L8YFT7jX4/AYM8f2ryFVBAewR7XU6uA4yQckdXgv+lGRgoB8 m295fgJuQ4Y6qjhm1ICTwtdGN+RZV5j6PSmSlHPtj2GsssIzc52IG6OXa8DliE3ZdAO7 SHXF6wTs0v7Uf/pFqhKtiHX8+ogZbspMmOntaomIcRQFaDxp+O57xC+D0Svf0RScU8Vo dV3sNtbLTovLvL5NSbHIjxbQThp1o0YZyxw6y11SpuWu+OgcLujkG28g4SB+dEi2AMSb P/bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=zntg2Srs2s2c96faHqg2OXqoNhfSS5jKTqCwm/IUeKs=; fh=sYuEqynkq5wzPhCmJl875LhM1dGdg7ahjyaxO2bESUw=; b=nwTcVFKI4bNJx3eBhOjuGlCHvQmeBeEUvQp4FxHdVZdhbtm0Hl7rrWaj/T4B0ftOZR Xopho08Q4yIs66yv61sr2xNP9n6acs9GAVk7Gg+dxcBfD7Efhom8VGMqySqZ/5KfjkAS ZvtL0dvE0Cg+BaDvCU5lilxxU4y07DAs84ITywJhg3DyEToFjOGHjFCx68/8WOhDzAT9 LhiUcEDBRsOst0AMRxULIwSo+ZSJVXWkeaGUJGLsbQfr65RVlIKUHeLT1j4MQIoSds5p 3Wz+qmFj3ZWUCgUOUyOqkMXJKIzDn7LkEH1QKbw4rG2951HWyYAHn9e3tWbZJwkFYbqJ 4Lpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OTzpHbY0; spf=pass (google.com: domain of linux-kernel+bounces-7852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7852-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 77-20020a630150000000b005c2185da898si903686pgb.832.2023.12.20.21.02.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 21:02:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OTzpHbY0; spf=pass (google.com: domain of linux-kernel+bounces-7852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7852-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 07D64B24E9D for ; Thu, 21 Dec 2023 05:02:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70358B674; Thu, 21 Dec 2023 05:02:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OTzpHbY0" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E042B654; Thu, 21 Dec 2023 05:02:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5465BC433C7; Thu, 21 Dec 2023 05:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703134930; bh=zntg2Srs2s2c96faHqg2OXqoNhfSS5jKTqCwm/IUeKs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OTzpHbY065f7WY5n+aAc9rAgTRq09cwEnMU6bKWP0FDhxFLRW2UMo7i8sx5gKqZzf OsrNJFlBJD+iBXI7A+n8TZDtr9D02FiRTSGjo81K3AxExQAHwgsSNBpVnD2aju7Sq9 P4uF9JNAbEhZYOYthQiWY7unydXBRs8g2S2p0Y51yqD6J/DI1s3gBtufJ5LA8PDnie fp40kyyaDjCD0YsBpicFna3ZnrAmSzeThrGpFR3Nzup14CPKkVNhN+hPMKp74EulPr jUBJ1bLGbDtrvZKU6foRT+wjLlOQATmKV0dINhEsgJpFpy8GUSl9s9oKN9j47IYCua A4KXqu65/atNw== Message-ID: <057db34aae21f78ca68ca0cc2930c97f.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231215115914.11588-3-zhifeng.tang@unisoc.com> References: <20231215115914.11588-1-zhifeng.tang@unisoc.com> <20231215115914.11588-3-zhifeng.tang@unisoc.com> Subject: Re: [PATCH V3 2/3] clk: sprd: Add reset controller driver for ums512 From: Stephen Boyd Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhifeng Tang , Wenming Wu To: Baolin Wang , Chunyan Zhang , Conor Dooley , Krzysztof Kozlowski , Michael Turquette , Orson Zhai , Philipp Zabel , Rob Herring , Zhifeng Tang Date: Wed, 20 Dec 2023 21:02:07 -0800 User-Agent: alot/0.10 Quoting Zhifeng Tang (2023-12-15 03:59:13) > From: "zhifeng.tang" >=20 > Add reset controller driver for ums512,The reset register has > the same base address as the gate register. This looks largely self contained. Can you make this an auxiliary device and put the driver into drivers/reset/? Then we can logically review it by reset drivers and possibly find commonality across other reset devices.