Received: by 2002:a05:7412:a9a3:b0:f9:93eb:408e with SMTP id o35csp21052rdh; Wed, 20 Dec 2023 21:08:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/MY8w6CGHaz8cXI+peCWY3qGnagpg38uh7Q9vF2yJhGCjCilSrIIDQGVdXcecBX4D7CED X-Received: by 2002:a0d:d286:0:b0:5e8:c7e4:e7a6 with SMTP id u128-20020a0dd286000000b005e8c7e4e7a6mr852981ywd.71.1703135312689; Wed, 20 Dec 2023 21:08:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703135312; cv=none; d=google.com; s=arc-20160816; b=ju+zFbljNbUuT39wdKMVXqbcCOYQHVhje+pGR2NJ8MOFwDNX+zEFsJ9NKCxOvZU1eU xZ9OfMMXYMSlEkzbDSwPsIzaBZt5iqnl4RGXnfxeRYGiNNfe1v4YT+V2hJjFOy5Hkdaz EPjGnBu9fKmC2x23g+KYP7FkBgQxQZXrWMhJ6iQHxaUX7r4OylrxyqFmoiRG/BOW+X2r BVtWk0fmwYojw08FJGlA1LEDpcIjECIp9KiGSPnY2XcFibHiJp2LBRHcdtFGBMIpzXVd uPPt2HhVf0SLXrwjSCZIOp24PuRMxr2PAGUrfFy+NWQIpCMNrzg2LKbDHzuwG65ukPxW RojQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:date:message-id:dkim-signature; bh=HmXdbVMseVEPw6PTGO2K7KJby6Cw53nb/+bBsFHy2NU=; fh=9XA+ukHoYnuapl9GXEg5mH9LwM3GICF8/qXylj02nmU=; b=McEUfriJctQgxbKsI9hcu2Hn4G7lhBSSQbMZb45mZ/Rarh2WwzKW/GVDli9MQvDkOm 0AK+XMSwjOGhzcyDgH/vXRZqL9brSKsxeRC/OW01Q4qxESMqU25zv1TpjpIIIJsmZoXv 5xIxvjCz3ZPO/MZ7A9Uq2sEBwJVC5SgUTds/cLWENlzAN9sy8VT6tAtvwsglfaptV3Gc sZnr+qD8+y8DoTG5tv62fVlhtBYdv0FpJ8e1BBdY6YLBxs7o/pwzbTw68T088ZXJMWLG gileAj4Hcwk2zvZcpeND6+p1b0KlZD+yqmmiY7rUMY7s+T/TtaAdq0i9cS+TTXdh7Z35 kHDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=eapX0si9; spf=pass (google.com: domain of linux-kernel+bounces-7853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7853-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w8-20020a05622a190800b004278594181csi1377843qtc.149.2023.12.20.21.08.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 21:08:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=eapX0si9; spf=pass (google.com: domain of linux-kernel+bounces-7853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7853-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5FBCF1C228E1 for ; Thu, 21 Dec 2023 05:08:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E8349463; Thu, 21 Dec 2023 05:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="eapX0si9" X-Original-To: linux-kernel@vger.kernel.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C576F8F52 for ; Thu, 21 Dec 2023 05:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.vnet.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BL4kAqC018818; Thu, 21 Dec 2023 05:08:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=HmXdbVMseVEPw6PTGO2K7KJby6Cw53nb/+bBsFHy2NU=; b=eapX0si9Edly3I42ALx+V+pjKRoioPRUWtiolNRZoCRLRZKPe/+mVjm6+GWw3LyK/1yt xG8xfZKpcOqqE0cx/VMkocGd6m+Xh5PcE0Nen5mqE+iapn2v2HRlhWGbAgTiDttnqrtz c5XiCt5qDVfkNJ8TWf4PnCx72LrOzFBGr9YG8ehfXePyw8YkzaBv5CGSO50uMOoVVp1I nIBSDeXdToJEUdnQssB1ZzI1fzIV2+3TuzVMp6hyUrelW6ZsEO07ChYl4GteeasVmyy8 t6Nlj+xv0LMKN6Zdl/DiJSEzWX0GOGSGG4msag8MZj/fsUPxwbiIrRMp7+fT8CR8keNr aw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v4ba6xvs0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 05:08:15 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BL4tbC3024092; Thu, 21 Dec 2023 05:08:15 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3v4ba6xvrh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 05:08:15 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BL43T96012351; Thu, 21 Dec 2023 05:08:14 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3v1rx22fqv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Dec 2023 05:08:14 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BL58EMl42926656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Dec 2023 05:08:14 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6AEE95805D; Thu, 21 Dec 2023 05:08:14 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6CB1758052; Thu, 21 Dec 2023 05:08:12 +0000 (GMT) Received: from [9.109.245.191] (unknown [9.109.245.191]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 21 Dec 2023 05:08:12 +0000 (GMT) Message-ID: <42cf3f2e-99eb-409e-8719-cff4afe0906a@linux.vnet.ibm.com> Date: Thu, 21 Dec 2023 10:38:09 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v3 0/4] mm/mglru: Kconfig cleanup Content-Language: en-US To: Yu Zhao Cc: Kinsey Ho , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231220040037.883811-1-kinseyho@google.com> <7baea98a-90ff-4c2d-9d00-d3ddc715c235@linux.vnet.ibm.com> From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-GUID: h9Asn6OPEE5WhPWKpQWMBE2GIR7a7t5a X-Proofpoint-ORIG-GUID: lUiWRqORQ1lj4hGH8It-eRWfwJjb8cWM Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-21_01,2023-12-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312210035 On 12/20/23 20:46, Yu Zhao wrote: > On Wed, Dec 20, 2023 at 6:45 AM Donet Tom wrote: >> >> On 12/20/23 09:46, Yu Zhao wrote: >>> On Tue, Dec 19, 2023 at 9:01 PM Kinsey Ho wrote: >>>> This series is the result of the following discussion: >>>> https://lore.kernel.org/47066176-bd93-55dd-c2fa-002299d9e034@linux.ibm.com/ >>>> >>>> It mainly avoids building the code that walks page tables on CPUs that >>>> use it, i.e., those don't support hardware accessed bit. Specifically, >>>> it introduces a new Kconfig to guard some of functions added by >>>> commit bd74fdaea146 ("mm: multi-gen LRU: support page table walks") >>>> on CPUs like POWER9, on which the series was tested. >>>> >>>> >>>> Kinsey Ho (4): >>>> mm/mglru: add CONFIG_ARCH_HAS_HW_PTE_YOUNG >>>> mm/mglru: add CONFIG_LRU_GEN_WALKS_MMU >>>> mm/mglru: remove CONFIG_MEMCG >>>> mm/mglru: remove CONFIG_TRANSPARENT_HUGEPAGE >>>> >>>> arch/Kconfig | 8 + >>>> arch/arm64/Kconfig | 1 + >>>> arch/x86/Kconfig | 1 + >>>> arch/x86/include/asm/pgtable.h | 6 - >>>> include/linux/memcontrol.h | 2 +- >>>> include/linux/mm_types.h | 16 +- >>>> include/linux/mmzone.h | 28 +--- >>>> include/linux/pgtable.h | 2 +- >>>> kernel/fork.c | 2 +- >>>> mm/Kconfig | 4 + >>>> mm/vmscan.c | 271 ++++++++++++++++++--------------- >>>> 11 files changed, 174 insertions(+), 167 deletions(-) >>> +Donet Tom >>> who is also working on this. >>> >>> Donet, could try this latest version instead? If it works well as the >>> old one you've been using, can you please provide your Tested-by tag? >>> Thanks. >> Hi Yu Zhao, >> >> This patch set looks promising. >> >> I have conducted tests on PowerPC and x86. >> >> In old patch set there is a cleanup patch which removes >> struct scan_control *sc argument from try_to_inc_max_seq() and >> run_aging(), Do we need to include that patch? > Sorry not for including that patch in this series. > > It's the first patch in the next cleanup series, which we haven't > fully tested yet. It'll be the first order of business after the > holiday season (mid Jan), does the schedule work for you? > Yes. No Problem. Thank you very much. Donet Tom >> =>Here are some test results from PowerPC. >> >> # ls -l vmscan.o >> -rw-r--r--. 1 root root 3600080 Dec 19 22:35 vmscan.o >> >> # size vmscan.o >> text data bss dec hex filename >> 95086 27412 0 122498 1de82 vmscan.o >> >> # ./scripts/bloat-o-meter vmscan.o.old vmscan.o >> add/remove: 4/8 grow/shrink: 7/9 up/down: 860/-2524 (-1664) >> Function old new delta >> should_abort_scan - 472 +472 >> inc_max_seq.isra 1472 1612 +140 >> shrink_one 680 760 +80 >> lru_gen_release_memcg 508 556 +48 >> lru_gen_init_pgdat 92 132 +40 >> shrink_node 4040 4064 +24 >> lru_gen_online_memcg 680 696 +16 >> lru_gen_change_state 3968 3984 +16 >> ------ >> shrink_lruvec 2168 2152 -16 >> lru_gen_seq_write 1980 1964 -16 >> isolate_folios 6904 6888 -16 >> lru_gen_init_memcg 32 12 -20 >> mm_list 24 - -24 >> lru_gen_exit_memcg 388 344 -44 >> try_to_shrink_lruvec 904 816 -88 >> lru_gen_rotate_memcg 832 700 -132 >> lru_gen_migrate_mm 132 - -132 >> lru_gen_seq_show 1484 1308 -176 >> iterate_mm_list_nowalk 288 - -288 >> lru_gen_look_around 2284 1984 -300 >> lru_gen_add_mm 528 - -528 >> lru_gen_del_mm 720 - -720 >> Total: Before=116213, After=114549, chg -1.43% >> >> =>Here are some test results from x86. >> >> $ ls -l vmscan.o >> -rw-r--r--. 1 donettom donettom 2545792 Dec 20 15:16 vmscan.o >> >> $ size vmscan.o >> text data bss dec hex filename >> 109751 32189 0 141940 22a74 vmscan.o >> $ >> >> $ ./scripts/bloat-o-meter vmscan.o.old vmscan.o >> add/remove: 7/3 grow/shrink: 14/4 up/down: 2307/-1534 (773) >> Function old new delta >> inc_max_seq - 1470 +1470 >> should_abort_scan - 229 +229 >> isolate_folios 4469 4562 +93 >> lru_gen_rotate_memcg 641 731 +90 >> lru_gen_init_memcg 41 99 +58 >> lru_gen_release_memcg 282 336 +54 >> lru_gen_exit_memcg 306 350 +44 >> walk_pud_range 2502 2543 +41 >> shrink_node 2912 2951 +39 >> lru_gen_online_memcg 402 434 +32 >> lru_gen_seq_show 1112 1140 +28 >> lru_gen_add_folio 740 757 +17 >> lru_gen_look_around 1217 1233 +16 >> __pfx_should_abort_scan - 16 +16 >> __pfx_inc_max_seq - 16 +16 >> iterate_mm_list_nowalk 277 292 +15 >> shrink_one 413 426 +13 >> lru_gen_init_lruvec 190 202 +12 >> ----- >> try_to_shrink_lruvec 717 643 -74 >> lru_gen_init_pgdat 196 82 -114 >> try_to_inc_max_seq.isra 2897 1578 -1319 >> Total: Before=101095, After=101868, chg +0.76% >> $ >> >> >> Tested-by: Donet Tom > Thanks! > > Acked-by: Yu Zhao