Received-SPF: pass (google.com: domain of linux-kernel+bounces-7899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Gangurde, Abhijit" <abhijit.gangurde@amd.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: "Gupta, Nipun" <Nipun.Gupta@amd.com>, "Agarwal, Nikhil"
	<nikhil.agarwal@amd.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Rob Herring <robh@kernel.org>
Subject: RE: [PATCH 1/2] cdx: Enable COMPILE_TEST
Thread-Topic: [PATCH 1/2] cdx: Enable COMPILE_TEST
Thread-Index: AQHaKSriAFfJDi7320ewod6YhdEEWrCqj8OAgAAAYwCACM3N8A==
Date: Thu, 21 Dec 2023 06:42:29 +0000
Message-ID:
 <DM4PR12MB77656006A8A6EB5DE6A468038F95A@DM4PR12MB7765.namprd12.prod.outlook.com>
References: <20231207163128.2707993-1-robh@kernel.org>
 <2023121551-uncommon-negation-fdda@gregkh>
 <2023121509-snuggle-lagged-1365@gregkh>
In-Reply-To: <2023121509-snuggle-lagged-1365@gregkh>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
 MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ActionId=6813435c-6295-479b-bffa-4c93ec05a67e;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ContentBits=0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Enabled=true;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Method=Privileged;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Name=Non-Business-AIP
 2.0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SetDate=2023-12-21T06:37:32Z;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM4PR12MB7765:EE_|SJ2PR12MB7868:EE_
x-ms-office365-filtering-correlation-id: 2201e747-e00c-41b9-7376-08dc01f000fc
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 qXCLxkGT6wi+f6qQZxyEgrjvNDPd4MandESp5r9XNbwC6H028KtDl5/R5o+L7qrwQA/j0hn7H4Gy1ZBoopOIiPgcQlP6IazKB0hL7ptrgbiJMKXdKMaPMOb7ZudPTdWU1pXnLOSBwCAweBbWL12fhrCKNyovfXLTYaacVgU5Zx3hJ7p1/qc0YHB0/w1BOIbiaFBa3mIQtJ/j2wEzI9M6tz9WWnpbQK1uNNKPWpWCJKUJIBEpyAkyDOwQyrnic0h5yVRWdOOg5/vA2ySc8AYkEoJmB7lTkST+6vkeSwtptdYr6ySyLc3LQTvJRLAxyPo35b/WuophC+ZiLx7xRs9/VaFzhMqejAxQ/T10dUMm5gblTDDwbijmByPhF6zCrTTXV+PMshBik8n5zlsY3khdBW8mEpev7qJ+4RVbqbHe7nkKUkjRz5y/680zVYdzGGkLRLcA9W+7xK9lb+U+PSNEKnUtbIB3Zw2xaMJQZ5f5+vG+ozg/NLfuPMT/aH8DorhQ2Zo+NX/z58YUyRe8qnZATkCJQ/lxgUqO1w3jvIVX7ZnkTHs+Zat0OtBsIgC913QM6aHiSMfqJPUpvKRVnMzmV5yUdIYEsKA9zY3bbtR+rqewa0ps9t6C4nISv8Q8tAh516rabtEvLz7qRIcmRsf+rs6E07Llqo1BxzxJ/U7yUbM=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB7765.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(396003)(39860400002)(136003)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(55016003)(7696005)(122000001)(9686003)(71200400001)(6506007)(83380400001)(38070700009)(38100700002)(33656002)(2906002)(86362001)(41300700001)(8936002)(8676002)(5660300002)(66556008)(4326008)(478600001)(6916009)(52536014)(66476007)(66946007)(54906003)(64756008)(76116006)(66446008)(316002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?NnQfz1grmUpduT+kdo95jqylSVbuD9hA37KjMhxCo91YE7n0EIt/7QQ/R6g5?=
 =?us-ascii?Q?UkYMS7gEd0d4pzuELv42mVWPcbiu6fbK46fIJ0kWu4Y+AdGCGg1w5R+5vIWo?=
 =?us-ascii?Q?rRcN6leW2bFh1JbVpnmz4YvMCsjmO+NqsGtx5eDbeDBkiMPAxrkYY1gxbLul?=
 =?us-ascii?Q?HwcYI8fqX1SAGQxpeMAryqor2elMfq65f99khWb1RrGcOLOnkSfDZiz11e0o?=
 =?us-ascii?Q?3EEFW2GzfDtL0U8jQADd9FjmexQX8Sk4dkeJmBrriNCnYG4LLJOn1yLI5yOa?=
 =?us-ascii?Q?L0npljoqJVfDQQgC6/o5nY2U29HDYW2ReQmeB/zum9iXW3q/xb4RolJjH2Qm?=
 =?us-ascii?Q?gLy8+fksevaJVTqGzcKojNWhKr6LKV1kMS79lChdf4q4Qaf0enjrh7iAlK+L?=
 =?us-ascii?Q?lOmJj2xxzotcr0EpaKfHW0FyWilj6qBXkJkqGsf/HWDN6SJM64Dv/OWzHwUu?=
 =?us-ascii?Q?Y3BFGLSC6TVVEzlFfY9JsgWK7s9fUsAYnm7gWMn67hku1UPDIUrbVme30a8c?=
 =?us-ascii?Q?iF+Nl/pfEVAxpTS3VmcMO9vpQ8AS8YebrBaVRw+KBOH3z1q3Tl+WfBuYoGIz?=
 =?us-ascii?Q?wIuCB5Drz5J6ttKmhj3f4PRYpGuXMvl/lRiX41YNvxVIRXCflD0DIN81x7WH?=
 =?us-ascii?Q?QrdQTUNG0J24qKCq96GsBAtxhem+lQvWLYOdgv0Z+zutI5axh5NfEY/iXq6Z?=
 =?us-ascii?Q?jNvSSN+ZTdCiQAwizaTLfbEtqfUerijc46FZTPKc/cGSxaQHNQYUiOdf5qkC?=
 =?us-ascii?Q?VjceqHhi7K8vb83I+NItseevgCILZqj59I0HOv4GoX72OctQ02sdyvJv1c5a?=
 =?us-ascii?Q?gw1YFb9bqb58gSL5m9QS9VVSM+pdWbBgsxFmCUlPV5qCog55m2bqor9aZxv9?=
 =?us-ascii?Q?2LxQaPeSGGoychCo2KXSKN69d8Vp5iw2HVRtF66eCKKJAocdVMlk0XaF4jT+?=
 =?us-ascii?Q?o1bCDSEBueuMWr2BNgxO2ARSR1kSV7Nl/CA4cmb8OSvEY1P8gSPgCD3R1j3k?=
 =?us-ascii?Q?Ggxsr+y0nLAeLVAxjzX2S1SRYq+5IS/44mi0mkJTRq+cInSOwTdQD+UZNgDk?=
 =?us-ascii?Q?5QLFl1TwzeUS2evmOt4EaGjaeR5keHsi2zeBWa2M8iRq4g/f4+CkY+HBfixY?=
 =?us-ascii?Q?tyZvin6SvRtEWbGc5PRXtFX/0jAiCJKR6mS6L1hHrWOoMZl0pg0p9BmZEC1U?=
 =?us-ascii?Q?ItEJ9hqO/9gRYJ8FHukbdlMy8oaqpzZ3M9v+D5jt1ZKUxFWeBWwGNMzLgxPr?=
 =?us-ascii?Q?9JyM2sO1kS580Q0R1KwuLEU3MwIJ0keS+BbZNQD9o9lcI1es1dIkt6dl7qg1?=
 =?us-ascii?Q?EUE6r3ab2K6FaIQOegnhCW04VUwp0EZhoJs72IHEEID2Zpe1OKv6zbMrioat?=
 =?us-ascii?Q?01N3JV+Vn3qDD6fut7Y4MTKSp++eXk8IXVEyZioIRoSfKHVM6ZMbapj/mVS/?=
 =?us-ascii?Q?zxmXaUGaIQVLRKGjLZkfjcQu8Iagd8pyl9k60UgXh5B8okdFBVUtlvWg8Cbt?=
 =?us-ascii?Q?qMFQ++MyKDkxSwJAqA4e1hm6vcqXIuoUPfjEp7zI19v2Tpp/C5q51Zjo7DV5?=
 =?us-ascii?Q?V/Dbb/d+/wB/OOiMt2ePwZEzUv9qTWk3cfh6VCgz65DWvznqC5HFhON5YjCm?=
 =?us-ascii?Q?qikcAzJjLRs8CDXNBROvW7I=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB7765.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2201e747-e00c-41b9-7376-08dc01f000fc
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2023 06:42:30.0015
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2RERf/Qdbbi84qoLm3NpmSDo0L7g0VtxsYAH7Z9OprH9XKRfPCicw1lB/CXVEmQ7LngqXqOQfpTpLJfwafAF+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7868

> > On Thu, Dec 07, 2023 at 10:31:26AM -0600, Rob Herring wrote:
> > > There is no reason CDX needs to depend on ARM64 other than limiting
> > > visibility. So let's also enable building with COMPILE_TEST.
> > >
> > > The CONFIG_OF dependency is redundant as ARM64 always enables it and
> all
> > > the DT functions have empty stubs.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > >  drivers/cdx/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
> > > index a08958485e31..7cdb7c414453 100644
> > > --- a/drivers/cdx/Kconfig
> > > +++ b/drivers/cdx/Kconfig
> > > @@ -7,7 +7,7 @@
> > >
> > >  config CDX_BUS
> > >  	bool "CDX Bus driver"
> > > -	depends on OF && ARM64
> > > +	depends on ARM64 || COMPILE_TEST
> >
> > Ok, good start, now we need to turn this into a module, what's keeping
> > it from being able to be built as a tristate?
>=20
> To answer my own question, the following errors:
>=20
> ERROR: modpost: missing MODULE_LICENSE() in drivers/cdx/cdx.o
> ERROR: modpost: "iommu_device_unuse_default_domain"
> [drivers/cdx/cdx.ko] undefined!
> ERROR: modpost: "iommu_device_use_default_domain" [drivers/cdx/cdx.ko]
> undefined!
>=20
> Would be great for someone to fix this up...

I did look at this code. There are 2 issues here for it to be a module.
1. There are many symbols in iommu, msi and other module which are not expo=
rted.
Most of other busses like amba, fslmc, pci are bool only.
2. As of now, iommu has static list on bus types (static struct bus_type * =
const iommu_buses[])
 which is initializes the notifier at init time. So, if we change cdx bus t=
o be a module
cdx devices would miss these mappings.

Thanks,
Abhijit