Received-SPF: pass (google.com: domain of linux-kernel+bounces-7909-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 21 Dec 2023 13:57:37 +0700
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Max Kellermann <max.kellermann@ionos.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org
Subject: Re: [PATCH v2 2/2] fs/kernfs/dir: obey S_ISGID
Message-ID: <ZYPh4T21-6DAbxq5@archie.me>
References: <20231208093310.297233-1-max.kellermann@ionos.com>
 <20231208093310.297233-2-max.kellermann@ionos.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cWO6PprgJ1tduci0"
Content-Disposition: inline
In-Reply-To: <20231208093310.297233-2-max.kellermann@ionos.com>


--cWO6PprgJ1tduci0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 08, 2023 at 10:33:10AM +0100, Max Kellermann wrote:
> Handling of S_ISGID is usually done by inode_init_owner() in all other
> filesystems, but kernfs doesn't use that function.  In kernfs, struct
> kernfs_node is the primary data structure, and struct inode is only
> created from it on demand.  Therefore, inode_init_owner() can't be
> used and we need to imitate its behavior.
>=20
> S_ISGID support is useful for the cgroup filesystem; it allows
> subtrees managed by an unprivileged process to retain a certain owner
> gid, which then enables sharing access to the subtree with another
> unprivileged process.
>=20
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> Acked-by: Tejun Heo <tj@kernel.org>
> --
> v1 -> v2: minor coding style fix (comment)
> ---
>  fs/kernfs/dir.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>=20
> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
> index 8b2bd65d70e7..62d39ecf0a46 100644
> --- a/fs/kernfs/dir.c
> +++ b/fs/kernfs/dir.c
> @@ -676,6 +676,18 @@ struct kernfs_node *kernfs_new_node(struct kernfs_no=
de *parent,
>  {
>  	struct kernfs_node *kn;
> =20
> +	if (parent->mode & S_ISGID) {
> +		/* this code block imitates inode_init_owner() for
> +		 * kernfs
> +		 */
> +
> +		if (parent->iattr)
> +			gid =3D parent->iattr->ia_gid;
> +
> +		if (flags & KERNFS_DIR)
> +			mode |=3D S_ISGID;
> +	}
> +
>  	kn =3D __kernfs_new_node(kernfs_root(parent), parent,
>  			       name, mode, uid, gid, flags);
>  	if (kn) {

No noticeable regressions with this patch applied.

Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>

--=20
An old man doll... just what I always wanted! - Clara

--cWO6PprgJ1tduci0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZYPh4QAKCRD2uYlJVVFO
o26ZAP4r4J3I/Nd9h7weNBy5Qw8g6Kgy2tV9RcfYL4qS36KoeQEA3T33VwzqzLb0
gitkBNYZ6MQltYWRNtkpj0zs3bzuyg4=
=eiS0
-----END PGP SIGNATURE-----

--cWO6PprgJ1tduci0--