Received-SPF: pass (google.com: domain of linux-kernel+bounces-7956-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 21 Dec 2023 18:38:03 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Changbin Du <changbin.du@huawei.com>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the mm tree
Message-ID: <20231221183803.1dd342aa@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/xEm.X/IOObuScyjXp_MmcFp";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/xEm.X/IOObuScyjXp_MmcFp
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the mm tree, today's linux-next build (x86_64 allnoconfig)
failed like this:

x86_64-linux-gnu-ld: init/main.o: in function `kernel_init':
main.c:(.ref.text+0xbf): undefined reference to `flush_module_init_free_wor=
k'

Caused by commit

  1d8053432676 ("modules: wait do_free_init correctly")

This build has
# CONFIG_MODULES is not set

I have applied this (hack) patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 21 Dec 2023 18:27:07 +1100
Subject: [PATCH] fix up for "modules: wait do_free_init correctly"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 init/main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/init/main.c b/init/main.c
index f0b7e21ac67f..1df1106ff09b 100644
--- a/init/main.c
+++ b/init/main.c
@@ -1407,7 +1407,9 @@ static void mark_readonly(void)
 		 * flushed so that we don't hit false positives looking for
 		 * insecure pages which are W+X.
 		 */
+#ifdef CONFIG_MODULES
 		flush_module_init_free_work();
+#endif
 		mark_rodata_ro();
 		rodata_test();
 	} else
--=20
2.43.0

--=20
Cheers,
Stephen Rothwell

--Sig_/xEm.X/IOObuScyjXp_MmcFp
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmWD61sACgkQAVBC80lX
0GwPDQgAoPFlJXY0V0LvRX3MpnC0ypEcjyR9cT0uEkps5/PzVwDkEzZt9Br2d0tw
xGiSHsR8uJfrP8Ix312iGEBQJHkJ8p216U7QkOyY4VTYQxugJre3tpxzsvbq5sGn
T8FTCSNhemny3v3Sgh5WtBWDBForPeWdpT3+d9wFLftfWMx0otuHl9X5TFDjXPzF
sO1irD6mSYTfFzxRC7vjet/ez4S7vkCRJPbWDP2aBfJfY7k8m/NlJl9bVapltN3t
VPK1OYD0hjHyUU4+5wwNEf0ONy8Obk99JQU3jwmgCiicPoRfJBj0ftMqgSDeXAgn
6AVOyuSKmE/xaat7YJNZfVWMfO8jtg==
=nce+
-----END PGP SIGNATURE-----

--Sig_/xEm.X/IOObuScyjXp_MmcFp--