Received-SPF: pass (google.com: domain of linux-kernel+bounces-7977-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 21 Dec 2023 09:08:54 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Guanghui Feng <guanghuifeng@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com
Subject: Re: [PATCH] uio: Fix use-after-free in uio_open
Message-ID: <2023122115-strewn-unsigned-b3e5@gregkh>
References: <1703132808-14322-1-git-send-email-guanghuifeng@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1703132808-14322-1-git-send-email-guanghuifeng@linux.alibaba.com>

On Thu, Dec 21, 2023 at 12:26:48PM +0800, Guanghui Feng wrote:
> core-1					core-2
> -------------------------------------------------------------
> uio_unregister_device			uio_open
> 					idev = idr_find()
> device_unregister(&idev->dev)
> put_device(&idev->dev)
> uio_device_release
> 					get_device(&idev->dev)
> kfree(idev)
> uio_free_minor(minor)
> 					uio_release
> 					put_device(&idev->dev)
> 					kfree(idev)
> -------------------------------------------------------------
> 
> In the core-1 uio_unregister_device(), the device_unregister will kfree idev
> when the idev->dev kobject ref is one. But after core-1 device_unregister,
> put_device and before doing kfree, the core-2 may get_device. Then:
> 1. After core-1 kfree idev, the core-2 will do use-after-free for idev.
> 2. When core-2 do uio_release and put_device, the idev will be double freed.
> 
> To address this issue, we can get idev atomic & inc idev reference with minor_lock.

Nit, can you wrap your lines at 72 columns?

Anyway, nice fix, how did you find this?

> Signed-off-by: Guanghui Feng <guanghuifeng@linux.alibaba.com>

What commit id does this fix?

thanks,

greg k-h