Received: by 2002:ac8:4f0c:0:b0:427:7d78:cd45 with SMTP id b12csp235892qte; Thu, 21 Dec 2023 00:14:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSol1+58ohSTR3su9Zd3fFqWbZwJhkCxvQ9kF/yzvcfnbQKjE0gce/aZVorIp7LBtnfiRU X-Received: by 2002:a17:902:daca:b0:1d3:dce0:ab19 with SMTP id q10-20020a170902daca00b001d3dce0ab19mr3267235plx.108.1703146495683; Thu, 21 Dec 2023 00:14:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703146495; cv=none; d=google.com; s=arc-20160816; b=y3zASC3aZDlk9NVmUJxC/fRGiXs1jnRnYM/9Jcrqusn3sfVc6HrDDBPKxM5nclMlnV D2DtX/FMaCX2wRgZ9ZEXuzQwHIvbNsYlL+R2OZT/YJV+BZLxkUpjnoQlDkpYEU5X46un pcFuTFxaIAVjiKpcUY5a5+behjo9hWKuV9tyuudX7ViTtKfJRXRaWTADIhQaWBC0DuEb wLtrao7DIbdv8DcQOvwc7Sdl15b1088H/SS8rGnTudB1y0ZXkLVRYr/w9IKgZD0U81Xa DyoeTmhrjZDcItt9dMeaq2cxUgHMBSktQCgOWcj/RR3cD5PLZ7iKDF1F0rnOS5zod+Lr SReg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=CFiIVy5eub4bZACFCmk9Dc5sqachQ3QbkbfYt+THpVo=; fh=UybPpJWcXW3la4AUSNcOqS721M7Vmps5FQgss9d0Y5s=; b=RHNCbTx73fs1Mzc1JxpGy2Ck1w7FOqPYuhJ0B2ThygHA6usUqFKGA8C9gY0lI0fiAf lwbqv9mYlF/rhayYtCbAvQgSrGmASqtXZKZ394F8pMqvx1k84QyEqdJxZCnw9QxoI+Iq Ignm6n93XmS1/XU0i20IhLph/+BJvR6ZcbrrWAa80+jkRGEvK5I90B3T8s16SwhCM9TY tFJZlm43fpu4zxDBWyRCHDtCWZVJZSH2I0cJ6FSQIcv+pE3AlrHP3TfETx9iymyQ6epm jKQbrtuCCuwrLN47o0ilAYdCcyrDdu9JDKelY1lPWB6avEL2uTJlPb6UtyH6m7xxnshg 5JXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VEdOmYJg; spf=pass (google.com: domain of linux-kernel+bounces-7983-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7983-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b2-20020a170902d30200b001d3974a7261si1086011plc.283.2023.12.21.00.14.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 00:14:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7983-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VEdOmYJg; spf=pass (google.com: domain of linux-kernel+bounces-7983-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7983-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 544EF282545 for ; Thu, 21 Dec 2023 08:14:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A2C415AFC; Thu, 21 Dec 2023 08:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VEdOmYJg" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AA7615AD5 for ; Thu, 21 Dec 2023 08:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a2699ee30d1so38903566b.2 for ; Thu, 21 Dec 2023 00:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703146484; x=1703751284; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CFiIVy5eub4bZACFCmk9Dc5sqachQ3QbkbfYt+THpVo=; b=VEdOmYJghcrU+5Ktv1OoNK2A/L4yUiQcI4HS9W3kuIBTwwvc9rDduzp4vKjI5EaQfx Af6T7c3d2gAHWVi0Qk4WHxL49PGF5jRIkItqiyozcutJyRaNX2d4IGC+XDnX7n/V+l4z eXnWD4rlDZmE9YCmfrarm4DY5S985rqygmL2hK4BgLfUscqUieW5q5yL4orJl44V1ICl Oxs1OGpGDxBTZnjXDjjEMaGvX/dSZFpPuWIl/3SDp/OBel23OyMb2C8MbzVIz53iqwbH mc24wcIe2VcyT/X3gciEs0AEULDLACSfl2IOTPRzfywmljZ1Jg42hH5z4DIYMmP8Jn+b wKYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703146484; x=1703751284; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CFiIVy5eub4bZACFCmk9Dc5sqachQ3QbkbfYt+THpVo=; b=xUOuAo1WEQGv74JKjIXEdelP6pDrP+enhbafog92etjGPtIn2cBREIEXBHPx1omYZk QKfpjp7SXG8mtWsHcE9wz42abCn/C4jrqN8AUD5CZGIlZWPwH3F+M5thdxr7YnMV7E45 cWDZcejJ+9JuBjAClcikpkNJgfP6BuCFWjsTfd2VenamVHPEP2Ay08sge/Muo+w8hM3f PuHb4Gu/oyfCE9bI7KHab45/mIKlG8CJM3WAIxcU4p0+5OThfBHnIaHHMMYAU8AHYvQY G9wwVLe/m5Vk/wDy8fVpbscKgZ/E/bk/vFCfnyGTKFDsoHnwtpOtQU2iQIo5c28pLJdH bqCw== X-Gm-Message-State: AOJu0YwXQoincTXYY/0KkwEHy5s9B+1OSTrjQsoYt+SREO/ICfenx7yc Vedp5aZJwKhUPkWFYShoQyCLaA== X-Received: by 2002:a17:906:5205:b0:a23:58e5:da9e with SMTP id g5-20020a170906520500b00a2358e5da9emr3076014ejm.36.1703146484403; Thu, 21 Dec 2023 00:14:44 -0800 (PST) Received: from [192.168.0.22] ([78.10.206.178]) by smtp.gmail.com with ESMTPSA id dt6-20020a170906b78600b00a2699f9d5b1sm677712ejb.177.2023.12.21.00.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 00:14:43 -0800 (PST) Message-ID: <7199b7b7-238e-45de-96f1-0f04d0fa718d@linaro.org> Date: Thu, 21 Dec 2023 09:14:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/22] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source Content-Language: en-US To: Mark Hasemeyer , LKML Cc: AngeloGioacchino Del Regno , Tzung-Bi Shih , Raul Rangel , Konrad Dybcio , Andy Shevchenko , Rob Herring , Sudeep Holla , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20231220235459.2965548-1-markhas@chromium.org> <20231220165423.v2.6.I06b059021de1bf6103e60a73211f078f2af75d17@changeid> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231220165423.v2.6.I06b059021de1bf6103e60a73211f078f2af75d17@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/12/2023 00:54, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. > > Add the wakeup-source property to all cros-ec-spi compatible device > nodes to match expected behavior. > You do not need this property, if driver assumes that. Just enable it unconditionally. I don't think anything from previous discussion was resolved. Best regards, Krzysztof