Received-SPF: pass (google.com: domain of linux-kernel+bounces-8006-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <cc07eae78c07e09e378cf37494b0f973905130ff.camel@ljones.dev>
Subject: Re: [PATCH v1 2/7] ALSA: hda: cs35l41: Support additional ASUS ROG
 2023 models
From: Luke Jones <luke@ljones.dev>
To: Stefan Binding <sbinding@opensource.cirrus.com>, Jaroslav Kysela
	 <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, 
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Date: Thu, 21 Dec 2023 21:41:26 +1300
In-Reply-To: <20231218151221.388745-3-sbinding@opensource.cirrus.com>
References: <20231218151221.388745-1-sbinding@opensource.cirrus.com>
	 <20231218151221.388745-3-sbinding@opensource.cirrus.com>
Autocrypt: addr=luke@ljones.dev; prefer-encrypt=mutual;
 keydata=mQENBGRG7LwBCADC4B1XNMyJpOmtXVhN12glMXTVTV9RxgqunqQt7g+3RAG8kfYcAE+VnCUbcdtjeLRYhVka1zE86VBp0cyXiG9IYNlGZhtBFeik5NdgFt2fBXhDV3fm+91ARLvW7iOxHepyG+jepFf18oI6mPXC7cBzysosEkzdHl0Rm5z9rUoXksVzlT3i76s1AfQL3empFKbKkwSZsMVY/MLzWjPjVloMPqxfwpCex6PHnHfZ37VabsI3CG5Whmo3B+kFvpAYvCZZKYTjGDuFfFEH5Ba6FeY0xNSJYGyvuE8LY1VehipZtEaqnxiNP7kU0t5ZTX7nfDbi9a7uaqqHdPAJDCitJPhTABEBAAG0HEx1a2UgSm9uZXMgPGx1a2VAbGpvbmVzLmRldj6JAVEEEwEIADsWIQRZERbOg6XlNi+ijnEwmht7rUENtAUCZEbsvAIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgAAKCRAwmht7rUENtGoxB/wNh2J4t/Scb94yAUNGXje65tuC9ej+XHtfeDCKhQW0WchSDaXpZHLn47b9o+nBaICIaa1WR29viPNAk4Ss7k0lx5w7A/vSYrGcpO69DLWwMhqk+pVn+RPfeuGKwxGhvEjZkWSwIYXtBDfVXM7Paiq6ZOiaYOlFokbvV1s1NfIaxkTdJwuFK14SYfn3CE1XdyUQ2EQ9572yATPwElcaNp9qXo/UE/yjub7VAkFhg+EI9sXXV0pi+TKWKrF0htpmjoHBzzRz4MdqhE3C6lj8aIrfmRg3lWxUpdYbTVVQvfp0PCWCnXq6y+02QU1RG/WgwHOohDVWr+y5BhzSMX+kP5LsuQENBGRG7LwBCADVsGLOw5YmYJXZQ8FWfwWmHJ6dalWsjI4S6ktBZ+u7gFXJwHbzYw3AYzTrWiBUU+ii0lUtVEQRfh4VeMrO/iufxGMwjquedZeZNzxU/nysEoh+D9cGwgPff
	RWhMBuktASgwULSyaR095YPslFfU0w/iZtoz3uM3YYedFGXyrydb2ZUv+i88LUKiY5qK+4HqaG6wsaS0Bx8vKymmVMSbZi/PWYHS5w+w5q71Z9fNRdF3MTMPIVvFH6mH1AULh6hRK/vH0UMEc2tN93szVupFvLBJVxf2doHjGNzvrytq0nTrRnl7jJspehC29cDKtJ6DtKmaw470bhClgAlE085UhuzABEBAAGJATYEGAEIACAWIQRZERbOg6XlNi+ijnEwmht7rUENtAUCZEbsvAIbDAAKCRAwmht7rUENtKM8B/9UyyyRA6/NQx2xzEibKxyYhHfP3OCPCbnFAyWT0TWF7OVSQg/Hc6PnrhDVUXLyrSxkXUaRtmxjxqhphhODH62jGrCn4nciczcrVwswFP53CMRQXdlpyW72LZ3wSo1XK1twWqFP48L+l00ZEbP3NXYk2rbuNKbyB6SBlmYZu+L6mEfZ+/eAoAgh9+ZCthNg+RsSwqfYwoO+bZXCjuWzLX2Tljg2yYhg+f9TotR6cW+sbcWi5cqjDmezsV0TIkE3FK9LN5Kzc8gUI/jSDSrW6rf72KTw7RgGdywW2VaA/XKz6GkaGReHeoZAetK9/2jxL6xQwDzr5gLUEuTBXG2lJ79O
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 (by Flathub.org) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-12-18 at 15:12 +0000, Stefan Binding wrote:
> Add new model entries into configuration table.
>=20
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
> =C2=A0sound/pci/hda/cs35l41_hda_property.c | 36
> ++++++++++++++++++++++++++++
> =C2=A01 file changed, 36 insertions(+)
>=20
> diff --git a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> index f90423ded85d..a0d808ed640a 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -42,6 +42,24 @@ static const struct cs35l41_config
> cs35l41_config_table[] =3D {
> =C2=A0 * in the ACPI. The Reset GPIO is also valid, so we can use the
> Reset defined in _DSD.
> =C2=A0 */
> =C2=A0	{ "103C89C6", SPI, 2, INTERNAL, { CS35L41_RIGHT,
> CS35L41_LEFT, 0, 0 }, -1, -1, -1, 1000, 4500, 24 },
> +	{ "10431433", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> +	{ "10431463", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> +	{ "10431473", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> +	{ "10431483", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> +	{ "10431493", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "104314D3", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "104314E3", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> +	{ "10431503", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> +	{ "10431533", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> +	{ "10431573", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "10431663", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
> +	{ "104317F3", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> +	{ "10431C9F", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "10431CAF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "10431CCF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "10431CDF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "10431CEF", SPI, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
> +	{ "10431D1F", I2C, 2, INTERNAL, { CS35L41_LEFT,
> CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
> =C2=A0	{}
> =C2=A0};
> =C2=A0

Very good to see this work done. I have tested on 3 models and each one
has very good sound now. Many thanks!

> @@ -316,6 +334,24 @@ static const struct cs35l41_prop_model
> cs35l41_prop_model_table[] =3D {
> =C2=A0	{ "CLSA0100", NULL, lenovo_legion_no_acpi },
> =C2=A0	{ "CLSA0101", NULL, lenovo_legion_no_acpi },
> =C2=A0	{ "CSC3551", "103C89C6", generic_dsd_config },
> +	{ "CSC3551", "10431433", generic_dsd_config },
> +	{ "CSC3551", "10431463", generic_dsd_config },
> +	{ "CSC3551", "10431473", generic_dsd_config },
> +	{ "CSC3551", "10431483", generic_dsd_config },
> +	{ "CSC3551", "10431493", generic_dsd_config },
> +	{ "CSC3551", "104314D3", generic_dsd_config },
> +	{ "CSC3551", "104314E3", generic_dsd_config },
> +	{ "CSC3551", "10431503", generic_dsd_config },
> +	{ "CSC3551", "10431533", generic_dsd_config },
> +	{ "CSC3551", "10431573", generic_dsd_config },
> +	{ "CSC3551", "10431663", generic_dsd_config },
> +	{ "CSC3551", "104317F3", generic_dsd_config },
> +	{ "CSC3551", "10431C9F", generic_dsd_config },
> +	{ "CSC3551", "10431CAF", generic_dsd_config },
> +	{ "CSC3551", "10431CCF", generic_dsd_config },
> +	{ "CSC3551", "10431CDF", generic_dsd_config },
> +	{ "CSC3551", "10431CEF", generic_dsd_config },
> +	{ "CSC3551", "10431D1F", generic_dsd_config },
> =C2=A0	{}
> =C2=A0};
> =C2=A0