Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp13872rdb; Thu, 21 Dec 2023 01:03:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFu1G8IVhCLv6VBSxuPektWvnwL6gjGlcmdPBVm4nikGXwyMcxWxAg4RbyKe8H/DN/rQcew X-Received: by 2002:a17:906:100e:b0:a23:5fc2:86e4 with SMTP id 14-20020a170906100e00b00a235fc286e4mr842263ejm.105.1703149415464; Thu, 21 Dec 2023 01:03:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703149415; cv=none; d=google.com; s=arc-20160816; b=EAB+WGV/gAqQr088KrMwiEIQuSajtAm0nBzEqZF7wUibiBQW8u1wxgE3KKiyhLz0AY XdhGF+81V6wIFp3fLKWzXogZNVMyFp4fkE9CyJTjpMgoIkeTzxfboJDiaXkqmEVrAVLL hnXrS7Bwu6qY7gQM1W/ZEejy4Srt72A6ZVHEXac7pfxyuVums78JWIFuuZdNhYCzQ+HE ojdVC/9VzCNSdPANnrZxraqYt2h1yURbC625Uatf1mpAZdrRBbPYD03sSvDkzj1iybCO t8tE6A+I31EaEgY2WyaidCu1tJkb0coi3f2ItGhubI+pqRRIYah9/NvHt1XZ2a/FkBry 9wBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=dXKltguW8Bo+ic1vfK+aaYUnXCLYKLNPLMHZuSFYx4g=; fh=K8MatwUBwFVfpAS9GM38PurLgIUHMlAOM4gUHNrnizY=; b=tPnJ480RbyqFBNj+mTtL/LMtngMMATeWBvDMt3zgHhKo+Jrv7IFhr63wsAIPp52SCd 22XA0LUcMQb3pGaqV8GaLcWyAO2asCpNirFkUkZDucoeulNg5DKDH9HFFHPOlIiHUjPr +YudXAKlYnPu6GiFKbhFTQJnsylUgF975gy2v3nKR7z/1ZchZyZRPRJe9Zu+LM4GduvB cfdgv6/Da3cpeNOyotAdKZA8Mn6bpaaIkIj0ev/IJE0t7CnDpxy3Jl87jYm/AqSO7Z1r 23+QXkzFoU9yepNdts7Z4oL8nE7IbuX+l27ndX7SMLRw7Gg0yue4xNds+4GeZZXZaQcB zDTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-8041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8041-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gi20-20020a1709070c9400b00a26a5213f00si419866ejc.669.2023.12.21.01.03.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 01:03:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-8041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8041-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3ADC51F2106D for ; Thu, 21 Dec 2023 09:03:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2440F4E1D2; Thu, 21 Dec 2023 08:59:30 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D774C62B for ; Thu, 21 Dec 2023 08:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=astralinux.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=astralinux.ru Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id B9A791868C8B; Thu, 21 Dec 2023 11:59:22 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id awnM1zYKUyd1; Thu, 21 Dec 2023 11:59:22 +0300 (MSK) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 6FFDB1866581; Thu, 21 Dec 2023 11:59:22 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mU5WqeFFNcR2; Thu, 21 Dec 2023 11:59:22 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.20.25]) by mail.astralinux.ru (Postfix) with ESMTPSA id 93F8A1862935; Thu, 21 Dec 2023 11:59:21 +0300 (MSK) From: Anastasia Belova To: David Howells Cc: Anastasia Belova , Marc Dionne , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] afs: remove redundant overwriting of ret Date: Thu, 21 Dec 2023 11:58:49 +0300 Message-Id: <20231221085849.1463-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ret is the result of dns lookup. There are several ways to handle different errors (described by switch). So it is necessary to keep the return value of afs_dns_query. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d5c32c89b208 ("afs: Fix cell DNS lookup") Signed-off-by: Anastasia Belova --- fs/afs/cell.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/afs/cell.c b/fs/afs/cell.c index 988c2ac7cece..9a112e03bee1 100644 --- a/fs/afs/cell.c +++ b/fs/afs/cell.c @@ -409,7 +409,6 @@ static int afs_update_cell(struct afs_cell *cell) if (ret =3D=3D -ENOMEM) goto out_wake; =20 - ret =3D -ENOMEM; vllist =3D afs_alloc_vlserver_list(0); if (!vllist) goto out_wake; --=20 2.30.2