Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp24390rdb; Thu, 21 Dec 2023 01:28:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYP+NWMglZX5eZU31sKOJSScmKltMfIieZy1m82DudGqBHS9JBtQeHypI1ND/k9j4Nv5Ff X-Received: by 2002:a05:6214:ca6:b0:67f:2df3:bd69 with SMTP id s6-20020a0562140ca600b0067f2df3bd69mr15752474qvs.34.1703150893444; Thu, 21 Dec 2023 01:28:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703150893; cv=none; d=google.com; s=arc-20160816; b=0QIwEAldFxmsw4TdEQizvk/oEZAF3nGQZZPYmEXRwvl/GwWDdKLXF63MQtKamK1noH 53+tq9uUZitGNnHfloqLE9nbxU61TdQ8uQTp7qG9PZBmdRkx77wS1pL5P7fpCKtuJZq8 +6U+/rZ1+Y4gIh8JbSVSfOBnRUxedDhcGBEzEyt5z+pUBL5GfYSW5eDAw66r88F5o7J2 lQ+0McZHDMHSJdHw4Yg8Hf7ojC1DmSJAj254icUATh5mIDgQd7it6Zeo0Rzcu4N98jQ3 +X4Sanw8Xik+Qa6KlPEcCHqCS6gR3WVnUy6a0ylnRO7eIdAjDCGMZduSywrn3bpjUmu0 9WcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bhUM1XijalfIIIJGc6XtFDdiTTA83ZKMMJW0N2PSJ5E=; fh=TRy64bKZ+8XqCRfJ8QXDt9jWyFe91LCKJQSVKlvU9Tg=; b=LRTtAgdLPc7Y1Z7cHwT4BnAwIPOONTL1rw9z+8ET7EMH2PT8O6mdxFpIko5qCvQUDh JViclVk5Gkf8jN+VfCE5j6OWOOsHs2vW+FYDtirwVpfQUYt8Bn2cEfppwTQDFQrY2fjr ZMLu8XvbHbsaD4UlPhR8UvLFi8yNl2fP0nuYGkka/WjZl/ExxQvmJ7GO89Zgg0PJp9Rk EFbtjpsVyWqSEYUUiviM2y/jqxtekDlJ+qhhvxNedFpntYxnu+QWthRPSwn9nwA+exuf XekicTucCCAW5vJSVzV9cTTfbdWybbdgWfYq5n3bhCSWtDxhnolkfPFmEN6knFHqmC2l /Vrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=peRf5dwv; spf=pass (google.com: domain of linux-kernel+bounces-8109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8109-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n16-20020a0ce490000000b0067f14fd093fsi1768338qvl.538.2023.12.21.01.28.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 01:28:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=peRf5dwv; spf=pass (google.com: domain of linux-kernel+bounces-8109-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8109-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 30A991C248DB for ; Thu, 21 Dec 2023 09:28:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 40781219FB; Thu, 21 Dec 2023 09:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="peRf5dwv" X-Original-To: linux-kernel@vger.kernel.org Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35768219E4; Thu, 21 Dec 2023 09:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=bhUM1XijalfIIIJGc6XtFDdiTTA83ZKMMJW0N2PSJ5E=; b=peRf5dwvFRD8WvXs6Z1Jv+lm33 2s6gLOzX6ieSPJym3uodnNNcv5tgAS1xPHktD36vAWi8AzYsHtBx/GWobLW2AUJtOGoScRGqdRsKW 5n5opFOfsR1jZtcpvqnrBnBctByjfZi2wcV35PUV3pyOukIZYFlRb/KhLAPpGKryXsp8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rGFGJ-003Udl-8V; Thu, 21 Dec 2023 10:22:39 +0100 Date: Thu, 21 Dec 2023 10:22:39 +0100 From: Andrew Lunn To: "Gan, Yi Fang" Cc: Greg Kroah-Hartman , Andrew Halaney , Javier Martinez Canillas , John Stultz , "Rafael J . Wysocki" , Jens Axboe , Russell King , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?iso-8859-1?Q?Beh=FAn?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Voon Weifeng , Song Yoong Siang , Lai Peter Jun Ann , Choong Yong Liang Subject: Re: [PATCH net v2 2/2] net: phylink: Add module_exit_stub() Message-ID: <0f85171e-cb9c-47dd-bb7d-f58537e24a54@lunn.ch> References: <20231221085109.2830794-1-yi.fang.gan@intel.com> <20231221085109.2830794-3-yi.fang.gan@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221085109.2830794-3-yi.fang.gan@intel.com> On Thu, Dec 21, 2023 at 04:51:09PM +0800, Gan, Yi Fang wrote: > In delete_module(), if mod->init callback is defined but mod->exit > callback is not defined, it will assume the module cannot be removed > and return EBUSY. The module_exit() is missing from current phylink > module drive causing failure while unloading it. You are missing justification it is actually safe to remove phylink. Maybe Russell King deliberately did not implement module_exit() because it can explode in interesting ways if it was? Andrew