Received-SPF: pass (google.com: domain of linux-kernel+bounces-8138-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <257c694f-5aa2-c29b-891d-3a1f480dd4a1@amd.com>
Date: Thu, 21 Dec 2023 15:01:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [Patch v2 2/2] thunderbolt: Teardown tunnels and reset downstream
 ports created by boot firmware
Content-Language: en-US
From: Sanath S <sanaths2@amd.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Sanath S <Sanath.S@amd.com>, mario.limonciello@amd.com,
 andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com,
 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231218104234.GB1074920@black.fi.intel.com>
 <c433f29b-597c-b6d6-aa48-2b84a26dc623@amd.com>
 <20231218113151.GC1074920@black.fi.intel.com>
 <20231218122312.GE1074920@black.fi.intel.com>
 <997f2a94-66d9-fb95-8f75-46d61937f7e8@amd.com>
 <20231218131840.GH1074920@black.fi.intel.com>
 <0fd5c09f-1cf2-8813-a8f9-1bd856e3a298@amd.com>
 <20231219122634.GJ1074920@black.fi.intel.com>
 <0816caa4-81b5-d0f9-2305-80c7fec6abb9@amd.com>
 <20231219180424.GL1074920@black.fi.intel.com>
 <20231220125857.GA2543524@black.fi.intel.com>
 <5bfaa405-b15e-36ef-a4e0-04b93dd983b1@amd.com>
In-Reply-To: <5bfaa405-b15e-36ef-a4e0-04b93dd983b1@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MFlQYStDbkd2ZzEyNnB5K21xdVhwNmp1Y3lCSnFiMFlVd240Qml0RkJjMFlt?=
 =?utf-8?B?SjZrbDhkV1UvUUU1NWFiRllzN1ZSMU54YzhOVUpCaS9UTnlMbUMrTUlJZWcx?=
 =?utf-8?B?WmRMd3BWakQ1dzNlRUJ6b25yWVczdmI4THhBNnZ3SXBsejdWRm1wK0RuRVdT?=
 =?utf-8?B?cVlkejViQlB2YWZRTDZ1NUZMRUlFRUsvZnU2cUthdy9pbFdzYlVyc2VZZUQy?=
 =?utf-8?B?ZEpJRG9Lbk5PRnJHWE02QkJkM1Q2M3llZUtFSEZLT25PYWVFeE1mTmQ2N285?=
 =?utf-8?B?alhpSmcxRld3eDZXaGtHYmwxUVJKckRIeUZlazdNcVJ0b01wa2FYaWVrUm5L?=
 =?utf-8?B?OTFaY3lxb3hDVEg1eEs2Z2ptS01uanorNDl6cHJDbWdPUU5xVjVYSnREWnZv?=
 =?utf-8?B?RjJpMFBlZE1MbXhUV3pCRGJvNWs0T2lDdWZlWFJnVU1pTWx2Ujg0ZnZrbzJ5?=
 =?utf-8?B?TUJFbUJWMm1OWFp4TUJVcmp6V0pzRjZidEloTmlXL01EbjRhcXQ2aU9Kcnd2?=
 =?utf-8?B?ZVRiVjZ4U0ZIZWwzcmlQbVhxM3hYa0tkL1QzdnoyWTFjN1dTcFN4aXVMeUVH?=
 =?utf-8?B?SXlkenRSVy91aGJtQ1VFVkl2YXhuYlNQZDBTZzU4andkd2NQdTVOamEzamZV?=
 =?utf-8?B?MTZ4TGM4S015cnZiL3pST2V1M2tCMjlCMVpJTlRWWUZ5aytmeWVuOUdsNWRv?=
 =?utf-8?B?amxtZDBMb0NnZEh0V1dsM1M4a2NPTUVSZ1kzYU8yKzF6RUtzekZrQm9PRHNM?=
 =?utf-8?B?VzFISXpHcWZCREFKNVpxU0NCRUpQdGY4Q2tUbDd6TVBQZmgyZWpjT0ZhaFVE?=
 =?utf-8?B?eFJKZWQ2eXNGRUlENEZhTTc0NmRnUmxnanZsalkyR1hmWDJmVUJWOEliVVpa?=
 =?utf-8?B?YjdPN3p1MjNwS0RWa3JMckNXSWpBSTc5Y1o2TUtveW1DaUNFalVudjI5UXNF?=
 =?utf-8?B?NmNOWHV5dEdiWTN2Z0FucVNMUjZHMVNMb1BqdWhEdUFWUlZoeTFkT1JNT3Yx?=
 =?utf-8?B?MHlOOUx2YUVPSTJKZEN4dVFEOEpvRjlCUWpMYmVQNlF4YzBjN0xCTWFaVWhn?=
 =?utf-8?B?VEFiWm15Vzg3RDVlWi9OS244M1pWMjNNeWd2d2ZrUldaU29SVVo0R2lCOUgy?=
 =?utf-8?B?d1k2VUYvNjVGVVhGSEtPenRlMWJ2c0FITFgrQitMalk3dnVObGQ3b2FvL2Yv?=
 =?utf-8?B?OGJkMWtFaDFzZ3JQREloUWlXZFhDYU5lQllFQlVKbUY5c3pCNEpCaE9qWEVP?=
 =?utf-8?B?NGtMeWprbitzaE43MjBnbjQycUI1eitQQldRdFdTbE9QbXd1RE0zRU1qTWJO?=
 =?utf-8?B?cFVIOXk0LzE0NTQ4NDRPeTZxMHh1QzlNdDlVSVpqUmFjMStPeEdId0F2N0xF?=
 =?utf-8?B?eGNYQnpkbFV3RC9PQWQ0MS9nUktOSXVLeThtcjA0NEJGWDdsWmkyeG9rT1du?=
 =?utf-8?B?OFBYMXBpaEJuSWhSTEZUQndLbUxWK254NzNqVUd4YkNQRHB5ckNpd0dQTW9q?=
 =?utf-8?B?R0VpNzJxa0lOUXBoWFJwTjVBZzhaUXgzZW1ldEtTSVBVVzYzQ3BUNDdDbVNn?=
 =?utf-8?B?dlFyOGhwS1kzU0g2aFAyanl6Zlh4YVZrQk9xZlZ2bUFCcGNSV2RwdjE0NkUv?=
 =?utf-8?B?S1hhcEVNY2d5TTdxd0ZTSUFlVlJEVVlOK3phNjNldWZYN2NQUkxJVmRiTDRJ?=
 =?utf-8?B?VklZY2ZBS2IwN1lsRVFCN3h5a2J6Y2EralpwRVpQUE9pYzhONmZjaFNpN29a?=
 =?utf-8?B?eFNuVXFUa3B3cWFuTXNwbHgxRUxrMzMxL1lIeEtRUlQwYkhhejE3QWJhaFVt?=
 =?utf-8?B?YXVWNUVUUUpxRzNCR2RWb1BEV0hYZW5XVm9wRFdTN0ppZDRqemRFYkVKRGcy?=
 =?utf-8?B?UzR3N1EvZzM3ajBoQzRJSkExc1NSdmJZZGtkQ0hHb0NNQjd5LzVKVGt3STB4?=
 =?utf-8?B?cS81SE81V2ZoNnp4Tm44T0JJMlUva3JDMXkycDc4bVhjQ2wxVHZwZXdManA5?=
 =?utf-8?B?c3pUKzcrMFVObVBuVkNlaUdyRllBb3NXSnhVYnd6ZkpiQThBaFZSTUlMQVFZ?=
 =?utf-8?B?NTV2TDM4MmdkUWpBaGNPTWFqZE1TVFZxMWo2emJnWnpoT29DSE91aFd3UW9Z?=
 =?utf-8?Q?zPK/1VHL3r4RUtQ0cwdMHu+h6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09b0c508-3860-4bbe-3fb7-08dc0207adac
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7016.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 09:31:58.8269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NCdIkWDG3PxhS4UeVrEj7GqojTsDgLJDQHyLfi4Uvg3IvyZ3NVdzSrgGAbrznQYrbjFgsu8x/oKoZjm2xk2/nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4242


On 12/20/2023 10:31 PM, Sanath S wrote:
>
> On 12/20/2023 6:28 PM, Mika Westerberg wrote:
>> On Tue, Dec 19, 2023 at 08:04:24PM +0200, Mika Westerberg wrote:
>>>>> One additional question though, say we have PCIe tunnel 
>>>>> established by
>>>>> the BIOS CM and we do the "reset", that means there will be 
>>>>> hot-remove
>>>>> on the PCIe side and then hotplug again, does this slow down the boot
>>>>> considerably? We have some delays there in the PCIe code that 
>>>>> might hit
>>>>> us here although I agree that we definitely prefer working system 
>>>>> rather
>>>>> than fast-booting non-working system but perhaps the delays are not
>>>>> noticeable by the end-user?
>>>> I've not observed any delay which is noticeable. As soon as I get 
>>>> the login
>>>> screen
>>>> and check dmesg, it would already be enumerated.
>>> Okay, I need to try it on my side too.
>> One additional thing that came to mind. Please check with some device
>> with a real PCIe endpoint. For instance there is the integrated xHCI
>> controller on Intel Titan Ridge and Goshen Ridge based docks. With TR it
>> is easy because it does not support USB4 so xHCI is brought up
>> immediately once there is PCIe tunnel. For GR (the OWC dock you have) it
>> is disabled when the link is USB4 (because USB 3.x is tunneled as well)
>> but you can get it enabled too if you connect it with an active TBT3
>> cable.
> Sure. I'll check with these combinations.
Can you name any docks that meets these requirements ? I'll try to get hold
of it here and check.